Skip to contentSkip to conversation

scsi: hisi_sas: Fix sparse warnings in prep_ata_v3_hw()

PATCH Applied Yihang Li 2 participants 2 messages Apr 20 – Apr 21

Subsystems (2)
lore
Share & tools
lore

Yihang Li

author
#0 lore raw

PATCH 1/1 scsi: hisi_sas: Fix sparse warnings in prep_ata_v3_hw()

In prep_ata_v3_hw(), add cpu_to_le32() to fix warning:
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:1448:26: sparse: sparse: invalid assignment: |=
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:1448:26: sparse: left side has type restricted __le32
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:1448:26: sparse: right side has type unsigned int

Fixes 8aa580cd9284 ("scsi: hisi_sas: Enable force phy when SATA disk directly connected")
---
 drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c +1 -1
index f69efc6494b8..1b180d05a7fa 100644
@@ -1491,7 +1491,7 @@ static void prep_ata_v3_hw(struct hisi_hba *hisi_hba,
 		phy_id = device->phy->identify.phy_identifier;
 		hdr->dw0 |= cpu_to_le32((1U << phy_id)
 				<< CMD_HDR_PHY_ID_OFF);
-		hdr->dw0 |= CMD_HDR_FORCE_PHY_MSK;
+		hdr->dw0 |= cpu_to_le32(CMD_HDR_FORCE_PHY_MSK);
 		hdr->dw0 |= cpu_to_le32(4U << CMD_HDR_CMD_OFF);
 	}
 
Signature · 1 line
2.33.0
#1 lore raw

Yihang,

Quoted 4 lines

In prep_ata_v3_hw(), add cpu_to_le32() to fix warning:
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:1448:26: sparse: sparse: invalid assignment: |=
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:1448:26: sparse: left side has type restricted __le32
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:1448:26: sparse: right side has type unsigned int

Applied to 7.1/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen