Skip to contentSkip to conversation

drm/panel: lg-sw43408: remove panel on DSI attach failure

PATCH In review Myeonghun Pak 2 participants 3 messages Apr 20 – Apr 24 1 message not in the archive

Subsystems (4)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): Casey Connolly <[email protected]

#1 lore raw

PATCH 1/1 drm/panel: lg-sw43408: remove panel on DSI attach failure

The probe path registers the panel by calling drm_panel_add() in sw43408_add(), then returns the result of mipi_dsi_attach() directly from sw43408_probe().

If mipi_dsi_attach() fails, the probe path exits without calling drm_panel_remove(), leaving the panel registered in the global DRM panel list. The .remove() callback does not cover this case because it is only invoked after a successful probe.

Fix this by unwinding the panel registration with drm_panel_remove() when mipi_dsi_attach() fails.

---
 drivers/gpu/drm/panel/panel-lg-sw43408.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/gpu/drm/panel/panel-lg-sw43408.c +7 -1
index 293826c50..0eb78bc90 100644
@@ -294,7 +294,13 @@ static int sw43408_probe(struct mipi_dsi_device *dsi)
 
 	dsi->dsc = &ctx->dsc;
 
-	return mipi_dsi_attach(dsi);
+	ret = mipi_dsi_attach(dsi);
+	if (ret < 0) {
+		drm_panel_remove(&ctx->base);
+		return ret;
+	}
+
+	return 0;
 }
 
 static void sw43408_remove(struct mipi_dsi_device *dsi)
#2 lore raw
Quoted 19 lines · Myeonghun Pak

The probe path registers the panel by calling drm_panel_add() in sw43408_add(), then returns the result of mipi_dsi_attach() directly from sw43408_probe().

If mipi_dsi_attach() fails, the probe path exits without calling drm_panel_remove(), leaving the panel registered in the global DRM panel list. The .remove() callback does not cover this case because it is only invoked after a successful probe.

Fix this by unwinding the panel registration with drm_panel_remove() when mipi_dsi_attach() fails.

Quoted 4 lines
---
 drivers/gpu/drm/panel/panel-lg-sw43408.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

You can also switch to devm_drm_panel_add().

Signature · 2 lines
With best wishes
Dmitry
#3 lore raw

Dmitry, Understood. I will apply devm_drm_panel_add() to this patch as well in the next version, which will be submitted as part of the series. Thanks, Myeonghun Pak

2026년 4월 23일 (목) 오전 4:24, Dmitry Baryshkov <
[email protected]>님이 작성:

Quoted 31 lines · Myeonghun Pak
Quoted 19 lines

The probe path registers the panel by calling drm_panel_add() in sw43408_add(), then returns the result of mipi_dsi_attach() directly from sw43408_probe().

If mipi_dsi_attach() fails, the probe path exits without calling drm_panel_remove(), leaving the panel registered in the global DRM panel list. The .remove() callback does not cover this case because it is only invoked after a successful probe.

Fix this by unwinding the panel registration with drm_panel_remove() when mipi_dsi_attach() fails.

Quoted 4 lines
---
 drivers/gpu/drm/panel/panel-lg-sw43408.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

You can also switch to devm_drm_panel_add().

--
With best wishes
Dmitry