Skip to contentSkip to conversation

dts: riscv: spacemit: k3: only keep spacemit,k1-i2c

PATCH NAK Sandie Cao 4 participants 9 messages Apr 20

Subsystems (3)
lore
Share & tools
lore

Sandie Cao

author
#0 lore raw

PATCH 1/1 dts: riscv: spacemit: k3: only keep spacemit,k1-i2c

Fix dtcheck issue: compatible:0: 'spacemit,k1-i2c' was expected

---
 arch/riscv/boot/dts/spacemit/k3.dtsi | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
arch/riscv/boot/dts/spacemit/k3.dtsi +7 -7
index 815debd16409..9a3d2e8cdfe8 100644
@@ -556,7 +556,7 @@ gmac2_axi_setup: stmmac-axi-config {
 		};
 
 		i2c0: i2c@d4010800 {
-			compatible = "spacemit,k3-i2c", "spacemit,k1-i2c";
+			compatible = "spacemit,k1-i2c";
 			reg = <0x0 0xd4010800 0x0 0x38>;
 			#address-cells = <1>;
 			#size-cells = <0>;
@@ -570,7 +570,7 @@ i2c0: i2c@d4010800 {
 		};
 
 		i2c1: i2c@d4011000 {
-			compatible = "spacemit,k3-i2c", "spacemit,k1-i2c";
+			compatible = "spacemit,k1-i2c";
 			reg = <0x0 0xd4011000 0x0 0x38>;
 			#address-cells = <1>;
 			#size-cells = <0>;
@@ -584,7 +584,7 @@ i2c1: i2c@d4011000 {
 		};
 
 		i2c2: i2c@d4012000 {
-			compatible = "spacemit,k3-i2c", "spacemit,k1-i2c";
+			compatible = "spacemit,k1-i2c";
 			reg = <0x0 0xd4012000 0x0 0x38>;
 			#address-cells = <1>;
 			#size-cells = <0>;
@@ -598,7 +598,7 @@ i2c2: i2c@d4012000 {
 		};
 
 		i2c4: i2c@d4012800 {
-			compatible = "spacemit,k3-i2c", "spacemit,k1-i2c";
+			compatible = "spacemit,k1-i2c";
 			reg = <0x0 0xd4012800 0x0 0x38>;
 			#address-cells = <1>;
 			#size-cells = <0>;
@@ -612,7 +612,7 @@ i2c4: i2c@d4012800 {
 		};
 
 		i2c5: i2c@d4013800 {
-			compatible = "spacemit,k3-i2c", "spacemit,k1-i2c";
+			compatible = "spacemit,k1-i2c";
 			reg = <0x0 0xd4013800 0x0 0x38>;
 			#address-cells = <1>;
 			#size-cells = <0>;
@@ -752,7 +752,7 @@ uart9: serial@d4017800 {
 		};
 
 		i2c6: i2c@d4018800 {
-			compatible = "spacemit,k3-i2c", "spacemit,k1-i2c";
+			compatible = "spacemit,k1-i2c";
 			reg = <0x0 0xd4018800 0x0 0x38>;
 			#address-cells = <1>;
 			#size-cells = <0>;
@@ -784,7 +784,7 @@ gpio: gpio@d4019000 {
 		};
 
 		i2c8: i2c@d401d800 {
-			compatible = "spacemit,k3-i2c", "spacemit,k1-i2c";
+			compatible = "spacemit,k1-i2c";
 			reg = <0x0 0xd401d800 0x0 0x38>;
 			#address-cells = <1>;
 			#size-cells = <0>;
Signature · 1 line
2.43.0
#1 lore raw
Quoted 1 line · Sandie Cao

Fix dtcheck issue: compatible:0: 'spacemit,k1-i2c' was expected

Missing space after main commit msg.

Quoted 3 lines

There is no space between tags.

Anyway, explain WHY K3 device does not use K3 compatible. It is clearly violating writing-bindings.

Plus, I don't think this report is correct. You just send us something close to random fix of random warning, without even opening the files and understanding what is there. spacemit,k3-i2c MUST be used with K1. Please read the binding.

NAK

Best regards,
Krzysztof

#2 lore raw
Quoted 8 lines · Krzysztof Kozlowski
Quoted 1 line · Sandie Cao

Fix dtcheck issue: compatible:0: 'spacemit,k1-i2c' was expected

Missing space after main commit msg.

Quoted 3 lines

Also, the file reported in above warning DOES NOT EXIST (I checked next-20260414).

Please do not send reported-by bug reports for things which do not exist.

Best regards,
Krzysztof

reviewer
#3 lore raw
Quoted 4 lines · Krzysztof Kozlowski
Quoted 3 lines · Krzysztof Kozlowski
Quoted 1 line · Sandie Cao

Fix dtcheck issue: compatible:0: 'spacemit,k1-i2c' was expected

Quoted 8 lines
Quoted 5 lines

Missing space after main commit msg.

Quoted 3 lines

Also, the file reported in above warning DOES NOT EXIST (I checked next-20260414).

In Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml:

properties:
compatible:
enum:
- spacemit,k1-pinctrl
- spacemit,k3-pinctrl

So there's no reason to use k1-i2c. As far as I can tell, while they are the same IP, there are subtle differences between them.

- Troy

maintainer
#4 lore raw

Hi Troy,

Quoted 13 lines · Troy Mitchell
Quoted 4 lines · Krzysztof Kozlowski
Quoted 3 lines · Krzysztof Kozlowski
Quoted 1 line · Sandie Cao

Fix dtcheck issue: compatible:0: 'spacemit,k1-i2c' was expected

Quoted 8 lines
Quoted 5 lines

Missing space after main commit msg.

Quoted 3 lines

Also, the file reported in above warning DOES NOT EXIST (I checked next-20260414).

Quoted 8 lines

In Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml:

properties:
compatible:
enum:
- spacemit,k1-pinctrl
- spacemit,k3-pinctrl

I think you refer to wrong file, which should be
Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml

Quoted 3 lines

So there's no reason to use k1-i2c. As far as I can tell, while they are the same IP, there are subtle differences between them.

But yes, the idea is correct, so NAK to this patch

Quoted 1 line

- Troy

Signature · 1 line
Yixun Lan (dlan)
author
#5 lore raw

Hi, Lan & Troy & Krzysztof :

Quoted 33 lines

From: "Yixun Lan"<[email protected]>
Date:  Mon, Apr 20, 2026, 17:09

Hi Troy,

Quoted 13 lines · Troy Mitchell
Quoted 6 lines · Krzysztof Kozlowski
Quoted 5 lines · Krzysztof Kozlowski
Quoted 1 line · Sandie Cao

Fix dtcheck issue: compatible:0: 'spacemit,k1-i2c' was expected


Missing space after main commit msg.

Quoted 6 lines
Quoted 3 lines
Quoted 3 lines

Also, the file reported in above warning DOES NOT EXIST (I checked next-20260414).

Quoted 8 lines

In Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml:

properties:
  compatible:
    enum:
      - spacemit,k1-pinctrl
      - spacemit,k3-pinctrl

I think you refer to wrong file, which should be Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml

Quoted 3 lines

So there's no reason to use k1-i2c. As far as I can tell, while they are the same IP, there are subtle differences between them.

Quoted 6 lines

But yes, the idea is correct, so NAK to this patch

Quoted 1 line

                                  - Troy


--
Yixun Lan (dlan)

Please know that, I send patch[1] to add DeepComputing FML13V05 board device tree.  The patch is based on k1/dt-for-next[2]. And it meets dtscheck issue:

On k1/dt-for-next, it doesn't have spacemit,k3-i2c in Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml. Or I use the wrong branch?

And what should I do for my patch[1] ?

[1] https://lore.kernel.org/all/[email protected]/
[2] https://github.com/spacemit-com/linux/tree/k1/for-next#

Best regards
Sandie

reviewer
#6 lore raw
Quoted 42 lines · Sandie Cao

Hi, Lan & Troy & Krzysztof :

Quoted 33 lines

From: "Yixun Lan"<[email protected]>
Date:  Mon, Apr 20, 2026, 17:09

Hi Troy,

Quoted 13 lines · Troy Mitchell
Quoted 6 lines · Krzysztof Kozlowski
Quoted 5 lines · Krzysztof Kozlowski
Quoted 1 line · Sandie Cao

Fix dtcheck issue: compatible:0: 'spacemit,k1-i2c' was expected


Missing space after main commit msg.

Quoted 6 lines
Quoted 3 lines
Quoted 3 lines

Also, the file reported in above warning DOES NOT EXIST (I checked next-20260414).

Quoted 8 lines

In Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml:

properties:
  compatible:
    enum:
      - spacemit,k1-pinctrl
      - spacemit,k3-pinctrl

I think you refer to wrong file, which should be Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml

Quoted 3 lines

So there's no reason to use k1-i2c. As far as I can tell, while they are the same IP, there are subtle differences between them.

Quoted 6 lines

But yes, the idea is correct, so NAK to this patch

Quoted 1 line

                                  - Troy


--
Yixun Lan (dlan)

Quoted 7 lines

Please know that, I send patch[1] to add DeepComputing FML13V05 board device tree.  The patch is based on k1/dt-for-next[2]. And it meets dtscheck issue:

On k1/dt-for-next, it doesn't have spacemit,k3-i2c in Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml. Or I use the wrong branch?

Yes... You are using a wrong branch I think.
The k1/dt-for-next branch in this repo is Dlan’s tree. Since DT bindings are not within his purview, they aren't included there. I only mentioned this repository earlier to show that the UART portion of the pinctrl dtsi has already been merged into it; it wasn't intended to be used as your development base.

Quoted 2 lines

And what should I do for my patch[1] ?

I think you can use next-20260417 as your base commit. Everything you need is available here.

- Troy

Quoted 6 lines

[1] https://lore.kernel.org/all/[email protected]/
[2] https://github.com/spacemit-com/linux/tree/k1/for-next#

Best regards
Sandie

#7 lore raw
In reply to Sandie Cao
Quoted 10 lines · Sandie Cao

Please know that, I send patch[1] to add DeepComputing FML13V05 board device tree.  The patch is based on k1/dt-for-next[2]. And it meets dtscheck issue:

On k1/dt-for-next, it doesn't have spacemit,k3-i2c in Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml. Or I use the wrong branch?

And what should I do for my patch[1] ?

Test your patch on linux-next. See also maintainer-soc and maintainer-soc-clean-dts profiles in kernel.

Best regards,
Krzysztof

reviewer
#8 lore raw
In reply to Yixun Lan
Quoted 18 lines · Yixun Lan

Hi Troy,

Quoted 15 lines · Troy Mitchell
Quoted 4 lines · Krzysztof Kozlowski
Quoted 3 lines · Krzysztof Kozlowski
Quoted 1 line · Sandie Cao

Fix dtcheck issue: compatible:0: 'spacemit,k1-i2c' was expected

Quoted 8 lines
Quoted 5 lines

Missing space after main commit msg.

Quoted 3 lines

Also, the file reported in above warning DOES NOT EXIST (I checked next-20260414).

In Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml:

Quoted 8 lines
Quoted 6 lines

properties:
compatible:
enum:
- spacemit,k1-pinctrl
- spacemit,k3-pinctrl

I think you refer to wrong file, which should be
Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml

My apologies, I overlooked that. The file you mentioned is indeed correct. Thanks for pointing it out.

- Troy