selftests/bpf: fix off-by-one in bpf_cpumask_populate related selftest
Subsystems (3)
PATCH 1/1 selftests/bpf: fix off-by-one in bpf_cpumask_populate related selftest
The test_populate test uses >= instead of > when checking if the runtime nr_cpus exceeds the bit capacity of a cpumask_t.
On a system where the physical CPU core count perfectly matches the CONFIG_NR_CPUS upper bound (e.g. nr_cpus = 512 and CONFIG_NR_CPUS = 512), the condition nr_cpus >= CPUMASK_TEST_MASKLEN * 8 evaluates to true (512 >= 512). This incorrectly causes the test to fail with an error value of 3.
A 512-bit cpumask_t provides enough bits (indices 0 through 511) to represent 512 CPUs. The subsequent bpf_for(i, 0, nr_cpus) loop iterates up to nr_cpus - 1 (511), which perfectly aligns with the maximum valid index of the bitmask.
Change the condition to nr_cpus > CPUMASK_TEST_MASKLEN * 8 to fix the false positive failure on these systems.
--- tools/testing/selftests/bpf/progs/cpumask_success.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/progs/cpumask_success.c +1 -1
@@ -866,7 +866,7 @@ int BPF_PROG(test_populate, struct task_struct *task, u64 clone_flags)* access NR_CPUS, the upper bound for nr_cpus, so we infer * it from the size of cpumask_t. */ -if (nr_cpus <0 || nr_cpus >=CPUMASK_TEST_MASKLEN *8 ) { +if (nr_cpus <0 || nr_cpus >CPUMASK_TEST_MASKLEN *8 ) { err =3 ; goto out; }
Signature · 1 line
2.54.0.rc1.513.gad8abe7a5a-goog
Quoted 14 lines · Matt Bobrowski
The
test_populatetest uses >= instead of > when checking if the runtimenr_cpusexceeds the bit capacity of acpumask_t.On a system where the physical CPU core count perfectly matches the
CONFIG_NR_CPUSupper bound (e.g.nr_cpus= 512 andCONFIG_NR_CPUS= 512), the conditionnr_cpus>=CPUMASK_TEST_MASKLEN* 8 evaluates to true (512 >= 512). This incorrectly causes the test to fail with an error value of 3.A 512-bit
cpumask_tprovides enough bits (indices 0 through 511) to represent 512 CPUs. The subsequentbpf_for(i, 0, nr_cpus)loop iterates up tonr_cpus- 1 (511), which perfectly aligns with the maximum valid index of the bitmask.
Quoted 5 lines
Change the condition to
nr_cpus>CPUMASK_TEST_MASKLEN* 8 to fix the false positive failure on these systems.Fixes 918ba2636d4e ("selftests: bpf: add bpf_cpumask_populate selftests")Signed-off-by Matt Bobrowski <[email protected]>
Quoted 21 lines
--- tools/testing/selftests/bpf/progs/cpumask_success.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/testing/selftests/bpf/progs/cpumask_success.c +1
-1@@ -866,7 +866,7 @@ int BPF_PROG(test_populate, struct task_struct *task, u64 clone_flags)* access NR_CPUS, the upper bound for nr_cpus, so we infer * it from the size of cpumask_t. */ -if (nr_cpus <0 || nr_cpus >=CPUMASK_TEST_MASKLEN *8 ) { +if (nr_cpus <0 || nr_cpus >CPUMASK_TEST_MASKLEN *8 ) { err =3 ; goto out; }Signature · 1 line
2.54.0.rc1.513.gad8abe7a5a-goog
This patch was applied to bpf/bpf-next.git (master) by Kumar Kartikeya Dwivedi <[email protected]>:
Hello:
This patch was applied to bpf/bpf-next.git (master) by Kumar Kartikeya Dwivedi <[email protected]>:
Quoted 10 lines · On Mon, 20 Apr 2026 09:37:34 +0000 you wrote:
The
test_populatetest uses >= instead of > when checking if the runtimenr_cpusexceeds the bit capacity of acpumask_t.On a system where the physical CPU core count perfectly matches the
CONFIG_NR_CPUSupper bound (e.g.nr_cpus= 512 andCONFIG_NR_CPUS= 512), the conditionnr_cpus>=CPUMASK_TEST_MASKLEN* 8 evaluates to true (512 >= 512). This incorrectly causes the test to fail with an error value of 3.[...]
Here is the summary with links:
- [bpf-next] selftests/bpf: fix off-by-one in bpf_cpumask_populate related selftest
https://git.kernel.org/bpf/bpf-next/c/0aa6378695b8
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html