Skip to contentSkip to conversation

drm: Fix DYNAMIC_DEBUG_MODULE propagation to subdirectories

PATCH In review Sean Paul 3 participants 3 messages Apr 21 – May 2

Subsystems (2)
lore
Share & tools
lore

Sean Paul

author
#0 lore raw

PATCH 1/1 drm: Fix DYNAMIC_DEBUG_MODULE propagation to subdirectories

From: Sean Paul <[email protected]>

Switch incompatible CFLAGS-y to ccflags-* and propagate the flag to subdirectories to avoid implicit declaration errors for _dynamic_func_call_cls when DRM_USE_DYNAMIC_DEBUG is enabled.

Note that this flag is still disabled due to depends on BROKEN.

Fixes 84ec67288c10 ("drm_print: wrap drm_*_dbg in dyndbg descriptor factory macro")

---

a wild seanpaul appears...

 drivers/gpu/drm/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/Makefile +2 -1
index e97faabcd783..7082ff6449fb 100644
@@ -3,7 +3,8 @@
 # Makefile for the drm device driver.  This driver provides support for the
 # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher.
 
-CFLAGS-$(CONFIG_DRM_USE_DYNAMIC_DEBUG)	+= -DDYNAMIC_DEBUG_MODULE
+ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG)	+= -DDYNAMIC_DEBUG_MODULE
+subdir-ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG)	+= -DDYNAMIC_DEBUG_MODULE
 
 # Unconditionally enable W=1 warnings locally
 # --- begin copy-paste W=1 warnings from scripts/Makefile.warn
Signature · 1 line
Sean Paul, Software Engineer, Google / Chromium OS
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Sean Paul

From: Sean Paul <[email protected]>

Switch incompatible CFLAGS-y to ccflags-* and propagate the flag to subdirectories to avoid implicit declaration errors for _dynamic_func_call_cls when DRM_USE_DYNAMIC_DEBUG is enabled.

Note that this flag is still disabled due to depends on BROKEN.

Fixes 84ec67288c10 ("drm_print: wrap drm_*_dbg in dyndbg descriptor factory macro")
Quoted 21 lines

---

a wild seanpaul appears...

  drivers/gpu/drm/Makefile | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/Makefile +2 -1
index e97faabcd783..7082ff6449fb 100644
@@ -3,7 +3,8 @@
  # Makefile for the drm device driver.  This driver provides support for the
  # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher.
 
-CFLAGS-$(CONFIG_DRM_USE_DYNAMIC_DEBUG)	+= -DDYNAMIC_DEBUG_MODULE
+ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG)	+= -DDYNAMIC_DEBUG_MODULE
+subdir-ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG)	+= -DDYNAMIC_DEBUG_MODULE
 
  # Unconditionally enable W=1 warnings locally
  # --- begin copy-paste W=1 warnings from scripts/Makefile.warn
#2 lore raw
Quoted 10 lines · Louis Chauvet
Quoted 6 lines · Sean Paul

From: Sean Paul <[email protected]>

Switch incompatible CFLAGS-y to ccflags-* and propagate the flag to subdirectories to avoid implicit declaration errors for _dynamic_func_call_cls when DRM_USE_DYNAMIC_DEBUG is enabled.

Quoted 7 lines
Quoted 4 lines

Note that this flag is still disabled due to depends on BROKEN.

Fixes 84ec67288c10 ("drm_print: wrap drm_*_dbg in dyndbg descriptor factory macro")