Skip to contentSkip to conversation

hw/hyperv/vmbus: remove duplicate include

PATCH In review Osama Abdelkader 3 participants 5 messages Apr 20 – Apr 21

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/hyperv/vmbus: remove duplicate include

exec/target_page.h is included twice

---
 hw/hyperv/vmbus.c | 1 -
 1 file changed, 1 deletion(-)
hw/hyperv/vmbus.c +0 -1
index 5388f4277f..dcfce70005 100644
@@ -21,7 +21,6 @@
 #include "hw/core/sysbus.h"
 #include "exec/cpu-common.h"
 #include "system/kvm.h"
-#include "exec/target_page.h"
 #include "trace.h"
 
 enum {
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 12 lines · Osama Abdelkader

exec/target_page.h is included twice

---
  hw/hyperv/vmbus.c | 1 -
  1 file changed, 1 deletion(-)
hw/hyperv/vmbus.c +0 -0
index 5388f4277f..dcfce70005 100644

hw/hyperv/vmbus.c line 26

Quoted 7 lines
hw/hyperv/vmbus.c +0 -1
@@ -21,7 +21,6 @@
  #include "hw/core/sysbus.h"
  #include "exec/cpu-common.h"
  #include "system/kvm.h"
-#include "exec/target_page.h"
  #include "trace.h"
 
  enum {

Looks like it's a result of commits 4a695643a9e7 ("hw/hyperv/vmbus:
common compilation unit") and 9c2ff9cdc9b3 ("exec/cpu-all: remove exec/target_page include") adding this include independently within a period of 1 month.

These patches both have Pierrick as author, however they seem to have came into git master via two different patch sets and pull requests.

Thanks,
Maciej

#4 lore raw
Quoted 9 lines · Philippe Mathieu-Daudé
Quoted 6 lines · Osama Abdelkader

exec/target_page.h is included twice

---
  hw/hyperv/vmbus.c | 1 -

  1 file changed, 1 deletion(-)

Patch queued (squashed with other hyperv one), thanks.

Thanks Philippe.

Maciej