Skip to contentSkip to conversation

lib: kunit_iov_iter: Fix test fail on powerpc

PATCH Applied Christian A. Ehrhardt 3 participants 4 messages Apr 21

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib: kunit_iov_iter: Fix test fail on powerpc

Increase buffer size to accomodate machines with
64K PAGE_SIZE.

Cc David Gow <[email protected]>
Fixes 0913b7554726 ("lib: kunit_iov_iter: add tests for extract_iter_to_sg")
---
 lib/tests/kunit_iov_iter.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
lib/tests/kunit_iov_iter.c +5 -5
index 37bd6eb25896..f02f7b7aa796 100644
@@ -1128,7 +1128,7 @@ static void __init iov_kunit_iter_to_sg_kvec(struct kunit *test)
 	struct kvec kvec;
 	size_t bufsize;
 
-	bufsize = 0x100000;
+	bufsize = 0x200000;
 	iov_kunit_iter_to_sg_init(test, bufsize, false, &data);
 
 	kvec.iov_base = data.buffer;
@@ -1146,7 +1146,7 @@ static void __init iov_kunit_iter_to_sg_bvec(struct kunit *test)
 	struct bio_vec *bvec;
 	struct iov_iter iter;
 
-	bufsize = 0x100000;
+	bufsize = 0x200000;
 	iov_kunit_iter_to_sg_init(test, bufsize, false, &data);
 
 	bvec = kunit_kmalloc_array(test, data.npages, sizeof(*bvec),
@@ -1173,7 +1173,7 @@ static void __init iov_kunit_iter_to_sg_folioq(struct kunit *test)
 	struct iov_iter iter;
 	size_t bufsize;
 
-	bufsize = 0x100000;
+	bufsize = 0x200000;
 	iov_kunit_iter_to_sg_init(test, bufsize, false, &data);
 
 	folioq = iov_kunit_create_folioq(test);
@@ -1190,7 +1190,7 @@ static void __init iov_kunit_iter_to_sg_xarray(struct kunit *test)
 	struct iov_iter iter;
 	size_t bufsize;
 
-	bufsize = 0x100000;
+	bufsize = 0x200000;
 	iov_kunit_iter_to_sg_init(test, bufsize, false, &data);
 
 	xarray = iov_kunit_create_xarray(test);
@@ -1206,7 +1206,7 @@ static void __init iov_kunit_iter_to_sg_ubuf(struct kunit *test)
 	struct iov_iter iter;
 	size_t bufsize;
 
-	bufsize = 0x100000;
+	bufsize = 0x200000;
 	iov_kunit_iter_to_sg_init(test, bufsize, true, &data);
 
 	iov_iter_ubuf(&iter, READ, data.ubuf, bufsize);
Signature · 1 line
2.43.0
Reviewed-by
#3 lore raw

Well, I'm *now* aware that David said that it may take some config to get this suite working on NON suse systems.

It is always good to add (or fix) tests anyhow.

I say this patch (code) wise, LGTM. But since I don't own this subsystem.

Thanks!