iio: light: ltr501: cleanup locking and headers
v2 cover iio: light: ltr501: cleanup locking and headers
From: "Rafael B. Sales" <[email protected]>
This series cleans up the iio/light/ltr501.c driver by sorting header inclusions according to the IWYU principles and simplifying locking using automatic cleanup.
Changes in v2:
- Added patch to sort header inclusions
- Fixed naming scheme for functions in commit message
- Reverted original lock boundaries
- Simplified returns
- Used scoped_guard() in switch cases
Rafael B. Sales (2):
iio: light: ltr501: update header inclusions
iio: light: ltr501: use automatic cleanup of locks
drivers/iio/light/ltr501.c | 130 ++++++++++++++++++------------------- 1 file changed, 65 insertions(+), 65 deletions(-)
Signature · 1 line
2.53.0
PATCH v2 1/2 iio: light: ltr501: update header inclusions
From: "Rafael B. Sales" <[email protected]>
Update header inclusions to follow IWYU (Include What You Use) principle
--- drivers/iio/light/ltr501.c | 36 +++++++++++++++++++++++++++--------- 1 file changed, 27 insertions(+), 9 deletions(-)
drivers/iio/light/ltr501.c +27 -9
@@ -9,20 +9,38 @@* TODO: IR LED characteristics */ -#include <linux/module.h> -#include <linux/mod_devicetable.h> -#include <linux/i2c.h> -#include <linux/err.h> +#include <asm/page.h> +#include <linux/array_size.h> +#include <linux/bitops.h> +#include <linux/bits.h> +#include <linux/byteorder/generic.h> +#include <linux/cleanup.h> #include <linux/delay.h> -#include <linux/regmap.h> -#include <linux/regulator/consumer.h> - -#include <linux/iio/iio.h> +#include <linux/dev_printk.h> +#include <linux/device.h> +#include <linux/err.h> +#include <linux/errno.h> +#include <linux/i2c.h> +#include <linux/iio/buffer.h> #include <linux/iio/events.h> +#include <linux/iio/iio.h> #include <linux/iio/sysfs.h> #include <linux/iio/trigger_consumer.h> -#include <linux/iio/buffer.h> #include <linux/iio/triggered_buffer.h> +#include <linux/iio/types.h> +#include <linux/interrupt.h> +#include <linux/irqreturn.h> +#include <linux/math.h> +#include <linux/mod_devicetable.h> +#include <linux/module.h> +#include <linux/mutex.h> +#include <linux/pm.h> +#include <linux/property.h> +#include <linux/regmap.h> +#include <linux/regulator/consumer.h> +#include <linux/sprintf.h> +#include <linux/sysfs.h> +#include <linux/types.h> #define LTR501_ALS_CONTR 0x80/* ALS operation mode, SW reset */ #define LTR501_PS_CONTR 0x81/* PS operation mode */
Signature · 1 line
2.53.0
Jonathan Cameron
maintainerRe: [PATCH v2 1/2] iio: light: ltr501: update header inclusions
Quoted 8 lines · On Mon, 20 Apr 2026 23:10:00 -0300 [email protected] wrote:
From: "Rafael B. Sales" <[email protected]>
Update header inclusions to follow IWYU (Include What You Use) principle
Signed-off-by Rafael B. Sales <[email protected]>Co-developed-by Gustavo C. Arakaki <[email protected]>Signed-off-by Gustavo C. Arakaki <[email protected]>
Hi,
One of the issues with the kernel view of IWYU is it's a bit fuzzy (and not well documented yet).
That means there are some headers we assume will always include certain others. So if you need the 'outer' header the inner one is not normally included as well.
So the comments below are very much my opinion on what should and should not be there. Others may have different views and it is always a little flexible for some of them.
Quoted 9 lines
--- drivers/iio/light/ltr501.c | 36 +++++++++++++++++++++++++++--------- 1 file changed, 27 insertions(+), 9 deletions(-)drivers/iio/light/ltr501.c +0
-0
drivers/iio/light/ltr501.c line 12
Quoted 8 lines
drivers/iio/light/ltr501.c +1
-4@@ -9,20 +9,38 @@* TODO: IR LED characteristics */ -#include <linux/module.h> -#include <linux/mod_devicetable.h> -#include <linux/i2c.h> -#include <linux/err.h> +#include <asm/page.h>
asm headers if they are needed are always in a separate block after all the linux/ ones
However, it is very rare to see asm/page.h in a driver. Why do you need it here?
I'm going to guess it is for PAGE_SIZE?
That bit of code needs a rework to use sysfs_emit_at() instead. If you have time please could you make that change as well as a precursor to this patch and then we won't need this one.
Alternative would be to convert to using read_avail(). That would be even better but is a more complex change.
drivers/iio/light/ltr501.c line 14
Quoted 2 lines
drivers/iio/light/ltr501.c +2
-0+#include <linux/array_size.h> +#include <linux/bitops.h>
I think it is always safe to assume bitops.h will include bits.h
drivers/iio/light/ltr501.c line 17
Quoted 3 lines
drivers/iio/light/ltr501.c +3
-0+#include <linux/bits.h> +#include <linux/byteorder/generic.h> +#include <linux/cleanup.h>
Is this used at this point? I think this might want to be in the following patch.
drivers/iio/light/ltr501.c line 22
Quoted 10 lines
drivers/iio/light/ltr501.c +4
-4#include <linux/delay.h> -#include <linux/regmap.h> -#include <linux/regulator/consumer.h> - -#include <linux/iio/iio.h> +#include <linux/dev_printk.h> +#include <linux/device.h> +#include <linux/err.h> +#include <linux/errno.h>
It's a bit indirect but I think we can always assume err.h will include errno.h
drivers/iio/light/ltr501.c line 30
Quoted 9 lines
drivers/iio/light/ltr501.c +4
-1+#include <linux/i2c.h> +#include <linux/iio/buffer.h> #include <linux/iio/events.h> +#include <linux/iio/iio.h> #include <linux/iio/sysfs.h> #include <linux/iio/trigger_consumer.h> -#include <linux/iio/buffer.h> #include <linux/iio/triggered_buffer.h> +#include <linux/iio/types.h>
Common practice (as this driver was previously doing) is to keep the iio headers in a separate block at the end. I don't tend to enforce this but given the driver was already doing so, I think keeping it that way makes sense.
drivers/iio/light/ltr501.c line 32
Quoted 2 lines
drivers/iio/light/ltr501.c +2
-0+#include <linux/interrupt.h> +#include <linux/irqreturn.h>
interrupt.h will always include irqreturn.h so don't need irqreturn.h
Quoted 14 lines
drivers/iio/light/ltr501.c +11
-0+#include <linux/math.h> +#include <linux/mod_devicetable.h> +#include <linux/module.h> +#include <linux/mutex.h> +#include <linux/pm.h> +#include <linux/property.h> +#include <linux/regmap.h> +#include <linux/regulator/consumer.h> +#include <linux/sprintf.h> +#include <linux/sysfs.h> +#include <linux/types.h> #define LTR501_ALS_CONTR 0x80/* ALS operation mode, SW reset */ #define
LTR501_PS_CONTR0x81/* PS operation mode */
Re: [PATCH v2 1/2] iio: light: ltr501: update header inclusions
Quoted 12 lines · Jonathan Cameron
Quoted 2 lines · On Mon, 20 Apr 2026 23:10:00 -0300 [email protected] wrote:
Update header inclusions to follow IWYU (Include What You Use) principle
One of the issues with the kernel view of IWYU is it's a bit fuzzy (and not well documented yet).
That means there are some headers we assume will always include certain others. So if you need the 'outer' header the inner one is not normally included as well.
Quoted 3 lines
So the comments below are very much my opinion on what should and should not be there. Others may have different views and it is always a little flexible for some of them.
It seems we are on the same page here. Just a couple (I hope insightful for you) comments below.
...
Quoted 6 lines
Quoted 1 line
+#include <
asm/page.h>asm headers if they are needed are always in a separate block after all the linux/ ones
However, it is very rare to see
asm/page.hin a driver. Why do you need it here?
Yeah, the most we should see in the driver(s) as of today are div64.h and/or byteorder.h. And the former is still rare as usually we want math.h.
Quoted 5 lines
I'm going to guess it is for
PAGE_SIZE?That bit of code needs a rework to use
sysfs_emit_at()instead. If you have time please could you make that change as well as a precursor to this patch and then we won't need this one.
+1.
Quoted 2 lines
Alternative would be to convert to using
read_avail(). That would be even better but is a more complex change.
Even more — +2!
...
Quoted 4 lines
Quoted 1 line
+#include <
linux/bitops.h>I think it is always safe to assume
bitops.hwill includebits.hQuoted 1 line
+#include <
linux/bits.h>
Yes. The chain is
bits.h <— bitops.h <— bitmap.h
If the header more to the right is included the left ones are guaranteed to be provided (or rather the APIs they provide are guaranteed to be in the rightmost).
...
Quoted 1 line
Quoted 1 line
+#include <
linux/byteorder/generic.h>
Note, this has not to be included. Yeah, a bit of a voodoo, but asm/byteorder.h is the correct one.
...
Quoted 5 lines
drivers/iio/light/ltr501.c line 22
Quoted 2 lines
drivers/iio/light/ltr501.c +2
-0+#include <linux/err.h> +#include <linux/errno.h> It's a bit indirect but I think we can always assume
err.hwill includeerrno.h
Yes and no. err.h includes asm/errno.h, but linux/err.h. Strictly speaking the use of -EPROBE_DEFER along with IS_ERR(), for example, need to include both. But I personally don't go that far (I do not require people for this particular case) and do not prevent them from doing such (when there is the case as per above example).
...
Quoted 5 lines
drivers/iio/light/ltr501.c line 32
Quoted 2 lines
drivers/iio/light/ltr501.c +2
-0+#include <linux/interrupt.h> +#include <linux/irqreturn.h>
interrupt.hwill always includeirqreturn.hso don't needirqreturn.h
Agree on this implied dependency.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v2 1/2] iio: light: ltr501: update header inclusions
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Jonathan Cameron
On Mon, 20 Apr 2026 23:10:00 -0300
[email protected] wrote:
...
Quoted 7 lines
Quoted 5 lines
drivers/iio/light/ltr501.c line 22
Quoted 2 lines
drivers/iio/light/ltr501.c +2
-0+#include <linux/err.h> +#include <linux/errno.h> It's a bit indirect but I think we can always assume
err.hwill includeerrno.hYes and no.
err.hincludesasm/errno.h, butlinux/err.h. Strictly
I meant "but linux/errno.h" (that includes Linux specific codes >= 512.
Quoted 4 lines
speaking the use of -EPROBE_DEFER along with
IS_ERR(), for example, need to include both. But I personally don't go that far (I do not require people for this particular case) and do not prevent them from doing such (when there is the case as per above example).
Signature · 2 lines
With Best Regards, Andy Shevchenko
PATCH v2 2/2 iio: light: ltr501: use automatic cleanup of locks
In reply to [email protected]From: "Rafael B. Sales" <[email protected]>
Replace mutex_lock() and mutex_unlock() calls with guards to reduce boilerplate and allow for simpler code blocks.
--- drivers/iio/light/ltr501.c | 94 +++++++++++++++----------------------- 1 file changed, 38 insertions(+), 56 deletions(-)
drivers/iio/light/ltr501.c +38 -56
@@ -251,7 +251,7 @@ static int ltr501_ps_read_samp_freq(const struct ltr501_data *data,static int ltr501_als_write_samp_freq (struct ltr501_data *data,int val,int val2) { -int i, ret; +int i; i = ltr501_match_samp_freq(ltr501_als_samp_table, ARRAY_SIZE(ltr501_als_samp_table),
@@ -260,17 +260,14 @@ static int ltr501_als_write_samp_freq(struct ltr501_data *data,if (i <0 )return i; -mutex_lock (&data->lock_als); - ret =regmap_field_write (data->reg_als_rate, i); -mutex_unlock (&data->lock_als); - -return ret; +guard (mutex)(&data->lock_als); +return regmap_field_write (data->reg_als_rate, i); }static int ltr501_ps_write_samp_freq (struct ltr501_data *data,int val,int val2) { -int i, ret; +int i; i = ltr501_match_samp_freq(ltr501_ps_samp_table, ARRAY_SIZE(ltr501_ps_samp_table),
@@ -279,11 +276,8 @@ static int ltr501_ps_write_samp_freq(struct ltr501_data *data,if (i <0 )return i; -mutex_lock (&data->lock_ps); - ret =regmap_field_write (data->reg_ps_rate, i); -mutex_unlock (&data->lock_ps); - -return ret; +guard (mutex)(&data->lock_ps); +return regmap_field_write (data->reg_ps_rate, i); }static int ltr501_als_read_samp_period (const struct ltr501_data *data,int *val)
@@ -505,9 +499,8 @@ static int ltr501_write_intr_prst(struct ltr501_data *data,if (new_val <0 || new_val >0x0f )return -EINVAL ; -mutex_lock (&data->lock_als); - ret =regmap_field_write (data->reg_als_prst, new_val); -mutex_unlock (&data->lock_als); +scoped_guard (mutex, &data->lock_als) + ret = regmap_field_write(data->reg_als_prst, new_val);if (ret >=0 ) data->als_period = period;
@@ -525,9 +518,8 @@ static int ltr501_write_intr_prst(struct ltr501_data *data,if (new_val <0 || new_val >0x0f )return -EINVAL ; -mutex_lock (&data->lock_ps); - ret =regmap_field_write (data->reg_ps_prst, new_val); -mutex_unlock (&data->lock_ps); +scoped_guard (mutex, &data->lock_ps) + ret = regmap_field_write(data->reg_ps_prst, new_val);if (ret >=0 ) data->ps_period = period;
@@ -669,18 +661,16 @@ static int ltr501_read_info_raw(struct ltr501_data *data,switch (chan->type) {case IIO_INTENSITY : -mutex_lock (&data->lock_als); - ret =ltr501_read_als (data, buf); -mutex_unlock (&data->lock_als); +scoped_guard (mutex, &data->lock_als) + ret = ltr501_read_als(data, buf);if (ret <0 )return ret; *val =le16_to_cpu (chan->address ==LTR501_ALS_DATA1 ? buf[0 ] : buf[1 ]);return IIO_VAL_INT ;case IIO_PROXIMITY : -mutex_lock (&data->lock_ps); - ret =ltr501_read_ps (data); -mutex_unlock (&data->lock_ps); +scoped_guard (mutex, &data->lock_ps) + ret = ltr501_read_ps(data);if (ret <0 )return ret; *val = ret <R501_PS_DATA_MASK ;
@@ -705,9 +695,8 @@ static int ltr501_read_raw(struct iio_dev *indio_dev,if (!iio_device_claim_direct (indio_dev))return -EBUSY ; -mutex_lock (&data->lock_als); - ret =ltr501_read_als (data, buf); -mutex_unlock (&data->lock_als); +scoped_guard (mutex, &data->lock_als) + ret = ltr501_read_als(data, buf);iio_device_release_direct (indio_dev);if (ret <0 )return ret;
@@ -820,9 +809,8 @@ static int __ltr501_write_raw(struct iio_dev *indio_dev,if (val !=0 )return -EINVAL ; -mutex_lock (&data->lock_als); - ret =ltr501_set_it_time (data, val2); -mutex_unlock (&data->lock_als); +scoped_guard (mutex, &data->lock_als) + ret = ltr501_set_it_time(data, val2);return ret;default :return -EINVAL ;
@@ -971,18 +959,16 @@ static int ltr501_write_thresh(struct iio_dev *indio_dev,return -EINVAL ;switch (dir) {case IIO_EV_DIR_RISING : -mutex_lock (&data->lock_als); - ret =regmap_bulk_write (data->regmap, -LTR501_ALS_THRESH_UP , - &val,2 ); -mutex_unlock (&data->lock_als); +scoped_guard (mutex, &data->lock_als) + ret = regmap_bulk_write(data->regmap, +LTR501_ALS_THRESH_UP , + &val,2 );return ret;case IIO_EV_DIR_FALLING : -mutex_lock (&data->lock_als); - ret =regmap_bulk_write (data->regmap, -LTR501_ALS_THRESH_LOW , - &val,2 ); -mutex_unlock (&data->lock_als); +scoped_guard (mutex, &data->lock_als) + ret = regmap_bulk_write(data->regmap, +LTR501_ALS_THRESH_LOW , + &val,2 );return ret;default :return -EINVAL ;
@@ -992,18 +978,16 @@ static int ltr501_write_thresh(struct iio_dev *indio_dev,return -EINVAL ;switch (dir) {case IIO_EV_DIR_RISING : -mutex_lock (&data->lock_ps); - ret =regmap_bulk_write (data->regmap, -LTR501_PS_THRESH_UP , - &val,2 ); -mutex_unlock (&data->lock_ps); +scoped_guard (mutex, &data->lock_ps) + ret = regmap_bulk_write(data->regmap, +LTR501_PS_THRESH_UP , + &val,2 );return ret;case IIO_EV_DIR_FALLING : -mutex_lock (&data->lock_ps); - ret =regmap_bulk_write (data->regmap, -LTR501_PS_THRESH_LOW , - &val,2 ); -mutex_unlock (&data->lock_ps); +scoped_guard (mutex, &data->lock_ps) + ret = regmap_bulk_write(data->regmap, +LTR501_PS_THRESH_LOW , + &val,2 );return ret;default :return -EINVAL ;
@@ -1100,14 +1084,12 @@ static int ltr501_write_event_config(struct iio_dev *indio_dev,switch (chan->type) {case IIO_INTENSITY : -mutex_lock (&data->lock_als); - ret =regmap_field_write (data->reg_als_intr, state); -mutex_unlock (&data->lock_als); +scoped_guard (mutex, &data->lock_als) + ret = regmap_field_write(data->reg_als_intr, state);return ret;case IIO_PROXIMITY : -mutex_lock (&data->lock_ps); - ret =regmap_field_write (data->reg_ps_intr, state); -mutex_unlock (&data->lock_ps); +scoped_guard (mutex, &data->lock_ps) + ret = regmap_field_write(data->reg_ps_intr, state);return ret;default :return -EINVAL ;
Signature · 1 line
2.53.0
Jonathan Cameron
maintainerRe: [PATCH v2 2/2] iio: light: ltr501: use automatic cleanup of locks
Quoted 8 lines · On Mon, 20 Apr 2026 23:10:01 -0300 [email protected] wrote:
From: "Rafael B. Sales" <[email protected]>
Replace
mutex_lock()andmutex_unlock()calls with guards to reduce boilerplate and allow for simpler code blocks.Signed-off-by Rafael B. Sales <[email protected]>Co-developed-by Gustavo C. Arakaki <[email protected]>Signed-off-by Gustavo C. Arakaki <[email protected]>
I think a few of these can be done in a cleaner fashion - see below.
Jonathan
Quoted 15 lines
static int
ltr501_als_read_samp_period(const struct ltr501_data *data, int *val)drivers/iio/light/ltr501.c +2
-3@@ -505,9 +499,8 @@ static int ltr501_write_intr_prst(struct ltr501_data *data,if (new_val <0 || new_val >0x0f )return -EINVAL ; -mutex_lock (&data->lock_als); - ret =regmap_field_write (data->reg_als_prst, new_val); -mutex_unlock (&data->lock_als); +scoped_guard (mutex, &data->lock_als) + ret = regmap_field_write(data->reg_als_prst, new_val);if (ret >=0 ) data->als_period = period;
drivers/iio/light/ltr501.c static int ltr501_write_intr_prst(struct ltr501_data *data, · line 524
Quoted 10 lines
drivers/iio/light/ltr501.c +2
-3@@ -525,9 +518,8 @@ static int ltr501_write_intr_prst(struct ltr501_data *data,if (new_val <0 || new_val >0x0f )return -EINVAL ; -mutex_lock (&data->lock_ps); - ret =regmap_field_write (data->reg_ps_prst, new_val); -mutex_unlock (&data->lock_ps); +scoped_guard (mutex, &data->lock_ps) + ret = regmap_field_write(data->reg_ps_prst, new_val);if (ret >=0 ) data->ps_period = period;
This and the one above are more complex as we'd not want to imply protection of ps_period by including it in the lock if that doesn't make sense.
Quoted 4 lines
drivers/iio/light/ltr501.c +0
-0@@ -669,18 +661,16 @@ static int ltr501_read_info_raw(struct ltr501_data *data,switch (chan->type) {
drivers/iio/light/ltr501.c static int ltr501_read_info_raw(struct ltr501_data *data, · line 669
Quoted 10 lines
drivers/iio/light/ltr501.c +2
-3case IIO_INTENSITY : -mutex_lock (&data->lock_als); - ret =ltr501_read_als (data, buf); -mutex_unlock (&data->lock_als); +scoped_guard (mutex, &data->lock_als) + ret = ltr501_read_als(data, buf);if (ret <0 )return ret; *val =le16_to_cpu (chan->address ==LTR501_ALS_DATA1 ? buf[0 ] : buf[1 ]);
This is cheap and local stuff only. For these two cases i'd use {} + guard() as below and not worry about doing this under the lock.
Quoted 11 lines
drivers/iio/light/ltr501.c +2
-3return IIO_VAL_INT ;case IIO_PROXIMITY : -mutex_lock (&data->lock_ps); - ret =ltr501_read_ps (data); -mutex_unlock (&data->lock_ps); +scoped_guard (mutex, &data->lock_ps) + ret = ltr501_read_ps(data);if (ret <0 )return ret; *val = ret <R501_PS_DATA_MASK ;
drivers/iio/light/ltr501.c static int ltr501_read_raw(struct iio_dev *indio_dev, · line 699
Quoted 8 lines
drivers/iio/light/ltr501.c +2
-3@@ -705,9 +695,8 @@ static int ltr501_read_raw(struct iio_dev *indio_dev,if (!iio_device_claim_direct (indio_dev))return -EBUSY ; -mutex_lock (&data->lock_als); - ret =ltr501_read_als (data, buf); -mutex_unlock (&data->lock_als); +scoped_guard (mutex, &data->lock_als) + ret = ltr501_read_als(data, buf);
This use of scoped_guard() does make sense as there is non trivial work to do afterwards.
drivers/iio/light/ltr501.c static int __ltr501_write_raw(struct iio_dev *indio_dev, · line 810
Quoted 6 lines
drivers/iio/light/ltr501.c +0
-0iio_device_release_direct (indio_dev);if (ret <0 )return ret;@@ -820,9 +809,8 @@ static int __ltr501_write_raw(struct iio_dev *indio_dev,if (val !=0 )return -EINVAL ;
I'd use a guard here (see below) for same reasons. It'll just be after this initial sanity check.
Quoted 13 lines
drivers/iio/light/ltr501.c +2
-3-mutex_lock (&data->lock_als); - ret =ltr501_set_it_time (data, val2); -mutex_unlock (&data->lock_als); +scoped_guard (mutex, &data->lock_als) + ret = ltr501_set_it_time(data, val2);return ret;default :return -EINVAL ;@@ -971,18 +959,16 @@ static int ltr501_write_thresh(struct iio_dev *indio_dev,return -EINVAL ;switch (dir) {
drivers/iio/light/ltr501.c static int ltr501_write_thresh(struct iio_dev *indio_dev, · line 965
Quoted 10 lines
drivers/iio/light/ltr501.c +4
-5case IIO_EV_DIR_RISING : -mutex_lock (&data->lock_als); - ret =regmap_bulk_write (data->regmap, -LTR501_ALS_THRESH_UP , - &val,2 ); -mutex_unlock (&data->lock_als); +scoped_guard (mutex, &data->lock_als) + ret = regmap_bulk_write(data->regmap, +LTR501_ALS_THRESH_UP , + &val,2 );
See below.
drivers/iio/light/ltr501.c static int ltr501_write_thresh(struct iio_dev *indio_dev, · line 971
Quoted 11 lines
drivers/iio/light/ltr501.c +4
-5return ret;case IIO_EV_DIR_FALLING : -mutex_lock (&data->lock_als); - ret =regmap_bulk_write (data->regmap, -LTR501_ALS_THRESH_LOW , - &val,2 ); -mutex_unlock (&data->lock_als); +scoped_guard (mutex, &data->lock_als) + ret = regmap_bulk_write(data->regmap, +LTR501_ALS_THRESH_LOW , + &val,2 );
See below.
Quoted 6 lines
drivers/iio/light/ltr501.c +0
-0return ret;default :return -EINVAL ;@@ -992,18 +978,16 @@ static int ltr501_write_thresh(struct iio_dev *indio_dev,return -EINVAL ;switch (dir) {
drivers/iio/light/ltr501.c static int ltr501_write_thresh(struct iio_dev *indio_dev, · line 984
Quoted 10 lines
drivers/iio/light/ltr501.c +4
-5case IIO_EV_DIR_RISING : -mutex_lock (&data->lock_ps); - ret =regmap_bulk_write (data->regmap, -LTR501_PS_THRESH_UP , - &val,2 ); -mutex_unlock (&data->lock_ps); +scoped_guard (mutex, &data->lock_ps) + ret = regmap_bulk_write(data->regmap, +LTR501_PS_THRESH_UP , + &val,2 );
See below.
drivers/iio/light/ltr501.c static int ltr501_write_thresh(struct iio_dev *indio_dev, · line 990
Quoted 11 lines
drivers/iio/light/ltr501.c +4
-5return ret;case IIO_EV_DIR_FALLING : -mutex_lock (&data->lock_ps); - ret =regmap_bulk_write (data->regmap, -LTR501_PS_THRESH_LOW , - &val,2 ); -mutex_unlock (&data->lock_ps); +scoped_guard (mutex, &data->lock_ps) + ret = regmap_bulk_write(data->regmap, +LTR501_PS_THRESH_LOW , + &val,2 );
See below.
drivers/iio/light/ltr501.c static int ltr501_write_event_config(struct iio_dev *indio_dev, · line 1089
Quoted 13 lines
drivers/iio/light/ltr501.c +2
-3return ret;default :return -EINVAL ;@@ -1100,14 +1084,12 @@ static int ltr501_write_event_config(struct iio_dev *indio_dev,switch (chan->type) {case IIO_INTENSITY : -mutex_lock (&data->lock_als); - ret =regmap_field_write (data->reg_als_intr, state); -mutex_unlock (&data->lock_als); +scoped_guard (mutex, &data->lock_als) + ret = regmap_field_write(data->reg_als_intr, state);return ret;
for these I'd rather see the pattern
case IIO_INTENSITY: {
guard(mutex)(&data->lock_als);
return regmap_field_write();
}The scoped_guard() has some annoying issues wrt to compilers and their ability to see that the loop (it's a for loop underneath) is always entered and so you can't move the return in there. The bare guard() form doesn't have that problem.
drivers/iio/light/ltr501.c static int ltr501_write_event_config(struct iio_dev *indio_dev, · line 1092
Quoted 6 lines
drivers/iio/light/ltr501.c +2
-3case IIO_PROXIMITY : -mutex_lock (&data->lock_ps); - ret =regmap_field_write (data->reg_ps_intr, state); -mutex_unlock (&data->lock_ps); +scoped_guard (mutex, &data->lock_ps) + ret = regmap_field_write(data->reg_ps_intr, state);
As above.
Quoted 3 lines
drivers/iio/light/ltr501.c +0
-0return ret;default :return -EINVAL ;