drm/amd/pm: remove trailing semicolon from AMDGPU_PM_POLICY_ATTR macro
Subsystems (3)
PATCH 1/1 drm/amd/pm: remove trailing semicolon from AMDGPU_PM_POLICY_ATTR macro
macros should not include a trailing semicolon as per kernel coding style (checkpatch.pl warning).
move the semicolon from the macro definition to the invocation sites instead.
checkpatch.pl logs:
WARNING: macros should not use a trailing semicolon
+#define AMDGPU_PM_POLICY_ATTR(_name, _id) \
+ static struct amdgpu_pm_policy_attr pm_policy_attr_##_name = { \
+ .dev_attr = __ATTR(_name, 0644, amdgpu_get_pm_policy_attr, \
+ amdgpu_set_pm_policy_attr), \
+ .id = PP_PM_POLICY_##_id, \
+ };
--- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/pm/amdgpu_pm.c +3 -3
@@ -2505,12 +2505,12 @@ static ssize_t amdgpu_set_pm_policy_attr(struct device *dev, .dev_attr = __ATTR(_name, 0644, amdgpu_get_pm_policy_attr, \ amdgpu_set_pm_policy_attr), \ .id = PP_PM_POLICY_##_id, \ - }; + }#define AMDGPU_PM_POLICY_ATTR_VAR (_name) pm_policy_attr_##_name.dev_attr.attr -AMDGPU_PM_POLICY_ATTR(soc_pstate, SOC_PSTATE) -AMDGPU_PM_POLICY_ATTR(xgmi_plpd, XGMI_PLPD) +AMDGPU_PM_POLICY_ATTR (soc_pstate,SOC_PSTATE ); +AMDGPU_PM_POLICY_ATTR (xgmi_plpd,XGMI_PLPD );static struct attribute *pm_policy_attrs[] = { &AMDGPU_PM_POLICY_ATTR_VAR (soc_pstate),
Signature · 1 line
2.47.3
[Public]
Quoted 22 lines
-----Original Message-----
From: Wang, Yang(Kevin) <[email protected]>
Sent: Tuesday, April 21, 2026 4:45 AM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>
Subject: [PATCH] drm/amd/pm: remove trailing semicolon fromAMDGPU_PM_POLICY_ATTRmacromacros should not include a trailing semicolon as per kernel coding style (checkpatch.pl warning).
move the semicolon from the macro definition to the invocation sites instead.
checkpatch.pl logs:
WARNING: macros should not use a trailing semicolon(quoted diff) +6
-0+#define AMDGPU_PM_POLICY_ATTR(_name, _id) \ + static struct amdgpu_pm_policy_attr pm_policy_attr_##_name = { \ + .dev_attr = __ATTR(_name, 0644, amdgpu_get_pm_policy_attr, \ + amdgpu_set_pm_policy_attr), \ + .id = PP_PM_POLICY_##_id, \ + };
Quoted 3 lines
Fixes 4d154b1ca580 ("drm/amd/pm: Add support for DPM policies")Signed-off-by Yang Wang <[email protected]>
Quoted 30 lines
--- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/amd/pm/amdgpu_pm.c +1
-1@@ -2505,12 +2505,12 @@ static ssize_t amdgpu_set_pm_policy_attr(struct device *dev, .dev_attr = __ATTR(_name, 0644, amdgpu_get_pm_policy_attr, \ amdgpu_set_pm_policy_attr), \ .id = PP_PM_POLICY_##_id, \ - }; + } #define AMDGPU_PM_POLICY_ATTR_VAR(_name)pm_policy_attr_##_name.dev_attr.attr
-AMDGPU_PM_POLICY_ATTR(soc_pstate,
SOC_PSTATE) -AMDGPU_PM_POLICY_ATTR(xgmi_plpd, XGMI_PLPD)drivers/gpu/drm/amd/pm/amdgpu_pm.c +2
-1+AMDGPU_PM_POLICY_ATTR (soc_pstate,SOC_PSTATE ); +AMDGPU_PM_POLICY_ATTR (xgmi_plpd,XGMI_PLPD );static struct attribute *pm_policy_attrs[] = { &AMDGPU_PM_POLICY_ATTR_VAR (soc_pstate), --2.47.3