ASoC: dt-bindings: mediatek: Convert mtk-btcvsd-snd to DT Schema
Subsystems (4)
PATCH v3 1/1 ASoC: dt-bindings: mediatek: Convert mtk-btcvsd-snd to DT Schema
Convert the mtk-btcvsd-snd.txt DT binding to DT Schema format.
---
Changes in v3:
Sorry about the spam. A second round of dt_binding_check + dtbs_check led me to additional improvements:
- Use reg-names in place of a non-informative description property
- Simplify the reg property in the example
Changes in v2 [2]:
- Fixed issues from make dt_binding_check
- Set myself as maintainer for the binding
Initial version [1].
[1] https://lore.kernel.org/[email protected]/
[2] https://lore.kernel.org/[email protected]/
.../sound/mediatek,mtk-btcvsd-snd.yaml | 66 +++++++++++++++++++ .../bindings/sound/mtk-btcvsd-snd.txt | 24 ------- 2 files changed, 66 insertions(+), 24 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/mediatek,mtk-btcvsd-snd.yaml delete mode 100644 Documentation/devicetree/bindings/sound/mtk-btcvsd-snd.txt
Documentation/devicetree/bindings/sound/mediatek,mtk-btcvsd-snd.yaml new file +66 -0
@@ -0,0 +1,66 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/mediatek,mtk-btcvsd-snd.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Mediatek ALSA BT SCO CVSD/MSBC Driver + +maintainers: + - Luca Leonardo Scorcia <[email protected]> + +properties: + compatible: + const: mediatek,mtk-btcvsd-snd + + reg: + minItems: 2 + maxItems: 2 + + reg-names: + items: + - const: pkv + - const: sram-bank2 + + interrupts: + items: + - description: BT-SCO interrupt + + mediatek,infracfg: + $ref: /schemas/types.yaml#/definitions/phandle + description: The phandle of the infracfg controller + + mediatek,offset: + $ref: /schemas/types.yaml#/definitions/uint32-array + description: Array of register offsets and masks + items: + - description: infra_misc_offset + - description: infra_conn_bt_cvsd_mask + - description: cvsd_mcu_read_offset + - description: cvsd_mcu_write_offset + - description: cvsd_packet_indicator_offset + +required: + - compatible + - reg + - reg-names + - interrupts + - mediatek,infracfg + - mediatek,offset + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/interrupt-controller/irq.h> + + mtk-btcvsd-snd@18000000 { + compatible = "mediatek,mtk-btcvsd-snd"; + reg = <0x18000000 0x1000>, + <0x18080000 0x8000>; + reg-names = "pkv", "sram-bank2"; + interrupts = <GIC_SPI 286 IRQ_TYPE_LEVEL_LOW>; + mediatek,infracfg = <&infrasys>; + mediatek,offset = <0xf00 0x800 0xfd0 0xfd4 0xfd8>; + };
Documentation/devicetree/bindings/sound/mtk-btcvsd-snd.txt deleted +0 -24
@@ -1,24 +0,0 @@ -Mediatek ALSA BT SCO CVSD/MSBC Driver - -Required properties: -- compatible = "mediatek,mtk-btcvsd-snd"; -- reg: register location and size of PKV and SRAM_BANK2 -- interrupts: should contain BTSCO interrupt -- mediatek,infracfg: the phandles of INFRASYS -- mediatek,offset: Array contains of register offset and mask - infra_misc_offset, - infra_conn_bt_cvsd_mask, - cvsd_mcu_read_offset, - cvsd_mcu_write_offset, - cvsd_packet_indicator_offset - -Example: - - mtk-btcvsd-snd@18000000 { - compatible = "mediatek,mtk-btcvsd-snd"; - reg=<0 0x18000000 0 0x1000>, - <0 0x18080000 0 0x8000>; - interrupts = <GIC_SPI 286 IRQ_TYPE_LEVEL_LOW>; - mediatek,infracfg = <&infrasys>; - mediatek,offset = <0xf00 0x800 0xfd0 0xfd4 0xfd8>; - };
Signature · 1 line
2.43.0
Quoted 1 line · Luca Leonardo Scorcia
+title: Mediatek ALSA BT SCO CVSD/MSBC Driver
s/Driver//
Documentation/devicetree/bindings/sound/mediatek,mtk-btcvsd-snd.yaml line 17
Quoted 10 lines
Documentation/devicetree/bindings/sound/mediatek,mtk-btcvsd-snd.yaml new file +10
-0+ +maintainers: + - Luca Leonardo Scorcia <[email protected]> + +properties: + compatible: + const: mediatek,mtk-btcvsd-snd + + reg: + minItems: 2
Drop
Quoted 1 line
+ maxItems: 2
and actually drop this too and list the items with description - PKV and SRAM_BANK2 regions
Documentation/devicetree/bindings/sound/mediatek,mtk-btcvsd-snd.yaml line 23
Quoted 5 lines
Documentation/devicetree/bindings/sound/mediatek,mtk-btcvsd-snd.yaml new file +5
-0+ + reg-names: + items: + - const: pkv + - const: sram-bank2
Old binding did not have reg-names and nothing in commit msg explains changes done to the binding.
To remind: if you change the binding, you must mention it and explain WHY.
I don't see any use of that, so why did you add it?
Best regards,
Krzysztof