Skip to contentSkip to conversation

tests/functional/qemu_test: Silence warnings from pylint in tesseract.py

PATCH In review Thomas Huth 2 participants 2 messages Apr 22

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 tests/functional/qemu_test: Silence warnings from pylint in tesseract.py

From: Thomas Huth <[email protected]>

Pylint complains:

tesseract.py:1:0: C0114: Missing module docstring (missing-module-docstring)
tesseract.py:12:0: C0116: Missing function or method docstring (missing-function-docstring) tesseract.py:15:11: W1510: 'subprocess.run' used without explicitly defining the value for 'check'. (subprocess-run-check) tesseract.py:12:30: W0613: Unused argument 'tesseract_args' (unused-argument)

Thus add the missing bits and remove the unused tesseract_args argument. While we're at it, also add a SPDX identifier instead of the weird three dots at the beginning of the file, and drop the license boilerplate text.

---
v2: Drop the license boilerplate text as suggested by Philippe.

 tests/functional/qemu_test/tesseract.py | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)
tests/functional/qemu_test/tesseract.py +8 -6
index ede6c6501e2..2e84c1975c2 100644
@@ -1,19 +1,21 @@
-# ...
+# SPDX-License-Identifier: GPL-2.0-or-later
 #
 # Copyright (c) 2019 Philippe Mathieu-Daudé <[email protected]>
-#
-# This work is licensed under the terms of the GNU GPL, version 2 or
-# later. See the COPYING file in the top-level directory.
+'''
+Tesseract is an program for doing Optical Character Recognition (OCR),
+which can be used in the tests to extract text from screenshots.
+'''
 
 import logging
 from subprocess import run
 
 
-def tesseract_ocr(image_path, tesseract_args=''):
+def tesseract_ocr(image_path):
+    ''' Run the tesseract OCR to extract text from a screenshot '''
     console_logger = logging.getLogger('console')
     console_logger.debug(image_path)
     proc = run(['tesseract', image_path, 'stdout'],
-               capture_output=True, encoding='utf8')
+               capture_output=True, encoding='utf8', check=False)
     if proc.returncode:
         return None
     lines = []
Signature · 1 line
2.53.0
Reviewed-by on v2 1/1
#1 lore raw
Quoted 13 lines · Thomas Huth

From: Thomas Huth <[email protected]>

Pylint complains:

tesseract.py:1:0: C0114: Missing module docstring (missing-module-docstring)
tesseract.py:12:0: C0116: Missing function or method docstring (missing-function-docstring) tesseract.py:15:11: W1510: 'subprocess.run' used without explicitly defining the value for 'check'. (subprocess-run-check) tesseract.py:12:30: W0613: Unused argument 'tesseract_args' (unused-argument)

Thus add the missing bits and remove the unused tesseract_args argument. While we're at it, also add a SPDX identifier instead of the weird three dots at the beginning of the file, and drop the license boilerplate text.

Quoted 6 lines

---
v2: Drop the license boilerplate text as suggested by Philippe.

  tests/functional/qemu_test/tesseract.py | 14 ++++++++------
  1 file changed, 8 insertions(+), 6 deletions(-)