Skip to contentSkip to conversation

include: Remove 'make install' support

PATCH In review Petr Vorel 4 participants 6 messages Apr 22 – Apr 24

lore
Share & tools
lore

Petr Vorel

author
#0 lore raw

PATCH 1/1 include: Remove 'make install' support

LTP headers aren't needed to be installed, they are unusable without LTP core library anyway (which is not separated from sources). Therefore newly added Makefile for 'make check' in 684cae7552 ("include/lapi: add leaf Makefile") did not support it. Remove it also from include/Makefile.

---
Hi,

trivial patch, but I'd appreciate your ack that we really don't want headers to be installed. Otherwise it'd have to be added also to include/lapi/Makefile (added in 684cae7552).

Kind regards,
Petr

 include/Makefile | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)
include/Makefile +1 -8
index 84cd4ed6e3..7fe72a2557 100644
@@ -1,19 +1,12 @@
 # SPDX-License-Identifier: GPL-2.0-or-later
 # Copyright (C) 2009, Cisco Systems Inc.
+# Copyright (c) Linux Test Project, 2026
 # Ngie Cooper, July 2009
 
 top_srcdir		?= ..
 
 include $(top_srcdir)/include/mk/env_pre.mk
 
-INSTALL_DIR		:= $(includedir)
-
-INSTALL_MODE		:= 00644
-
-INSTALL_TARGETS		:= *.h
-
-MAKE_TARGETS		:=
-
 .PHONY: ac-clean ac-distclean ac-maintainer-clean distclean maintainer-clean
 distclean:: clean ac-distclean
 maintainer-clean:: distclean ac-maintainer-clean
Signature · 5 lines
2.53.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
Reviewed-by LTP AI Reviewer on v1 1/1
#1 lore raw

Hi Petr,

Quoted 3 lines · Petr Vorel

include: Remove 'make install' support

+# Copyright (c) Linux Test Project, 2026

Nit: existing line above uses "(C)" (uppercase); "(c)" here is inconsistent.

---
Note:

Our agent completed the review of the patch. The full review can be found at: <review_url>

The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Reviewed-by Ricardo B. Marlière on v1 1/1
#2 lore raw
In reply to Petr Vorel
Quoted 7 lines · Petr Vorel

LTP headers aren't needed to be installed, they are unusable without LTP core library anyway (which is not separated from sources). Therefore newly added Makefile for 'make check' in 684cae7552 ("include/lapi: add leaf Makefile") did not support it. Remove it also from include/Makefile.

Quoted 6 lines

---
Hi,

trivial patch, but I'd appreciate your ack that we really don't want headers to be installed. Otherwise it'd have to be added also to include/lapi/Makefile (added in 684cae7552).

Thanks!

Quoted 32 lines

Kind regards,
Petr

 include/Makefile | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)
include/Makefile +1 -8
index 84cd4ed6e3..7fe72a2557 100644
@@ -1,19 +1,12 @@
 # SPDX-License-Identifier: GPL-2.0-or-later
 # Copyright (C) 2009, Cisco Systems Inc.
+# Copyright (c) Linux Test Project, 2026
 # Ngie Cooper, July 2009
 
 top_srcdir		?= ..
 
 include $(top_srcdir)/include/mk/env_pre.mk
 
-INSTALL_DIR		:= $(includedir)
-
-INSTALL_MODE		:= 00644
-
-INSTALL_TARGETS		:= *.h
-
-MAKE_TARGETS		:=
-
 .PHONY: ac-clean ac-distclean ac-maintainer-clean distclean maintainer-clean
 distclean:: clean ac-distclean
 maintainer-clean:: distclean ac-maintainer-clean
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Reviewed-by on v1 1/1
#3 lore raw
In reply to Petr Vorel
Quoted 5 lines · Petr Vorel

LTP headers aren't needed to be installed, they are unusable without LTP core library anyway (which is not separated from sources). Therefore newly added Makefile for 'make check' in 684cae7552 ("include/lapi: add leaf Makefile") did not support it. Remove it also from include/Makefile.

That's right, we don't need to install the LTP headers.

Signature · 5 lines
Regards,
Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
Acked-by Jan Stancek on v1 1/1
#4 lore raw
In reply to Petr Vorel
Quoted 8 lines · Petr Vorel

LTP headers aren't needed to be installed, they are unusable without LTP core library anyway (which is not separated from sources). Therefore newly added Makefile for 'make check' in 684cae7552 ("include/lapi: add leaf Makefile") did not support it. Remove it also from include/Makefile.

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
author
#5 lore raw
Quoted 11 lines · Petr Vorel
Quoted 8 lines

LTP headers aren't needed to be installed, they are unusable without LTP core library anyway (which is not separated from sources). Therefore newly added Makefile for 'make check' in 684cae7552 ("include/lapi: add leaf Makefile") did not support it. Remove it also from include/Makefile.

Jan, thanks for your ack. I merged patch yesterday, I'm sorry, unfortunately I forgot to write that on ML. Next time I'll wait a bit longer and verify that I replied that patch was merged (it'd be great to have tooling to post info about merging).

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp