Skip to contentSkip to conversation

MAINTAINERS: fix regex pattern in CORE MM category

PATCH Applied Pedro Falcato 5 participants 8 messages Apr 22 – May 5 Memory management

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: fix regex pattern in CORE MM category

The pattern "include/linux/page[-_]*" matches every file that starts with "page", because it's a regex and not a glob (so it has the meaning of include/linux/page + match [-_] 0+ times).

Fix it up into a more regex-correct expression. Doing so reduces CC's drastically in patches that touch pagemap.h (which is maintained as part of PAGE CACHE).

As a side-effect, move linux/pageblock-flags.h explicitly under PAGE ALLOCATOR.

---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +2 -1
index d25342ca8aa1..224c15299acc 100644
@@ -16804,7 +16804,7 @@ F:	mm/sparse.c
 F:	mm/util.c
 F:	mm/vmpressure.c
 F:	mm/vmstat.c
-N:	include/linux/page[-_]*
+N:	include\/linux\/page[-_][a-zA-Z]*
 
 MEMORY MANAGEMENT - EXECMEM
 M:	Andrew Morton <[email protected]>
@@ -16961,6 +16961,7 @@ S:	Maintained
 F:	include/linux/compaction.h
 F:	include/linux/gfp.h
 F:	include/linux/page-isolation.h
+F:	include/linux/pageblock-flags.h
 F:	mm/compaction.c
 F:	mm/debug_page_alloc.c
 F:	mm/debug_page_ref.c
Signature · 1 line
2.53.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Pedro Falcato

The pattern "include/linux/page[-_]*" matches every file that starts with "page", because it's a regex and not a glob (so it has the meaning of include/linux/page + match [-_] 0+ times).

Fix it up into a more regex-correct expression. Doing so reduces CC's drastically in patches that touch pagemap.h (which is maintained as part of PAGE CACHE).

Quoted 5 lines

As a side-effect, move linux/pageblock-flags.h explicitly under PAGE ALLOCATOR.

LGTM, so:

Quoted 28 lines
---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +2 -2
index d25342ca8aa1..224c15299acc 100644
@@ -16804,7 +16804,7 @@ F:	mm/sparse.c
 F:	mm/util.c
 F:	mm/vmpressure.c
 F:	mm/vmstat.c
-N:	include/linux/page[-_]*
+N:	include\/linux\/page[-_][a-zA-Z]*
 
 MEMORY MANAGEMENT - EXECMEM
 M:	Andrew Morton <[email protected]>
@@ -16961,6 +16961,7 @@ S:	Maintained
 F:	include/linux/compaction.h
 F:	include/linux/gfp.h
 F:	include/linux/page-isolation.h
+F:	include/linux/pageblock-flags.h
 F:	mm/compaction.c
 F:	mm/debug_page_alloc.c
 F:	mm/debug_page_ref.c
--

2.53.0

Acked-by on v1 1/1
#2 lore raw
In reply to Pedro Falcato
Quoted 7 lines · Pedro Falcato

The pattern "include/linux/page[-_]*" matches every file that starts with "page", because it's a regex and not a glob (so it has the meaning of include/linux/page + match [-_] 0+ times).

Fix it up into a more regex-correct expression. Doing so reduces CC's drastically in patches that touch pagemap.h (which is maintained as part of PAGE CACHE).

Nice

Signature · 3 lines
Cheers,

David
Acked-by on v1 1/1
#3 lore raw
In reply to Pedro Falcato
Quoted 8 lines · Pedro Falcato

The pattern "include/linux/page[-_]*" matches every file that starts with "page", because it's a regex and not a glob (so it has the meaning of include/linux/page + match [-_] 0+ times).

Fix it up into a more regex-correct expression. Doing so reduces CC's drastically in patches that touch pagemap.h (which is maintained as part of PAGE CACHE).

Quoted 5 lines

As a side-effect, move linux/pageblock-flags.h explicitly under PAGE ALLOCATOR.

Quoted 25 lines
---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +2 -1
index d25342ca8aa1..224c15299acc 100644
@@ -16804,7 +16804,7 @@ F:	mm/sparse.c
 F:	mm/util.c
 F:	mm/vmpressure.c
 F:	mm/vmstat.c
-N:	include/linux/page[-_]*
+N:	include\/linux\/page[-_][a-zA-Z]*
 
 MEMORY MANAGEMENT - EXECMEM
 M:	Andrew Morton <[email protected]>
@@ -16961,6 +16961,7 @@ S:	Maintained
 F:	include/linux/compaction.h
 F:	include/linux/gfp.h
 F:	include/linux/page-isolation.h
+F:	include/linux/pageblock-flags.h
 F:	mm/compaction.c
 F:	mm/debug_page_alloc.c
 F:	mm/debug_page_ref.c
Reviewed-by on v1 1/1
#4 lore raw
In reply to Pedro Falcato
Quoted 4 lines · On Wed, 22 Apr 2026 13:37:26 +0100 Pedro Falcato <[email protected]> wrote:

The pattern "include/linux/page[-_]*" matches every file that starts with "page", because it's a regex and not a glob (so it has the meaning of include/linux/page + match [-_] 0+ times).

Quoted 8 lines

Fix it up into a more regex-correct expression. Doing so reduces CC's drastically in patches that touch pagemap.h (which is maintained as part of PAGE CACHE).

As a side-effect, move linux/pageblock-flags.h explicitly under PAGE ALLOCATOR.

Just thinking loud. I was initially wondering the purpose of this link. Seems this was added to show the example of pagemap.h touching patch that can dmonstrate how many CC can be reduced. I once thought about suggesting to add the number or the context on the description, but realize it is too trivial. So just thinking loud.

$ # Without this patch
$ ./scripts/get_maintainer.pl ./0001-mm-limit-filemap-fault-readahead-to-vma-boundaries.patch | wc -l
13
$ # With this patch
$ ./scripts/get_maintainer.pl ./0001-mm-limit-filemap-fault-readahead-to-vma-boundaries.patch | wc -l
6
Quoted 1 line

Thanks,
SJ

[...]

#5 lore raw
Quoted 13 lines · SeongJae Park
Quoted 11 lines · On Wed, 22 Apr 2026 13:37:26 +0100 Pedro Falcato <[email protected]> wrote:

The pattern "include/linux/page[-_]*" matches every file that starts with "page", because it's a regex and not a glob (so it has the meaning of include/linux/page + match [-_] 0+ times).

Fix it up into a more regex-correct expression. Doing so reduces CC's drastically in patches that touch pagemap.h (which is maintained as part of PAGE CACHE).

As a side-effect, move linux/pageblock-flags.h explicitly under PAGE ALLOCATOR.

Quoted 7 lines
Quoted 1 line

Just thinking loud. I was initially wondering the purpose of this link. Seems this was added to show the example of pagemap.h touching patch that can dmonstrate how many CC can be reduced. I once thought about suggesting to add the number or the context on the description, but realize it is too trivial. So just thinking loud.

Right, I probably chucked that link in there without explaining it well enough. I was having my leasurely read through linux-mm when I noticed that particular patch had _way_ too many CC's. I had a quick look and, yeah, found the issue.

For what it's worth there are many such CC's out there. A group of 6-8 MM people get CC'd on pretty much everything that happens in the kernel. Not super wieldy.

One thing at a time, I guess.

Quoted 11 lines
$ # Without this patch
$ ./scripts/get_maintainer.pl ./0001-mm-limit-filemap-fault-readahead-to-vma-boundaries.patch | wc -l
13
$ # With this patch
$ ./scripts/get_maintainer.pl ./0001-mm-limit-filemap-fault-readahead-to-vma-boundaries.patch | wc -l
6
Quoted 1 line

Thanks!

Signature · 1 line
Pedro
#6 lore raw
Quoted 27 lines · Pedro Falcato
Quoted 13 lines · SeongJae Park
Quoted 11 lines · On Wed, 22 Apr 2026 13:37:26 +0100 Pedro Falcato <[email protected]> wrote:

The pattern "include/linux/page[-_]*" matches every file that starts with "page", because it's a regex and not a glob (so it has the meaning of include/linux/page + match [-_] 0+ times).

Fix it up into a more regex-correct expression. Doing so reduces CC's drastically in patches that touch pagemap.h (which is maintained as part of PAGE CACHE).

As a side-effect, move linux/pageblock-flags.h explicitly under PAGE ALLOCATOR.

Quoted 7 lines
Quoted 1 line

Just thinking loud. I was initially wondering the purpose of this link. Seems this was added to show the example of pagemap.h touching patch that can dmonstrate how many CC can be reduced. I once thought about suggesting to add the number or the context on the description, but realize it is too trivial. So just thinking loud.

Right, I probably chucked that link in there without explaining it well enough. I was having my leasurely read through linux-mm when I noticed that particular patch had _way_ too many CC's. I had a quick look and, yeah, found the issue.

Quoted 4 lines

For what it's worth there are many such CC's out there. A group of 6-8 MM people get CC'd on pretty much everything that happens in the kernel. Not super wieldy.

One thing at a time, I guess.

Yup this is a useful addition, the link is fine one thing at a time indeed :)

Quoted 9 lines
Quoted 9 lines

$ # Without this patch
$ ./scripts/get_maintainer.pl ./0001-mm-limit-filemap-fault-readahead-to-vma-boundaries.patch | wc -l
13
$ # With this patch
$ ./scripts/get_maintainer.pl ./0001-mm-limit-filemap-fault-readahead-to-vma-boundaries.patch | wc -l
6
Quoted 8 lines
Quoted 3 lines
Quoted 1 line

Thanks!

--
Pedro

Cheers, Lorenzo

Reviewed-by on v1 1/1
#7 lore raw
In reply to Pedro Falcato
Quoted 8 lines · Pedro Falcato

The pattern "include/linux/page[-_]*" matches every file that starts with "page", because it's a regex and not a glob (so it has the meaning of include/linux/page + match [-_] 0+ times).

Fix it up into a more regex-correct expression. Doing so reduces CC's drastically in patches that touch pagemap.h (which is maintained as part of PAGE CACHE).

Quoted 5 lines

As a side-effect, move linux/pageblock-flags.h explicitly under PAGE ALLOCATOR.

If I didn't already say,

:)

Cheers, Lorenzo

Quoted 28 lines
---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +2 -2
index d25342ca8aa1..224c15299acc 100644
@@ -16804,7 +16804,7 @@ F:	mm/sparse.c
 F:	mm/util.c
 F:	mm/vmpressure.c
 F:	mm/vmstat.c
-N:	include/linux/page[-_]*
+N:	include\/linux\/page[-_][a-zA-Z]*
 
 MEMORY MANAGEMENT - EXECMEM
 M:	Andrew Morton <[email protected]>
@@ -16961,6 +16961,7 @@ S:	Maintained
 F:	include/linux/compaction.h
 F:	include/linux/gfp.h
 F:	include/linux/page-isolation.h
+F:	include/linux/pageblock-flags.h
 F:	mm/compaction.c
 F:	mm/debug_page_alloc.c
 F:	mm/debug_page_ref.c
--

2.53.0