dts: fix port info getter when port is not found
PATCH v2 1/1 dts: fix port info getter when port is not found
In DTS, when providing an nonexisting PCI address, a ConfigurationError should be thrown. Instead, because the next() is not given a default None, it instead hits a StopIteration error, which is harder to debug.
Fixes 0a210d88c36 ("dts: improve port model")
Signed-off-by Riley Fletcher <[email protected]>
--- dts/framework/testbed_model/linux_session.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
dts/framework/testbed_model/linux_session.py +1 -1
@@ -168,7 +168,7 @@ def get_port_info(self, pci_address: str) -> PortInfo: ConfigurationError: If the port could not be found. """ bus_info = f"pci@{pci_address}" - port = next(port for port in self._lshw_net_info if port.get("businfo") == bus_info) + port = next((port for port in self._lshw_net_info if port.get("businfo") == bus_info), None) if port is None: raise ConfigurationError(f"Port {pci_address} could not be found on the node.")
Signature · 1 line
2.53.0
Reviewed-by Luca Vizzarro <[email protected]>
Patrick Robb
AppliedMerged to dpdk-next-dts, thanks.