media: dvb-usb-v2: ce6230: fix syzkaller bug
Subsystems (2)
cover media: dvb-usb-v2: ce6230: fix syzkaller bug
This patch fixes a syzkaller bug which was reported in the usb core after sending a urb_control_msg. The main problem that caused this was the ce6230_ctrl_msg function trying to send a read control message of size 0, which then caused the system to panic after. The solution was to add a check in this function to check if the message has a greater than zero size before sending it, otherwise we log the error and return.
Jakov Novak (1):
media: dvb-usb-v2: ce6230: fix bug when sending usb_control_msg of
size 0
drivers/media/usb/dvb-usb-v2/ce6230.c | 7 +++++++ 1 file changed, 7 insertions(+)
Signature · 1 line
2.53.0
PATCH 1/1 media: dvb-usb-v2: ce6230: fix bug when sending usb_control_msg of size 0
The function ce6230_ctrl_msg, didn't check the size of the message that was supposed to be read/written, which in turn caused the error at the usb core function usb_submit_urb after calling usb_control_msg in the driver code. This patch fixes the issue by returning an error code if the req->data_len == 0.
--- drivers/media/usb/dvb-usb-v2/ce6230.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/media/usb/dvb-usb-v2/ce6230.c +7 -0
@@ -23,6 +23,13 @@ static int ce6230_ctrl_msg(struct dvb_usb_device *d, struct usb_req *req) value = req->value; index = req->index; +if (!req->data_len) { +dev_err (&d->udev->dev, +"%s: cannot send crtl_msg of size 0" , +KBUILD_MODNAME ); +return -ENOBUFS ; + } +switch (req->cmd) {case I2C_READ :case DEMOD_READ :
Signature · 1 line
2.53.0