Skip to contentSkip to conversation

cve: icmp_rate_limit: set icmp_msgs_burst within network namespace

PATCH Applied Wei Gao via ltp 4 participants 6 messages Apr 23 – Apr 29

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cve: icmp_rate_limit: set icmp_msgs_burst within network namespace

When network namespaces are used, the kernel resets network sysctls to their default values. This makes the global .save_restore for icmp_msgs_burst ineffective for tests that enter a new network namespace (e.g. via tst_setup_netns() or manual unshare).

Moving the sysctl configuration into the child namespace ensures the test always runs with the expected burst value of 50, regardless of the kernel defaults (which were increased to 10000 in newer versions).

Fixes 8e919bfb2ab0 ("cve: icmp_rate_limit: Make sure icmp_msgs_burst = 50")
---
 testcases/cve/icmp_rate_limit01.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
testcases/cve/icmp_rate_limit01.c +2 -1
index 78480cea6..5193c5dfd 100644
@@ -62,6 +62,8 @@ static void setup(void)
 	/* Do NOT close this FD, or both interfaces will be destroyed */
 	childns = SAFE_OPEN("/proc/self/ns/net", O_RDONLY);
 
+	SAFE_FILE_PRINTF("/proc/sys/net/ipv4/icmp_msgs_burst", "50");
+
 	/* Configure child namespace */
 	CREATE_VETH_PAIR("ltp_veth1", "ltp_veth2");
 	NETDEV_ADD_ADDRESS_INET("ltp_veth2", htonl(DSTADDR), NETMASK,
@@ -255,7 +257,6 @@ static struct tst_test test = {
 	},
 	.save_restore = (const struct tst_path_val[]) {
 		{"/proc/sys/user/max_user_namespaces", "1024", TST_SR_SKIP},
-		{"/proc/sys/net/ipv4/icmp_msgs_burst", "50", TST_SR_TBROK},
 		{}
 	},
 	.tags = (const struct tst_tag[]) {
Signature · 5 lines
2.52.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
Reviewed-by LTP AI Reviewer on v1 1/1
#1 lore raw

Hi Wei,

testcases/cve/icmp_rate_limit01.c static void setup(void) · line 65

Quoted 5 lines · Wei Gao

cve: icmp_rate_limit: set icmp_msgs_burst within network namespace

testcases/cve/icmp_rate_limit01.c +1 -0
 	childns = SAFE_OPEN("/proc/self/ns/net", O_RDONLY);
 
+	SAFE_FILE_PRINTF("/proc/sys/net/ipv4/icmp_msgs_burst", "50");

Correct fix. The save_restore entry was writing to the initial namespace before CLONE_NEWNET, making it ineffective inside the child namespace where the test actually runs.

testcases/cve/icmp_rate_limit01.c static struct tst_test test = { · line 258

Quoted 1 line
testcases/cve/icmp_rate_limit01.c +0 -1
-		{"/proc/sys/net/ipv4/icmp_msgs_burst", "50", TST_SR_TBROK},

No explicit restore needed — the sysctl lives in the child namespace, which is destroyed when the test exits.

---
Note:

Our agent completed the review of the patch.

The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#4 lore raw
Quoted 8 lines · Cyril Hrubis

Hi!

Quoted 3 lines

Ping @Cyril

It took me while to realize that it's the child namespace that generates the errors and I also checked that the ratelimiting in kernel is per net namespace. Anyways:

Hi,
icmp_msgs_burst sysfile was added into non-root namespaces only in kernel v6.12. The test now fails in setup() on any older kernel. I'll send a patch to override the global value first and then conditionally override namespace as well.

Signature · 10 lines
Martin Doucha   [email protected]
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp