ns-tools: Restore ns-icmpv4_sender
PATCH 1/1 ns-tools: Restore ns-icmpv4_sender
Commit 19c9b694c6b ("ns-tools: Remove unused tools") removed ns-icmpv4_sender.c, assuming it was unused. However, it is still required by broken_ip tests (e.g. broken_ip4-version, broken_ip4-ihl), which were not removed.
Restore ns-icmpv4_sender.c and update Makefile, .gitignore and 00_Descriptions.txt accordingly.
--- testcases/network/.gitignore | 1 + .../stress/ns-tools/00_Descriptions.txt | 4 + testcases/network/stress/ns-tools/Makefile | 2 +- .../stress/ns-tools/ns-icmpv4_sender.c | 622 ++++++++++++++++++ 4 files changed, 628 insertions(+), 1 deletion(-) create mode 100644 testcases/network/stress/ns-tools/ns-icmpv4_sender.c
testcases/network/.gitignore +1 -0
@@ -26,6 +26,7 @@ /sockets/ltpServer /sockets/vsock01 /stress/ns-tools/ns-icmp_redirector +/stress/ns-tools/ns-icmpv4_sender /stress/ns-tools/ns-icmpv6_sender /stress/ns-tools/ns-igmp_querier /stress/ns-tools/ns-mcast_join
testcases/network/stress/ns-tools/00_Descriptions.txt +4 -0
@@ -10,6 +10,10 @@ ns-icmp_redirector (binary) gateway. When the utility receives the packet from the host under test. This utility reply ICMP redirect message. +ns-icmpv4_sender (binary) + ICMPv4 echo request sender. + This utility is also able to set illegal information in the IP header + ns-icmpv6_sender (binary) ICMPv6 message (Echo request / MLDv2 query) sender. This utility is also able to set illegal information in the IP header
testcases/network/stress/ns-tools/Makefile +1 -1
@@ -6,7 +6,7 @@ top_srcdir ?= ../../../.. include $(top_srcdir)/include/mk/env_pre.mk -INSTALL_TARGETS := create_file tst_net_stress.sh +INSTALL_TARGETS := create_file tst_net_stress.sh ns-icmpv4_sender FILTER_OUT_MAKE_TARGETS := ns-common
testcases/network/stress/ns-tools/ns-icmpv4_sender.c new file +622 -0
622 lines not on this page · raw message
Signature · 5 lines
2.52.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Wei,
Quoted 9 lines
Commit
19c9b694c6b("ns-tools: Remove unused tools") removedns-icmpv4_sender.c, assuming it was unused. However, it is still required bybroken_iptests (e.g. broken_ip4-version, broken_ip4-ihl), which were not removed.Restore
ns-icmpv4_sender.cand updateMakefile, .gitignore and 00_Descriptions.txt accordingly.Fixes 19c9b694c6b ("ns-tools: Remove unused tools")
Good catch, thanks! Merged.
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp