Skip to contentSkip to conversation

sh: cache: remove unused but set variables in sh4_flush_cache_range

PATCH New Thorsten Blum 1 participant 2 messages Apr 23 SuperH

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 sh: cache: remove unused but set variables in sh4_flush_cache_range

Remove 'start' and 'end' to avoid two "variable set but not used" warnings triggered by -Wunused-but-set-variable. Update the function comment accordingly.

---
Changes in v2:
- Update the comment as suggested by Zi Yan (thanks!)
- v1: https://lore.kernel.org/lkml/[email protected]/

---
 arch/sh/mm/cache-sh4.c | 5 -----
 1 file changed, 5 deletions(-)
arch/sh/mm/cache-sh4.c +0 -5
index 83fb34b39ca7..c7635beb4f1f 100644
@@ -274,8 +274,6 @@ static void sh4_flush_cache_page(void *args)
 /*
  * Write back and invalidate D-caches.
  *
- * START, END: Virtual Address (U0 address)
- *
  * NOTE: We need to flush the _physical_ page entry.
  * Flushing the cache lines for U0 only isn't enough.
  * We need to flush for P1 too, which may contain aliases.
@@ -284,11 +282,8 @@ static void sh4_flush_cache_range(void *args)
 {
 	struct flusher_data *data = args;
 	struct vm_area_struct *vma;
-	unsigned long start, end;
 
 	vma = data->vma;
-	start = data->addr1;
-	end = data->addr2;
 
 	if (cpu_context(smp_processor_id(), vma->vm_mm) == NO_CONTEXT)
 		return;
#1 lore raw

PATCH v2 2/2 gdrom: remove unused but set variable in gdrom_get_last_session

Remove 'lentry' to avoid a "variable set but not used" warning triggered by -Wunused-but-set-variable.

---
No changes in patch 2/2.

---
 drivers/cdrom/gdrom.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/cdrom/gdrom.c +1 -2
index 4ba4dd06cbf4..5cc830501fdf 100644
@@ -312,7 +312,7 @@ static int get_entry_track(int track)
 static int gdrom_get_last_session(struct cdrom_device_info *cd_info,
 	struct cdrom_multisession *ms_info)
 {
-	int fentry, lentry, track, data, err;
+	int fentry, track, data, err;
 
 	if (!gd.toc)
 		return -ENOMEM;
@@ -329,7 +329,6 @@ static int gdrom_get_last_session(struct cdrom_device_info *cd_info,
 	}
 
 	fentry = get_entry_track(gd.toc->first);
-	lentry = get_entry_track(gd.toc->last);
 	/* Find the first data track */
 	track = get_entry_track(gd.toc->last);
 	do {