mshv: add a missing padding field
Subsystems (2)
[email protected]
maintainerPATCH 1/1 mshv: add a missing padding field
From: Wei Liu <[email protected]>
That was missed when importing the header.
--- include/hyperv/hvhdk.h | 1 + 1 file changed, 1 insertion(+)
include/hyperv/hvhdk.h +1 -0
@@ -79,6 +79,7 @@ struct hv_vp_register_page {u64 registers[18 ]; }; +__u8 reserved[8 ];/* Volatile XMM registers (HV_X64_REGISTER_CLASS_XMM) */ union { struct {
Signature · 1 line
2.43.0
Quoted 18 lines · On 4/23/2026 10:26 AM, [email protected] wrote:
From: Wei Liu <[email protected]>
That was missed when importing the header.
Reported-by Doru Blânzeanu <[email protected]>Reported-by Magnus Kulke <[email protected]>Fixes e68bda71a2384 ("hyperv: Add new Hyper-V headers in include/hyperv")Signed-off-by Wei Liu <[email protected]>--- include/hyperv/hvhdk.h | 1 + 1 file changed, 1 insertion(+)include/hyperv/hvhdk.h +0
-0
include/hyperv/hvhdk.h struct hv_vp_register_page { · line 85
Quoted 7 lines
include/hyperv/hvhdk.h +1
-0@@ -79,6 +79,7 @@ struct hv_vp_register_page {u64 registers[18 ]; }; +__u8 reserved[8 ];/* Volatile XMM registers (HV_X64_REGISTER_CLASS_XMM) */ union { struct {
This is not a uapi, so why not just use u8 instead of __u8? Or since it's 8 u8s, a u64?
Thanks,
Easwar (he/him)
Quoted 31 lines · Easwar Hariharan
Quoted 18 lines · On 4/23/2026 10:26 AM, [email protected] wrote:
From: Wei Liu <[email protected]>
That was missed when importing the header.
Reported-by Doru Blânzeanu <[email protected]>Reported-by Magnus Kulke <[email protected]>Fixes e68bda71a2384 ("hyperv: Add new Hyper-V headers in include/hyperv")Signed-off-by Wei Liu <[email protected]>--- include/hyperv/hvhdk.h | 1 + 1 file changed, 1 insertion(+)include/hyperv/hvhdk.h +0
-0include/hyperv/hvhdk.h struct hv_vp_register_page { · line 85
Quoted 7 lines
include/hyperv/hvhdk.h +1
-0@@ -79,6 +79,7 @@ struct hv_vp_register_page {u64 registers[18 ]; }; +__u8 reserved[8 ];/* Volatile XMM registers (HV_X64_REGISTER_CLASS_XMM) */ union { struct {This is not a uapi, so why not just use u8 instead of
__u8? Or since it's 8 u8s, a u64?
Quoted 2 lines
Thanks,
Easwar (he/him)
Hm, occurs to me that this would be used by VMMs, but then the registers field just above used a u64 instead of a __u64....
Wei Liu
maintainerQuoted 32 lines · Easwar Hariharan
Quoted 31 lines · Easwar Hariharan
Quoted 18 lines · On 4/23/2026 10:26 AM, [email protected] wrote:
From: Wei Liu <[email protected]>
That was missed when importing the header.
Reported-by Doru Blânzeanu <[email protected]>Reported-by Magnus Kulke <[email protected]>Fixes e68bda71a2384 ("hyperv: Add new Hyper-V headers in include/hyperv")Signed-off-by Wei Liu <[email protected]>--- include/hyperv/hvhdk.h | 1 + 1 file changed, 1 insertion(+)include/hyperv/hvhdk.h +0
-0include/hyperv/hvhdk.h struct hv_vp_register_page { · line 85
Quoted 7 lines
include/hyperv/hvhdk.h +1
-0@@ -79,6 +79,7 @@ struct hv_vp_register_page {u64 registers[18 ]; }; +__u8 reserved[8 ];/* Volatile XMM registers (HV_X64_REGISTER_CLASS_XMM) */ union { struct {This is not a uapi, so why not just use u8 instead of
__u8? Or since it's 8 u8s, a u64?
Quoted 5 lines
Quoted 2 lines
Thanks,
Easwar (he/him)Hm, occurs to me that this would be used by VMMs, but then the registers field just above used a u64 instead of a
__u64....
I fat-fingered u8 to __u8. User space code has scripts to massage the types as needed.
To remain consistent with the existing code, it should be u8.
I can change the type when I commit this.
Wei
Quoted 2 lines
Easwar Hariharan
Reviewed-byQuoted 39 lines · Wei Liu
Quoted 32 lines · Easwar Hariharan
Quoted 31 lines · Easwar Hariharan
Quoted 18 lines · On 4/23/2026 10:26 AM, [email protected] wrote:
From: Wei Liu <[email protected]>
That was missed when importing the header.
Reported-by Doru Blânzeanu <[email protected]>Reported-by Magnus Kulke <[email protected]>Fixes e68bda71a2384 ("hyperv: Add new Hyper-V headers in include/hyperv")Signed-off-by Wei Liu <[email protected]>--- include/hyperv/hvhdk.h | 1 + 1 file changed, 1 insertion(+)include/hyperv/hvhdk.h +0
-0include/hyperv/hvhdk.h struct hv_vp_register_page { · line 85
Quoted 7 lines
include/hyperv/hvhdk.h +1
-0@@ -79,6 +79,7 @@ struct hv_vp_register_page {u64 registers[18 ]; }; +__u8 reserved[8 ];/* Volatile XMM registers (HV_X64_REGISTER_CLASS_XMM) */ union { struct {This is not a uapi, so why not just use u8 instead of
__u8? Or since it's 8 u8s, a u64?Quoted 5 lines
Quoted 2 lines
Thanks,
Easwar (he/him)Hm, occurs to me that this would be used by VMMs, but then the registers field just above used a u64 instead of a
__u64....
Quoted 8 lines
I fat-fingered u8 to
__u8. User space code has scripts to massage the types as needed.To remain consistent with the existing code, it should be u8.
I can change the type when I commit this.
Wei
Thanks, with that fixed: