Skip to contentSkip to conversation

gpio: ep93xx: use handle_bad_irq() as default IRQ handler

PATCH Applied Mohamed Ayman 3 participants 3 messages Apr 24 – Apr 27 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio: ep93xx: use handle_bad_irq() as default IRQ handler

Replace the temporary fallback handle_simple_irq with handle_bad_irq now that the driver operates with a proper hierarchical IRQ setup. This ensures unexpected or unmapped interrupts are clearly flagged instead of being silently handled.

---
 drivers/gpio/gpio-ep93xx.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpio/gpio-ep93xx.c +1 -2
index 1f56e44ffc9a..8784e433e1ff 100644
@@ -323,8 +323,7 @@ static int ep93xx_setup_irqs(struct platform_device *pdev,
 	}
 
 	girq->default_type = IRQ_TYPE_NONE;
-	/* TODO: replace with handle_bad_irq() once we are fully hierarchical */
-	girq->handler = handle_simple_irq;
+	girq->handler = handle_bad_irq;
 
 	return 0;
 }
Signature · 1 line
2.34.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Mohamed Ayman

Replace the temporary fallback handle_simple_irq with handle_bad_irq now that the driver operates with a proper hierarchical IRQ setup. This ensures unexpected or unmapped interrupts are clearly flagged instead of being silently handled.

Yours,
Linus Walleij

#2 lore raw
In reply to Mohamed Ayman
Quoted 6 lines · Mohamed Ayman

Replace the temporary fallback handle_simple_irq with handle_bad_irq now that the driver operates with a proper hierarchical IRQ setup. This ensures unexpected or unmapped interrupts are clearly flagged instead of being silently handled.

Applied, thanks!

[1/1] gpio: ep93xx: use handle_bad_irq() as default IRQ handler

      https://git.kernel.org/brgl/c/42509588db15100732f236b6a007f384dde3833f

Best regards,

Signature · 1 line
Bartosz Golaszewski <[email protected]>