Skip to contentSkip to conversation

drm/amdgpu: Remove dead init_mcm_addr_lut call in soc_v1_0

PATCH In review [email protected] 3 participants 3 messages Apr 24

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: Remove dead init_mcm_addr_lut call in soc_v1_0

From: Ivan Lipski <[email protected]>

[Why&How]
init_mcm_addr_lut() definition was reverted from amdgpu_imu_funcs , so this function call causes build failure.

Thus, remove it.

Fixes 21bd78c821c9 ("Revert "drm/amdgpu: Init mcm_addr look up table"")
---
 drivers/gpu/drm/amd/amdgpu/soc_v1_0.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/soc_v1_0.c +0 -4
index d06953c237ed..f09d21738400 100644
@@ -744,10 +744,6 @@ static int soc_v1_0_switch_partition_mode(struct amdgpu_xcp_mgr *xcp_mgr,
 		if (ret)
 			goto out;
 	}
-	if (adev->gfx.imu.funcs &&
-	    adev->gfx.imu.funcs->init_mcm_addr_lut &&
-	    amdgpu_emu_mode)
-		adev->gfx.imu.funcs->init_mcm_addr_lut(adev);
 
 	/* Init info about new xcps */
 	*num_xcps = num_xcc / num_xcc_per_xcp;
Signature · 1 line
2.43.0
#1 lore raw

[AMD Official Use Only - AMD Internal Distribution Only]

This is already proposed https://patchwork.freedesktop.org/patch/720475/

Quoted 44 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of [email protected]
Sent: Friday, April 24, 2026 7:38 PM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>; Zhang, Morris <[email protected]>; Zhang, Hawking <[email protected]>; Mario Limonciello <[email protected]>; LIPSKI, IVAN <[email protected]>
Subject: [PATCH] drm/amdgpu: Remove dead init_mcm_addr_lut call in soc_v1_0

From: Ivan Lipski <[email protected]>

[Why&How]
init_mcm_addr_lut() definition was reverted from amdgpu_imu_funcs , so this function call causes build failure.

Thus, remove it.

Fixes 21bd78c821c9 ("Revert "drm/amdgpu: Init mcm_addr look up table"")
---
 drivers/gpu/drm/amd/amdgpu/soc_v1_0.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/soc_v1_0.c +0 -4
index d06953c237ed..f09d21738400 100644
@@ -744,10 +744,6 @@ static int soc_v1_0_switch_partition_mode(struct
 amdgpu_xcp_mgr *xcp_mgr,
              if (ret)
                      goto out;
      }
-     if (adev->gfx.imu.funcs &&
-         adev->gfx.imu.funcs->init_mcm_addr_lut &&
-         amdgpu_emu_mode)
-             adev->gfx.imu.funcs->init_mcm_addr_lut(adev);
 
      /* Init info about new xcps */
      *num_xcps = num_xcc / num_xcc_per_xcp;

--
2.43.0

#2 lore raw
In reply to [email protected]

This is already fixed. Sorry for the noise.

Alex

Quoted 34 lines · On Fri, Apr 24, 2026 at 10:34 AM <[email protected]> wrote:

From: Ivan Lipski <[email protected]>

[Why&How]
init_mcm_addr_lut() definition was reverted from amdgpu_imu_funcs , so this function call causes build failure.

Thus, remove it.

Fixes 21bd78c821c9 ("Revert "drm/amdgpu: Init mcm_addr look up table"")
---
 drivers/gpu/drm/amd/amdgpu/soc_v1_0.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/soc_v1_0.c +0 -5
index d06953c237ed..f09d21738400 100644
@@ -744,10 +744,6 @@ static int soc_v1_0_switch_partition_mode(struct amdgpu_xcp_mgr *xcp_mgr,
                if (ret)
                        goto out;
        }
-       if (adev->gfx.imu.funcs &&
-           adev->gfx.imu.funcs->init_mcm_addr_lut &&
-           amdgpu_emu_mode)
-               adev->gfx.imu.funcs->init_mcm_addr_lut(adev);
 
        /* Init info about new xcps */
        *num_xcps = num_xcc / num_xcc_per_xcp;
--

2.43.0