gpio: sim: Replace sprintf() with sysfs_emit()
PATCH 1/1 gpio: sim: Replace sprintf() with sysfs_emit()
Replace sprintf() function calls with sysfs_emit() in the configfs show callbacks. This will help harden the driver and will bring the driver up-to-date with more modern functions.
Suggested-by Bartosz Golaszewski <[email protected]>
Signed-off-by Maxwell Doose <[email protected]>
--- drivers/gpio/gpio-sim.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)
drivers/gpio/gpio-sim.c +11 -11
@@ -697,9 +697,9 @@ static ssize_t gpio_sim_device_config_dev_name_show(struct config_item *item, pdev = dev->probe_data.pdev;if (pdev) -return sprintf (page,"%s\n" ,dev_name (&pdev->dev)); +return sysfs_emit (page,"%s\n" ,dev_name (&pdev->dev)); -return sprintf (page,"gpio-sim.%d\n" , dev->id); +return sysfs_emit (page,"gpio-sim.%d\n" , dev->id); }CONFIGFS_ATTR_RO (gpio_sim_device_config_, dev_name);
@@ -713,7 +713,7 @@ gpio_sim_device_config_live_show(struct config_item *item, char *page)scoped_guard (mutex, &dev->lock) live = gpio_sim_device_is_live(dev); -return sprintf (page,"%c\n" , live ?'1' :'0' ); +return sysfs_emit (page,"%c\n" , live ?'1' :'0' ); }static unsigned int gpio_sim_get_line_names_size (struct gpio_sim_bank *bank)
@@ -1094,7 +1094,7 @@ static int gpio_sim_emit_chip_name(struct device *dev, void *data)return 0 ;if (device_match_fwnode (dev, ctx->swnode)) -return sprintf (ctx->page,"%s\n" ,dev_name (dev)); +return sysfs_emit (ctx->page,"%s\n" ,dev_name (dev));return 0 ; }
@@ -1112,7 +1112,7 @@ static ssize_t gpio_sim_bank_config_chip_name_show(struct config_item *item,return device_for_each_child (&dev->probe_data.pdev->dev, &ctx, gpio_sim_emit_chip_name); -return sprintf (page,"none\n" ); +return sysfs_emit (page,"none\n" ); }CONFIGFS_ATTR_RO (gpio_sim_bank_config_, chip_name);
@@ -1125,7 +1125,7 @@ gpio_sim_bank_config_label_show(struct config_item *item, char *page)guard (mutex)(&dev->lock); -return sprintf (page,"%s\n" , bank->label ?:"" ); +return sysfs_emit (page,"%s\n" , bank->label ?:"" ); } static ssize_t gpio_sim_bank_config_label_store(struct config_item *item,
@@ -1160,7 +1160,7 @@ gpio_sim_bank_config_num_lines_show(struct config_item *item, char *page)guard (mutex)(&dev->lock); -return sprintf (page,"%u\n" , bank->num_lines); +return sysfs_emit (page,"%u\n" , bank->num_lines); } static ssize_t
@@ -1206,7 +1206,7 @@ gpio_sim_line_config_name_show(struct config_item *item, char *page)guard (mutex)(&dev->lock); -return sprintf (page,"%s\n" , line->name ?:"" ); +return sysfs_emit (page,"%s\n" , line->name ?:"" ); } static ssize_t gpio_sim_line_config_name_store(struct config_item *item,
@@ -1241,7 +1241,7 @@ gpio_sim_line_config_valid_show(struct config_item *item, char *page)guard (mutex)(&dev->lock); -return sprintf (page,"%c\n" , line->valid ?'1' :'0' ); +return sysfs_emit (page,"%c\n" , line->valid ?'1' :'0' ); } static ssize_t gpio_sim_line_config_valid_store(struct config_item *item,
@@ -1279,7 +1279,7 @@ static ssize_t gpio_sim_hog_config_name_show(struct config_item *item,guard (mutex)(&dev->lock); -return sprintf (page,"%s\n" , hog->name ?:"" ); +return sysfs_emit (page,"%s\n" , hog->name ?:"" ); } static ssize_t gpio_sim_hog_config_name_store(struct config_item *item,
@@ -1333,7 +1333,7 @@ static ssize_t gpio_sim_hog_config_direction_show(struct config_item *item,return -EINVAL ; } -return sprintf (page,"%s\n" , repr); +return sysfs_emit (page,"%s\n" , repr); } static ssize_t
Signature · 1 line
2.53.0
Bartosz Golaszewski
maintainerQuoted 11 lines · Maxwell Doose
Replace
sprintf()function calls withsysfs_emit()in the configfs show callbacks. This will help harden the driver and will bring the driver up-to-date with more modern functions.Suggested-by Bartosz Golaszewski <[email protected]>Signed-off-by Maxwell Doose <[email protected]>--- drivers/gpio/gpio-sim.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)
Hi! This no longer applies on top of v7.1-rc1. Please rebase and resend.
Bartosz