Skip to contentSkip to conversation

rust: module_param: use `pr_warn_once!` for null pointer warning

PATCH Applied Andreas Hindborg 6 participants 9 messages Apr 27 – May 26

Subsystems (2)
lore
Share & tools
lore

Andreas Hindborg

author reviewer
#0 lore raw

PATCH 1/1 rust: module_param: use `pr_warn_once!` for null pointer warning

Replace pr_warn! and the accompanying TODO with pr_warn_once!, now that the macro is available.

---
 rust/kernel/module_param.rs | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
rust/kernel/module_param.rs +1 -2
index 6a8a7a875643..dd6d663a0a3c 100644
@@ -62,8 +62,7 @@ pub trait ModuleParam: Sized + Copy {
     // NOTE: If we start supporting arguments without values, val _is_ allowed
     // to be null here.
     if val.is_null() {
-        // TODO: Use pr_warn_once available.
-        crate::pr_warn!("Null pointer passed to `module_param::set_param`");
+        crate::pr_warn_once!("Null pointer passed to `module_param::set_param`");
         return EINVAL.to_errno();
     }
 

---
base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731
change-id: 20260427-params-pr-once-481c03df3e2a

Best regards,

Signature · 1 line
Andreas Hindborg <[email protected]>
reviewer Reviewed-by on v1 1/1
#3 lore raw
In reply to Andreas Hindborg
Quoted 27 lines · Andreas Hindborg

Replace pr_warn! and the accompanying TODO with pr_warn_once!, now that the macro is available.

---
 rust/kernel/module_param.rs | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
rust/kernel/module_param.rs +1 -3
index 6a8a7a875643..dd6d663a0a3c 100644
@@ -62,8 +62,7 @@ pub trait ModuleParam: Sized + Copy {
     // NOTE: If we start supporting arguments without values, val _is_ allowed
     // to be null here.
     if val.is_null() {
-        // TODO: Use pr_warn_once available.
-        crate::pr_warn!("Null pointer passed to `module_param::set_param`");
+        crate::pr_warn_once!("Null pointer passed to `module_param::set_param`");
         return EINVAL.to_errno();
     }
 
 
---

base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731
change-id: 20260427-params-pr-once-481c03df3e2a

Quoted 3 lines

Best regards,

Signature · 1 line
Andreas Hindborg <[email protected]>

LGTM.

The rust macro was available since v6.19-rc6-60-g46c40f938f5f.

Signature · 1 line
Aaron Tomlin
#4 lore raw
In reply to Andreas Hindborg
Quoted 5 lines · Andreas Hindborg

Replace pr_warn! and the accompanying TODO with pr_warn_once!, now that the macro is available.

This seems to be:

https://lore.kernel.org/rust-for-linux/[email protected]/

Another one was also sent a few moments ago:

https://lore.kernel.org/rust-for-linux/[email protected]/

Is modules going to pick the original one? Otherwise, I am happy to do so.

I guess we can assume the reviews here to apply there.

Thanks!

Cheers,
Miguel

maintainer
#5 lore raw

Hi Miguel,

Quoted 10 lines · Miguel Ojeda
Quoted 5 lines · Andreas Hindborg

Replace pr_warn! and the accompanying TODO with pr_warn_once!, now that the macro is available.

This seems to be:

Quoted 7 lines

https://lore.kernel.org/rust-for-linux/[email protected]/

Another one was also sent a few moments ago:

https://lore.kernel.org/rust-for-linux/[email protected]/

Is modules going to pick the original one? Otherwise, I am happy to do so.

Yes, this is on my list for v7.2.

Sami

maintainer Applied
#6 lore raw
In reply to Andreas Hindborg
Quoted 4 lines · Andreas Hindborg

Replace pr_warn! and the accompanying TODO with pr_warn_once!, now that the macro is available.

Applied to modules-next, thanks!

[1/1] rust: module_param: use pr_warn_once! for null pointer warning

      commit: 8d2a562b7efe98fdea57d10caaced911fca46a3f

Best regards,

Sami

#7 lore raw
Quoted 5 lines · Sami Tolvanen

Applied to modules-next, thanks!

[1/1] rust: module_param: use pr_warn_once! for null pointer warning

      commit: 8d2a562b7efe98fdea57d10caaced911fca46a3f

Even if we pick this one, should we credit Adarsh Das?

https://lore.kernel.org/rust-for-linux/[email protected]/

Or did Andreas send it earlier than that?

Cheers,
Miguel

maintainer
#8 lore raw
Quoted 5 lines · Miguel Ojeda
Quoted 3 lines · Sami Tolvanen

Applied to modules-next, thanks!

Quoted 8 lines
Quoted 2 lines

[1/1] rust: module_param: use pr_warn_once! for null pointer warning

      commit: 8d2a562b7efe98fdea57d10caaced911fca46a3f

Even if we pick this one, should we credit Adarsh Das?

https://lore.kernel.org/rust-for-linux/[email protected]/

Or did Andreas send it earlier than that?

Ah, that series was never sent to linux-modules, so it wasn't on my list. I agree that Adarsh seems to have sent the same patch first though. Happy to credit him unless someone objects.

Sami