clk: davinci: add Kconfig symbol
Subsystems (2)
PATCH 1/1 clk: davinci: add Kconfig symbol
Add COMPILE_TEST support as a result so that the buildbots can run through this driver. There's nothing architecture specific about it.
--- drivers/clk/Kconfig | 7 +++++++ drivers/clk/Makefile | 2 +- drivers/clk/davinci/Makefile | 6 +++--- 3 files changed, 11 insertions(+), 4 deletions(-)
drivers/clk/Kconfig +7 -0
@@ -317,6 +317,13 @@ config COMMON_CLK_AXI_CLKGEN Support for the Analog Devices axi-clkgen pcore clock generator for Xilinx FPGAs. It is commonly used in Analog Devices' reference designs. +config CLK_DA850 + bool "DaVinci DA850 CLK support" + depends on ARCH_DAVINCI_DA850 || COMPILE_TEST + help + This adds the clock driver support for DaVinci DA850 platform + using common clock framework. + config CLK_QORIQ bool "Clock driver for Freescale QorIQ platforms" depends on OF
drivers/clk/Makefile +1 -1
@@ -118,7 +118,7 @@ obj-$(CONFIG_ARCH_ARTPEC) += axis/ obj-$(CONFIG_ARC_PLAT_AXS10X) += axs10x/ obj-y += bcm/ obj-$(CONFIG_ARCH_BERLIN) += berlin/ -obj-$(CONFIG_ARCH_DAVINCI) += davinci/ +obj-$(CONFIG_CLK_DAVINCI) += davinci/ obj-$(CONFIG_COMMON_CLK_ESWIN) += eswin/ obj-$(CONFIG_ARCH_HISI) += hisilicon/ obj-y += imgtec/
drivers/clk/davinci/Makefile +3 -3
@@ -1,11 +1,11 @@ # SPDX-License-Identifier: GPL-2.0 ifeq ($(CONFIG_COMMON_CLK), y) -obj-$(CONFIG_ARCH_DAVINCI_DA8XX) += da8xx-cfgchip.o +obj-$(CONFIG_CLK_DA850) += da8xx-cfgchip.o obj-y += pll.o -obj-$(CONFIG_ARCH_DAVINCI_DA850) += pll-da850.o +obj-$(CONFIG_CLK_DA850) += pll-da850.o obj-y += psc.o -obj-$(CONFIG_ARCH_DAVINCI_DA850) += psc-da850.o +obj-$(CONFIG_CLK_DA850) += psc-da850.o endif
Signature · 1 line
2.54.0
David Lechner
maintainerQuoted 15 lines · Rosen Penev
Add
COMPILE_TESTsupport as a result so that the buildbots can run through this driver. There's nothing architecture specific about it.Signed-off-by Rosen Penev <[email protected]>--- drivers/clk/Kconfig | 7 +++++++ drivers/clk/Makefile | 2 +- drivers/clk/davinci/Makefile | 6 +++--- 3 files changed, 11 insertions(+), 4 deletions(-)drivers/clk/Kconfig +0
-0
drivers/clk/Kconfig config COMMON_CLK_AXI_CLKGEN · line 321
Quoted 5 lines
drivers/clk/Kconfig +2
-0@@ -317,6 +317,13 @@ config COMMON_CLK_AXI_CLKGEN Support for the Analog Devices axi-clkgen pcore clock generator for Xilinx FPGAs. It is commonly used in Analog Devices' reference designs. +config CLK_DA850 + bool "DaVinci DA850 CLK support"
Should this be default y so that it gets enabled? Or have config ARCH_DAVINCI_DA850 select CLK_DA850?
Otherwise, we would need to modify the defconfigs as well to enable it.
drivers/clk/Kconfig config COMMON_CLK_AXI_CLKGEN · line 322
Quoted 1 line
drivers/clk/Kconfig +1
-0+ depends on ARCH_DAVINCI_DA850 || COMPILE_TEST
We should also make this depend on COMMON_CLK. (see related comment below.)
Quoted 12 lines
drivers/clk/Kconfig +4
-0+ help + This adds the clock driver support for DaVinci DA850 platform + using common clock framework. + config CLK_QORIQ bool "Clock driver for Freescale QorIQ platforms" depends on OFdrivers/clk/Makefile +0
-0
drivers/clk/Makefile obj-$(CONFIG_ARCH_ARTPEC) += axis/ · line 121
Quoted 5 lines
drivers/clk/Makefile +1
-1@@ -118,7 +118,7 @@ obj-$(CONFIG_ARCH_ARTPEC) += axis/ obj-$(CONFIG_ARC_PLAT_AXS10X) += axs10x/ obj-y += bcm/ obj-$(CONFIG_ARCH_BERLIN) += berlin/ -obj-$(CONFIG_ARCH_DAVINCI) += davinci/ +obj-$(CONFIG_CLK_DAVINCI) += davinci/
Did you mean CONFIG_CLK_DA850? I don't think CONFIG_CLK_DAVINCI exists.
drivers/clk/davinci/Makefile line 3
Quoted 11 lines
drivers/clk/Makefile +0
-0obj-$(CONFIG_COMMON_CLK_ESWIN) += eswin/ obj-$(CONFIG_ARCH_HISI) += hisilicon/ obj-y += imgtec/drivers/clk/davinci/Makefile +0
-0@@ -1,11 +1,11 @@ # SPDX-License-Identifier: GPL-2.0 ifeq ($(CONFIG_COMMON_CLK), y)
Then we can drop this if statement.
drivers/clk/davinci/Makefile line 6
Quoted 4 lines
drivers/clk/davinci/Makefile +1
-1-obj-$(CONFIG_ARCH_DAVINCI_DA8XX) += da8xx-cfgchip.o +obj-$(CONFIG_CLK_DA850) += da8xx-cfgchip.o obj-y += pll.o
Since there is only one platform left supported, it would probably make more sense to make everything (including pll.o and psc.o) obj-$(CONFIG_CLK_DA850) or perhaps even better, make everything (including da8xx-cfgchip.o, pll-da850.o and psc-da850.o) obj-y since the containing directory already has the conditional (and include a comment to this effect).
Quoted 7 lines
drivers/clk/davinci/Makefile +2
-2-obj-$(CONFIG_ARCH_DAVINCI_DA850) += pll-da850.o +obj-$(CONFIG_CLK_DA850) += pll-da850.o obj-y += psc.o -obj-$(CONFIG_ARCH_DAVINCI_DA850) += psc-da850.o +obj-$(CONFIG_CLK_DA850) += psc-da850.o endif
Hi Rosen,
Quoted 4 lines · Rosen Penev
Add
COMPILE_TESTsupport as a result so that the buildbots can run through this driver. There's nothing architecture specific about it.Signed-off-by Rosen Penev <[email protected]>
It'd be nice if the commit title and/or the commit description mentioned that this is for an existing driver in the tree.
Quoted 11 lines
--- drivers/clk/Kconfig | 7 +++++++ drivers/clk/Makefile | 2 +- drivers/clk/davinci/Makefile | 6 +++--- 3 files changed, 11 insertions(+), 4 deletions(-)drivers/clk/Kconfig +0
-0
drivers/clk/Kconfig config COMMON_CLK_AXI_CLKGEN · line 322
Quoted 6 lines
drivers/clk/Kconfig +3
-0@@ -317,6 +317,13 @@ config COMMON_CLK_AXI_CLKGEN Support for the Analog Devices axi-clkgen pcore clock generator for Xilinx FPGAs. It is commonly used in Analog Devices' reference designs. +config CLK_DA850 + bool "DaVinci DA850 CLK support" + depends on ARCH_DAVINCI_DA850 || COMPILE_TEST
The clk driver is needed for this platform, so you can make it easier for someone to configure their kernel like this:
depends on ARCH_ARM || COMPILE_TEST default ARCH_DAVINCI_DA850
Brian