Skip to contentSkip to conversation

arm64: dts/defconfig: enable BST C1200 eMMC

PATCH In review Albert Yang 3 participants 8 messages Apr 27 – Jun 2

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v8 cover arm64: dts/defconfig: enable BST C1200 eMMC

This series adds DTS and defconfig support for the eMMC controller on Black Sesame Technologies C1200 SoC, split from the v5 MMC series [1].

The MMC driver patches (dt-bindings, sdhci bounce buffer, BST SDHCI driver, and MAINTAINERS update) were merged via mmc-next during the v7.1 merge window and are now in mainline as of Linux 7.1-rc1 [2]. These remaining DTS and defconfig patches are submitted to the mailing lists for review (per Krzysztof's feedback on v6 [3])

Both patches now carry Acked-by: Gordon Ge <[email protected]> (BST maintainer), collected from the v7 thread [4][5].

Changes since v7 [6]:
- Collected Acked-by: Gordon Ge <[email protected]> on patch 1/2 [4]
- Collected Acked-by: Gordon Ge <[email protected]> on patch 2/2 [5]
- Rebased onto v7.1-rc1
- No code changes

Changes since v6:
- Resend with corrected recipients: send to mailing lists for review first, not directly to soc@ (BST has a platform maintainer in MAINTAINERS), per Krzysztof's feedback [3].

Changes since v5:
- Patch 2 (defconfig): fix CONFIG_MMC_SDHCI_BST ordering to match Kconfig position (between CONFIG_MMC_SDHCI_TEGRA and CONFIG_MMC_SDHCI_F_SDH30), as pointed out by Krzysztof Kozlowski. Confirmed via savedefconfig.

Build/check on v7.1-rc1:
- arch/arm64 defconfig: clean (savedefconfig keeps CONFIG_MMC_SDHCI_BST at its Kconfig-ordered position; no diff in the MMC_SDHCI section)
- arch/arm64/boot/dts/bst/bstc1200-cdcu1.0-adas_4c2g.dtb: builds clean with W=1 and CHECK_DTBS=y (no new warnings)
- checkpatch.pl --strict: 0 errors, 0 warnings, 0 checks on both patches

[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/lkml/CAPDyKFrcXFAiYouOpjDx3NN-xWACU9jAzEfTU2m_-yvQ9SpC_A@mail.gmail.com/
[3] https://lore.kernel.org/lkml/[email protected]/
[4] https://lore.kernel.org/lkml/[email protected]/
[5] https://lore.kernel.org/lkml/[email protected]/
[6] https://lore.kernel.org/lkml/[email protected]/

Albert Yang (2):
arm64: dts: bst: enable eMMC controller in C1200 CDCU1.0 board
arm64: defconfig: enable BST SDHCI controller

 .../dts/bst/bstc1200-cdcu1.0-adas_4c2g.dts    | 19 +++++++++++++++++++
 arch/arm64/boot/dts/bst/bstc1200.dtsi         | 18 ++++++++++++++++++
 arch/arm64/configs/defconfig                  |  1 +
 3 files changed, 38 insertions(+)

base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731

Signature · 1 line
2.43.0
#1 lore raw

PATCH v8 1/2 arm64: dts: bst: enable eMMC controller in C1200 CDCU1.0 board

Add eMMC controller support to the BST C1200 device tree:

- bstc1200.dtsi: Add mmc0 node for the DWCMSHC SDHCI controller with basic configuration (disabled by default)
- bstc1200.dtsi: Add fixed clock definition for MMC controller
- bstc1200-cdcu1.0-adas_4c2g.dts: Enable mmc0 with board-specific configuration including 8-bit bus width and reserved SRAM buffer

The bounce buffer in reserved SRAM addresses hardware constraints where the eMMC controller cannot access main system memory through SMMU due to a hardware bug, and all DRAM is located outside the 4GB boundary.

---
Changes for v8:
- Collected Acked-by: Gordon Ge <[email protected]>
- Rebased onto v7.1-rc1
- No code changes

Changes for v7:
- No code changes; resend with corrected recipients

Changes for v5:
- Split from platform series per Arnd's feedback

Changes for v4:
- Change compatible to bst,c1200-sdhci
- Move bus-width and non-removable to board dts

Changes for v3:
- Split defconfig into dedicated patch

Changes for v2:
- Reorganize memory map, standardize interrupt definitions

---
 .../dts/bst/bstc1200-cdcu1.0-adas_4c2g.dts    | 19 +++++++++++++++++++
 arch/arm64/boot/dts/bst/bstc1200.dtsi         | 18 ++++++++++++++++++
 2 files changed, 37 insertions(+)
arch/arm64/boot/dts/bst/bstc1200-cdcu1.0-adas_4c2g.dts +19 -0
index 5eb9ef369d8c..178ad4bf4f0a 100644
@@ -17,6 +17,25 @@ memory@810000000 {
 		      <0x8 0xc0000000 0x1 0x0>,
 		      <0xc 0x00000000 0x0 0x40000000>;
 	};
+
+	reserved-memory {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		mmc0_reserved: mmc0-reserved@5160000 {
+			compatible = "shared-dma-pool";
+			reg = <0x0 0x5160000 0x0 0x10000>;
+			no-map;
+		};
+	};
+};
+
+&mmc0 {
+	bus-width = <8>;
+	memory-region = <&mmc0_reserved>;
+	non-removable;
+	status = "okay";
 };
 
 &uart0 {
arch/arm64/boot/dts/bst/bstc1200.dtsi +18 -0
index dd13c6bfc3c8..9660d8396e27 100644
@@ -7,6 +7,12 @@ / {
 	#address-cells = <2>;
 	#size-cells = <2>;
 
+	clk_mmc: clock-4000000 {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <4000000>;
+	};
+
 	cpus {
 		#address-cells = <1>;
 		#size-cells = <0>;
@@ -72,6 +78,18 @@ uart0: serial@20008000 {
 			status = "disabled";
 		};
 
+		mmc0: mmc@22200000 {
+			compatible = "bst,c1200-sdhci";
+			reg = <0x0 0x22200000 0x0 0x1000>,
+			      <0x0 0x23006000 0x0 0x1000>;
+			clocks = <&clk_mmc>;
+			clock-names = "core";
+			dma-coherent;
+			interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>;
+			max-frequency = <200000000>;
+			status = "disabled";
+		};
+
 		gic: interrupt-controller@32800000 {
 			compatible = "arm,gic-v3";
 			reg = <0x0 0x32800000 0x0 0x10000>,
Signature · 1 line
2.43.0
#2 lore raw

PATCH v8 2/2 arm64: defconfig: enable BST SDHCI controller

In reply to Albert Yang

Enable CONFIG_MMC_SDHCI_BST to support eMMC on Black Sesame Technologies C1200 boards.

---
Changes for v8:
- Collected Acked-by: Gordon Ge <[email protected]>
- Rebased onto v7.1-rc1
- No code changes

Changes for v7:
- No code changes; resend with corrected recipients

Changes for v6:
- Fix CONFIG_MMC_SDHCI_BST ordering to match Kconfig position (between CONFIG_MMC_SDHCI_TEGRA and CONFIG_MMC_SDHCI_F_SDH30) as pointed out by Krzysztof Kozlowski. Confirmed via savedefconfig.

Changes for v5:
- Split from platform series per Arnd's feedback

Changes for v4:
- Move CONFIG_MMC_SDHCI_BST before CONFIG_MMC_SDHCI_F_SDH30

Changes for v3:
- Split from arm64: dts patch

Changes for v2:
- Initial defconfig change included in DTS patch

---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/configs/defconfig +1 -0
index d905a0777f93..304e12c80af9 100644
@@ -1292,6 +1292,7 @@ CONFIG_MMC_SDHCI_OF_SPARX5=y
 CONFIG_MMC_SDHCI_CADENCE=y
 CONFIG_MMC_SDHCI_ESDHC_IMX=y
 CONFIG_MMC_SDHCI_TEGRA=y
+CONFIG_MMC_SDHCI_BST=y
 CONFIG_MMC_SDHCI_F_SDH30=y
 CONFIG_MMC_MESON_GX=y
 CONFIG_MMC_SDHCI_MSM=y
Signature · 1 line
2.43.0
#3 lore raw
In reply to Albert Yang
Quoted 9 lines · Albert Yang

This series adds DTS and defconfig support for the eMMC controller on Black Sesame Technologies C1200 SoC, split from the v5 MMC series [1].

The MMC driver patches (dt-bindings, sdhci bounce buffer, BST SDHCI driver, and MAINTAINERS update) were merged via mmc-next during the v7.1 merge window and are now in mainline as of Linux 7.1-rc1 [2]. These remaining DTS and defconfig patches are submitted to the mailing lists for review (per Krzysztof's feedback on v6 [3])

You sent it already three times within one hour. Please stop.

Best regards,
Krzysztof

#4 lore raw
Quoted 1 line · Krzysztof Kozlowski

You sent it already three times within one hour. Please stop.

Apologies for the noise. Sending is stopped on my side and the root cause is still under investigation. Please use the canonical v8 for review:
https://lore.kernel.org/r/[email protected]

Thanks,
Albert

#5 lore raw
In reply to Albert Yang

Hi Arnd,

Gentle ping on this series. It has been about 5 weeks since v8 was posted.

The MMC driver patches from the original series were merged via mmc-next in v7.1-rc1. These remaining 2 patches (DTS + defconfig) are still pending.

Both patches have Acked-by: Gordon Ge <[email protected]>.

No code changes needed — still applies cleanly.

Would you be able to pick this up via soc tree?

Thanks,
Albert

#6 lore raw
Quoted 4 lines · Albert Yang

Hi Arnd,

Gentle ping on this series. It has been about 5 weeks since v8 was posted.

Quoted 9 lines

The MMC driver patches from the original series were merged via mmc-next in v7.1-rc1. These remaining 2 patches (DTS + defconfig) are still pending.

Both patches have Acked-by: Gordon Ge <[email protected]>.

No code changes needed — still applies cleanly.

Would you be able to pick this up via soc tree?

This is not a patchset for soc tree. This is patchset for BST - you are waiting on BST maintainers. I recommend reading soc maintainer profile doc, it describes the process.

Best regards,
Krzysztof

#7 lore raw
Quoted 9 lines · Krzysztof Kozlowski
Quoted 8 lines · Albert Yang

Gentle ping on this series. It has been about 5 weeks since v8 was posted.

The MMC driver patches from the original series were merged via mmc-next in v7.1-rc1. These remaining 2 patches (DTS + defconfig) are still pending.

Both patches have Acked-by: Gordon Ge <[email protected]>.

Quoted 7 lines
Quoted 3 lines

No code changes needed — still applies cleanly.

Would you be able to pick this up via soc tree?

This is not a patchset for soc tree. This is patchset for BST - you are waiting on BST maintainers. I recommend reading soc maintainer profile doc, it describes the process.

What's odd here is that Albert authored and sent all the BST patches so far, including the one that adds Gordon as the sole maintainer. I merged these from patches in the initial merge and expected to see future work get routed through Gordon.

Albert and Gordon, please figure out between yourselves how you want to handle this in the future. You can both be listed as maintainers if you want, but to make everybody's life easier, make sure that only a person who is listed in the MAINTAINERS files is responsible for collecting patches and forwarding them to [email protected] for inclusion.

Arnd