Skip to contentSkip to conversation

sched/deadline: Fix stale comment above yield_task_dl()

PATCH New Furkan Caliskan 1 participant 1 message Apr 27 Scheduler

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sched/deadline: Fix stale comment above yield_task_dl()

The comment above yield_task_dl() states that bandwidth reclaiming is "planned for the future". This is now obsolete as GRUB-PA has been implemented.

Update the comment to reflect that yielded bandwidth is now actively reclaimed for power saving and scheduling efficiency.

---
 kernel/sched/deadline.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)
kernel/sched/deadline.c +4 -7
index 27359a1e995f..fba29af74107 100644
@@ -2368,14 +2368,11 @@ static bool dequeue_task_dl(struct rq *rq, struct task_struct *p, int flags)
 }
 
 /*
- * Yield task semantic for -deadline tasks is:
+ * Get off from the CPU until our next instance
  *
- *   get off from the CPU until our next instance, with
- *   a new runtime. This is of little use now, since we
- *   don't have a bandwidth reclaiming mechanism. Anyway,
- *   bandwidth reclaiming is planned for the future, and
- *   yield_task_dl will indicate that some spare budget
- *   is available for other task instances to use it.
+ * Yielding indicates that the current instance has finished its work 
+ * early. This allows the remaining budget to be reclaimed by other
+ * tasks or used to reduce CPU frequency via the GRUB-PA mechanism. 
  */
 static void yield_task_dl(struct rq *rq)
 {
Signature · 1 line
2.34.1