char: xillybus: use strscpy() in init_chrdev
Subsystems (2)
PATCH 1/1 char: xillybus: use strscpy() in init_chrdev
The format specifier is unnecessary and can be removed. Replace snprintf("%s") with the faster and more direct strscpy().
--- drivers/char/xillybus/xillybus_class.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/char/xillybus/xillybus_class.c +2 -1
@@ -11,6 +11,7 @@#include <linux/fs.h> #include <linux/cdev.h> #include <linux/slab.h> +#include <linux/string.h> #include <linux/list.h> #include <linux/mutex.h>
@@ -65,7 +66,7 @@ int xillybus_init_chrdev(struct device *dev,mutex_lock (&unit_mutex);if (!enumerate) -snprintf (unit->name,UNITNAMELEN ,"%s" , prefix); +strscpy (unit->name, prefix);for (i =0 ; enumerate; i++) { snprintf(unit->name, UNITNAMELEN, "%s_%02d",
Eli Billauer
maintainerHello,
drivers/char/xillybus/xillybus_class.c int xillybus_init_chrdev(struct device *dev, · line 72
Quoted 6 lines · Thorsten Blum
if (!enumerate)
drivers/char/xillybus/xillybus_class.c +1
-1-snprintf (unit->name,UNITNAMELEN ,"%s" , prefix); +strscpy (unit->name, prefix);for (i =0 ; enumerate; i++) { snprintf(unit->name, UNITNAMELEN, "%s_%02d",
snprintf() is used deliberately for code clarity: It makes a simple visual contrast with the use of snprintf() three rows below. As this call takes place only once for each physical hardware device handled by the driver, the advantage in optimizing this function call is negligible.
And even though it's formally OK to use strscpy() with two arguments, and let the compilation machinery find out the length of the char array, I have to admit that it gives me the chills. Buffer overflow and that.
So overall, I can't say I'm very fond of this patch. Thanks for the effort nevertheless.
Regards,
Eli
Quoted 15 lines · Eli Billauer
Hello,
drivers/char/xillybus/xillybus_class.c int xillybus_init_chrdev(struct device *dev, · line 72
Quoted 5 lines · Thorsten Blum
if (!enumerate)
drivers/char/xillybus/xillybus_class.c +1
-1-snprintf (unit->name,UNITNAMELEN ,"%s" , prefix); +strscpy (unit->name, prefix);for (i =0 ; enumerate; i++) { snprintf(unit->name, UNITNAMELEN, "%s_%02d",
snprintf()is used deliberately for code clarity: It makes a simple visual contrast with the use ofsnprintf()three rows below. As this call takes place only once for each physical hardware device handled by the driver, the advantage in optimizing this function call is negligible.
Quoted 3 lines
And even though it's formally OK to use
strscpy()with two arguments, and let the compilation machinery find out the length of the char array, I have to admit that it gives me the chills. Buffer overflow and that.
You probably mean strcpy()? strscpy() is safe regarding buffer overflow.
Eli Billauer
maintainerQuoted 4 lines · Thorsten Blum
Quoted 3 lines
And even though it's formally OK to use
strscpy()with two arguments, and let the compilation machinery find out the length of the char array, I have to admit that it gives me the chills. Buffer overflow and that.You probably mean
strcpy()?strscpy()is safe regarding buffer overflow.
I meant strscpy(). We agree that it's formally safe to use, but I get a really bad feeling with not having the length of the buffer explicitly written out in the function call.
One could argue that it's better to let the machine figure out the length of the buffer instead of using UNITNAMELEN (because I'm a human and I can err), but in this specific case, UNITNAMELEN is relied upon anyhow a few rows later.
This is all about coding style. The main point is that I see this patch as a negligible optimization in CPU cycles coming with a slight obfuscation of the code's readability. A bit of "if it ain't broke, don't fix it".
Regards,
Eli