Skip to contentSkip to conversation

lib: compile generic bitrev based on GENERIC_BITREVERSE

PATCH New Yury Norov 1 participant 3 messages Apr 27

Subsystems (2)
lore
Share & tools
lore

Yury Norov

author
#0 lore raw

cover lib: compile generic bitrev based on GENERIC_BITREVERSE

The bitrev.c is compiled based on CONFIG_BITREVERSE=y, but everything inside is protected with CONFIG_GENERIC_BITREVERSE.

Make it simpler by switching the Makefile to compile lib/bitrev.c based on the proper config. Also, cover generic bitrev.[ch] with BITOPS entry.

Based on bitmap-for-next:

https://github.com/norov/linux/tree/bitmap-for-next

Yury Norov (2):
lib: compile generic bitrev.c conditionally on the proper option
MAINTAINERS: BITOPS: include bitrev.[ch]

 MAINTAINERS  | 2 ++
 lib/Makefile | 2 +-
 lib/bitrev.c | 3 ---
 3 files changed, 3 insertions(+), 4 deletions(-)
Signature · 1 line
2.51.0
author
#1 lore raw

PATCH 1/2 lib: compile generic bitrev.c conditionally on GENERIC_BITREVERSE

The file is compiled based on CONFIG_BITREVERSE=y, but everything inside is protected with CONFIG_GENERIC_BITREVERSE.

Make it simpler by switching the Makefile to compile lib/bitrev.c based on the proper config.

---
 lib/Makefile | 2 +-
 lib/bitrev.c | 3 ---
 2 files changed, 1 insertion(+), 4 deletions(-)
lib/Makefile +1 -1
index f33a24bf1c19..23e07d19d01c 100644
@@ -145,7 +145,7 @@ obj-$(CONFIG_DEBUG_PREEMPT) += smp_processor_id.o
 obj-$(CONFIG_LIST_HARDENED) += list_debug.o
 obj-$(CONFIG_DEBUG_OBJECTS) += debugobjects.o
 
-obj-$(CONFIG_BITREVERSE) += bitrev.o
+obj-$(CONFIG_GENERIC_BITREVERSE) += bitrev.o
 obj-$(CONFIG_LINEAR_RANGES) += linear_ranges.o
 obj-$(CONFIG_PACKING)	+= packing.o
 obj-$(CONFIG_PACKING_KUNIT_TEST) += packing_test.o
lib/bitrev.c +0 -3
index 3a53ff67aeba..05088231f31f 100644
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: GPL-2.0-only
-#ifdef CONFIG_GENERIC_BITREVERSE
 #include <linux/types.h>
 #include <linux/module.h>
 #include <linux/bitrev.h>
@@ -43,5 +42,3 @@ const u8 byte_rev_table[256] = {
 	0x1f, 0x9f, 0x5f, 0xdf, 0x3f, 0xbf, 0x7f, 0xff,
 };
 EXPORT_SYMBOL_GPL(byte_rev_table);
-
-#endif /* CONFIG_GENERIC_BITREVERSE */
Signature · 1 line
2.51.0
author
#2 lore raw

PATCH 2/2 MAINTAINERS: BITOPS: include bitrev.[ch]

In reply to Yury Norov

Arch bitrev API is covered in MAINTAINERS under the BITOPS entry, while generic bitrev is unmaintained. Move it under BITOPS too.

---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index d885cf5ccc34..7ad239209380 100644
@@ -4547,7 +4547,9 @@ F:	arch/*/lib/bitops.c
 F:	include/asm-generic/bitops
 F:	include/asm-generic/bitops.h
 F:	include/linux/bitops.h
+F:	include/linux/bitrev.h
 F:	include/linux/count_zeros.h
+F:	lib/bitrev.c
 F:	lib/hweight.c
 F:	lib/test_bitops.c
 F:	lib/tests/bitops_kunit.c
Signature · 1 line
2.51.0