rust: block: fix comment referring to states by wrong labels
Subsystems (3)
PATCH 1/1 rust: block: fix comment referring to states by wrong labels
The comment in Request describing the four ownership states referred to states 2 and 3 as "B" and "C", which are inconsistent with the numbering scheme used throughout the same comment block.
Update the labels to use "2" and "3" to match the existing numbered list.
--- rust/kernel/block/mq/request.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
rust/kernel/block/mq/request.rs +1 -1
@@ -39,7 +39,7 @@/// back ownership to the block layer. /// /// Note that the driver can still obtain new `ARef` even if there is no `ARef`s in existence by -/// using `tag_to_rq`, hence the need to distinguish B and C. +/// using `tag_to_rq`, hence the need to distinguish 2 and 3. /// /// The states are tracked through the private `refcount` field of /// `RequestDataWrapper`. This structure lives in the private data area of the C
---
base-commit: b4e07588e743c989499ca24d49e752c074924a9a
change-id: 20260428-fix-docs-mq-req-d2a0fe1b6471
Best regards,
Signature · 1 line
Hsiu Che Yu <[email protected]>
Quoted 2 lines · Hsiu Che Yu
Fixes a307bf1db5448 ("rust: block: convert `block::mq` to use `Refcount`")
Since this commit exists in stable kernels, and this is visible in generated docs, we generally tag them for backport, so I am doing so here:
Thanks!
Cheers,
Miguel
Quoted 5 lines · Miguel Ojeda
Since this commit exists in stable kernels, and this is visible in generated docs, we generally tag them for backport, so I am doing so here:
Thanks!
Andreas Hindborg
maintainerHi,
Quoted 30 lines · Hsiu Che Yu
The comment in
Requestdescribing the four ownership states referred to states 2 and 3 as "B" and "C", which are inconsistent with the numbering scheme used throughout the same comment block.Update the labels to use "2" and "3" to match the existing numbered list.
Fixes a307bf1db5448 ("rust: block: convert `block::mq` to use `Refcount`")Signed-off-by Hsiu Che Yu <[email protected]>--- rust/kernel/block/mq/request.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)rust/kernel/block/mq/request.rs +1
-2@@ -39,7 +39,7 @@/// back ownership to the block layer. /// /// Note that the driver can still obtain new `ARef` even if there is no `ARef`s in existence by -/// using `tag_to_rq`, hence the need to distinguish B and C. +/// using `tag_to_rq`, hence the need to distinguish 2 and 3. /// /// The states are tracked through the private `refcount` field of /// `RequestDataWrapper`. This structure lives in the private data area of the C ---base-commit:
b4e07588e743c989499ca24d49e752c074924a9a
change-id: 20260428-fix-docs-mq-req-d2a0fe1b6471
Quoted 3 lines
Best regards,
--
Hsiu Che Yu <[email protected]>
Thanks for the patch. Please be aware that this mistake is fixed in the latest rust null block series [1]. Please take a look at that series if you have more patches for the rust block subsystem queued.
Best regards,
Andreas Hindborg
[1] https://lore.kernel.org/rust-for-linux/[email protected]/
Quoted 3 lines · Andreas Hindborg
Thanks for the patch. Please be aware that this mistake is fixed in the latest rust null block series [1]. Please take a look at that series if you have more patches for the rust block subsystem queued.
Thank you for letting me know. I'll take a look at the series.
Best regards,
Hsiu