Skip to contentSkip to conversation

r8152: Fix double consecutive clearing of PLA_MCU_SPDWN_EN bit

PATCH Applied Birger Koblitz 2 participants 2 messages Apr 28 – Apr 30

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 r8152: Fix double consecutive clearing of PLA_MCU_SPDWN_EN bit

Due to a Copy & Paste Error, the PLA_MCU_SPDWN_EN bit was cleared twice consecutively using ocp_word_clr_bits. Fix that.

---
This fixes the issue raised in
https://lore.kernel.org/netdev/[email protected]/
that due to an editing error, PLA_MCU_SPDWN_EN is cleared twice consecutively.

---
 drivers/net/usb/r8152.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/net/usb/r8152.c +0 -3
index 7337bf1b7d6ad03572edbc492706c07a8f58760f..7dba5f3fd052d4db475e61f5c622d89ada1948c1 100644
@@ -6839,9 +6839,6 @@ static void rtl8156_up(struct r8152 *tp)
 	ocp_word_w0w1(tp, MCU_TYPE_PLA, PLA_RXFIFO_FULL, RXFIFO_FULL_MASK,
 		      0x08);
 
-	ocp_word_clr_bits(tp, MCU_TYPE_PLA, PLA_MAC_PWR_CTRL3,
-			  PLA_MCU_SPDWN_EN);
-
 	ocp_word_clr_bits(tp, MCU_TYPE_PLA, PLA_MAC_PWR_CTRL3, PLA_MCU_SPDWN_EN);
 
 	if (tp->version != RTL_VER_16)

---
base-commit: 35c2c39832e569449b9192fa1afbbc4c66227af7
change-id: 20260426-patch_double-1fc3cea4e9cc

Best regards,

Signature · 1 line
Birger Koblitz <[email protected]>
#1 lore raw
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 11 lines · On Tue, 28 Apr 2026 05:43:38 +0200 you wrote:

Due to a Copy & Paste Error, the PLA_MCU_SPDWN_EN bit was cleared twice consecutively using ocp_word_clr_bits. Fix that.

---
This fixes the issue raised in
https://lore.kernel.org/netdev/[email protected]/
that due to an editing error, PLA_MCU_SPDWN_EN is cleared twice consecutively.

[...]

Here is the summary with links:
- [net-next] r8152: Fix double consecutive clearing of PLA_MCU_SPDWN_EN bit

    https://git.kernel.org/netdev/net-next/c/115553b80f77

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html