drm/amdgpu: fix build for CONFIG_DRM_FBDEV_EMULATION=n
Subsystems (2)
PATCH v2 1/1 drm/amdgpu: fix build for CONFIG_DRM_FBDEV_EMULATION=n
The merge-commit 02e778f12359 ("Merge tag 'amd-drm-next-7.1-2026-03-12' of
https://gitlab.freedesktop.org/agd5f/linux into drm-next") removes the stub for drm_fb_helper_gem_is_fb(), so the buld gets broken if DRM_FBDEV_EMULATION is not set.
‘drm_fb_helper_gem_is_fb’; did you mean ‘drm_fb_helper_from_client’? [-Wimplicit-function-declaration]
1777 | if (!drm_fb_helper_gem_is_fb(dev->fb_helper, fb->obj[0])) {
| ^~~~~~~~~~~~~~~~~~~~~~~
| drm_fb_helper_from_clientRestore it.
---
v2: restore only drm_fb_helper_gem_is_fb() (Thomas)
include/drm/drm_fb_helper.h | 6 ++++++ 1 file changed, 6 insertions(+)
include/drm/drm_fb_helper.h +6 -0
@@ -273,6 +273,12 @@ int drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper);int drm_fb_helper_initial_config (struct drm_fb_helper *fb_helper);bool drm_fb_helper_gem_is_fb (const struct drm_fb_helper *fb_helper,const struct drm_gem_object *obj); +#else +static inline bool drm_fb_helper_gem_is_fb (const struct drm_fb_helper *fb_helper, +const struct drm_gem_object *obj) +{ +return false; +}#endif #endif
Signature · 1 line
2.51.0
Am 28.04.26 um 04:49 schrieb Yury Norov:
Quoted 6 lines
The merge-commit
02e778f12359("Merge tag 'amd-drm-next-7.1-2026-03-12' of
https://gitlab.freedesktop.org/agd5f/linux into drm-next") removes the stub fordrm_fb_helper_gem_is_fb(), so the buld gets broken ifDRM_FBDEV_EMULATIONis not set.‘drm_fb_helper_gem_is_fb’; did you mean ‘drm_fb_helper_from_client’? [-Wimplicit-function-declaration]
Quoted 8 lines
1777 | if (!drm_fb_helper_gem_is_fb(dev->fb_helper, fb->obj[0])) { | ^~~~~~~~~~~~~~~~~~~~~~~ | drm_fb_helper_from_clientRestore it.
Fixes 02e778f12359 ("Merge tag 'amd-drm-next-7.1-2026-03-12' of https://gitlab.freedesktop.org/agd5f/linux into drm-next")Signed-off-by Yury Norov <[email protected]>
Quoted 23 lines
---
v2: restore onlydrm_fb_helper_gem_is_fb()(Thomas)include/drm/drm_fb_helper.h | 6 ++++++ 1 file changed, 6 insertions(+)include/drm/drm_fb_helper.h +6
-0@@ -273,6 +273,12 @@ int drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper);int drm_fb_helper_initial_config (struct drm_fb_helper *fb_helper);bool drm_fb_helper_gem_is_fb (const struct drm_fb_helper *fb_helper,const struct drm_gem_object *obj); +#else +static inline bool drm_fb_helper_gem_is_fb (const struct drm_fb_helper *fb_helper, +const struct drm_gem_object *obj) +{ +return false; +}#endif #endif
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
Alex Deucher
AppliedApplied. Thanks!
Alex
Quoted 54 lines · Thomas Zimmermann
Am 28.04.26 um 04:49 schrieb Yury Norov:
Quoted 6 lines
The merge-commit
02e778f12359("Merge tag 'amd-drm-next-7.1-2026-03-12' of
https://gitlab.freedesktop.org/agd5f/linux into drm-next") removes the stub fordrm_fb_helper_gem_is_fb(), so the buld gets broken ifDRM_FBDEV_EMULATIONis not set.‘drm_fb_helper_gem_is_fb’; did you mean ‘drm_fb_helper_from_client’? [-Wimplicit-function-declaration]
Quoted 8 lines
1777 | if (!drm_fb_helper_gem_is_fb(dev->fb_helper, fb->obj[0])) { | ^~~~~~~~~~~~~~~~~~~~~~~ | drm_fb_helper_from_clientRestore it.
Fixes 02e778f12359 ("Merge tag 'amd-drm-next-7.1-2026-03-12' of https://gitlab.freedesktop.org/agd5f/linux into drm-next")Signed-off-by Yury Norov <[email protected]>Reviewed-by Thomas Zimmermann <[email protected]>Quoted 13 lines
---
v2: restore onlydrm_fb_helper_gem_is_fb()(Thomas)include/drm/drm_fb_helper.h | 6 ++++++ 1 file changed, 6 insertions(+)include/drm/drm_fb_helper.h +0
-0@@ -273,6 +273,12 @@ int drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper);int drm_fb_helper_initial_config (struct drm_fb_helper *fb_helper); bool drm_fb_helper_gem_is_fb(const struct drm_fb_helper *fb_helper,include/drm/drm_fb_helper.h int drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper); · line 284
Quoted 10 lines
include/drm/drm_fb_helper.h +6
-0const struct drm_gem_object *obj); +#else +static inline bool drm_fb_helper_gem_is_fb (const struct drm_fb_helper *fb_helper, +const struct drm_gem_object *obj) +{ +return false; +}#endif #endif --
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)