Skip to contentSkip to conversation

aio_cancel: Fix incorrect strerror() usage

PATCH Superseded Martin Doucha 3 participants 3 messages Apr 28 – Apr 29

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 aio_cancel: Fix incorrect strerror() usage

Each call of strerror() invalidates the previous return value. Split print calls to avoid calling strerror() twice in the argument list.

---
 .../conformance/interfaces/aio_cancel/5-1.c                  | 5 +++--
 .../conformance/interfaces/aio_cancel/7-1.c                  | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)
testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/5-1.c +3 -2
index dd5b0bbfb..04306417e 100644
@@ -131,8 +131,9 @@ int test_main(int argc PTS_ATTRIBUTE_UNUSED, char **argv PTS_ATTRIBUTE_UNUSED)
 		}
 
 		if (ret != exp_ret) {
-			printf(TNAME " Bad task #%d result: %s (expected %s)\n",
-				i, strerror(ret), strerror(exp_ret));
+			printf(TNAME " Bad task #%d result: %s",
+				i, strerror(ret));
+			printf(" (expected %s)\n", strerror(exp_ret));
 			cleanup_aio(fds, aiocb, BUF_NB);
 			return PTS_FAIL;
 		}
testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/7-1.c +3 -2
index 36ce8bb12..0fdc1bef8 100644
@@ -118,8 +118,9 @@ int test_main(int argc PTS_ATTRIBUTE_UNUSED, char **argv PTS_ATTRIBUTE_UNUSED)
 		}
 
 		if (ret != exp_ret) {
-			printf(TNAME " Bad task #%d result: %s (expected %s)\n",
-				i, strerror(ret), strerror(exp_ret));
+			printf(TNAME " Bad task #%d result: %s",
+				i, strerror(ret));
+			printf(" (expected %s)\n", strerror(exp_ret));
 			cleanup_aio(fds, aiocb, BUF_NB);
 			return PTS_FAIL;
 		}
Signature · 5 lines
2.53.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Hi Martin,

--- [PATCH 1/2] ---

Quoted 1 line · Martin Doucha

aio_cancel: Fix incorrect strerror() usage

This is fixing a real bug but both patches in this series are missing
Fixes: tags.

--- [PATCH 2/2] ---

Review

Quoted 5 lines · Martin Doucha

aio_cancel_6-1: Rewrite test

(quoted diff) +3 -0
+	if (gret != AIO_CANCELED) {
+		printf(TNAME " Unexpected aio_cancel() return value: %s\n",
+			strerror(gret));

strerror() expects an errno value; AIO_CANCELED, AIO_NOTCANCELED, and AIO_ALLDONE are not errno values (they are 0, 1, 2 on Linux, mapping to "Success", "Operation not permitted", "No such file or directory"). Use "%d" to print the raw integer instead.

Pre-existing issues noticed in the surrounding code (not introduced by this patch):

- 5-1.c:70, 7-1.c:56 — nanosleep() used for synchronization in a polling loop (sleep-based sync).

---
Note:

Our agent completed the review of the patch. The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp