x86/resctrl: Only check Intel systems for SNC
Subsystems (2)
Tony Luck
maintainerPATCH 1/1 x86/resctrl: Only check Intel systems for SNC
topology_num_nodes_per_package() reports values greater than one on certain AMD systems resulting in snc_get_config() printing the confusing message "CoD enabled system? Resctrl not supported".
Add a check for Intel systems before looking at topology.
Fixes 59674fc9d0bf ("x86/resctrl: Fix SNC detection")
Reported-by Babu Moger Babu <[email protected]>
Signed-off-by Tony Luck <[email protected]>
Tested-by Babu Moger Babu <[email protected]>
--- arch/x86/kernel/cpu/resctrl/monitor.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
arch/x86/kernel/cpu/resctrl/monitor.c +6 -1
@@ -377,7 +377,12 @@ static const struct x86_cpu_id snc_cpu_ids[] __initconst = {static __init int snc_get_config (void ) { -int ret =topology_num_nodes_per_package (); +int ret; + +if (boot_cpu_data.x86_vendor !=X86_VENDOR_INTEL ) +return 1 ; + + ret =topology_num_nodes_per_package ();if (ret >1 && !x86_match_cpu (snc_cpu_ids)) {pr_warn ("CoD enabled system? Resctrl not supported\n" );
Signature · 1 line
2.53.0
+ Reinette:
Quoted 8 lines · Tony Luck
topology_num_nodes_per_package()reports values greater than one on certain AMD systems resulting insnc_get_config()printing the confusing message "CoD enabled system? Resctrl not supported".Add a check for Intel systems before looking at topology.
Fixes 59674fc9d0bf ("x86/resctrl: Fix SNC detection")Reported-by Babu Moger Babu <[email protected]>
Should be:
Reported-by Babu Moger <[email protected]>
Quoted 2 lines
Signed-off-by Tony Luck <[email protected]>Tested-by Babu Moger Babu <[email protected]>
Should be:
Tested-by Babu Moger <[email protected]>
Quoted 22 lines
--- arch/x86/kernel/cpu/resctrl/monitor.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)arch/x86/kernel/cpu/resctrl/monitor.c +6
-1@@ -377,7 +377,12 @@ static const struct x86_cpu_id snc_cpu_ids[] __initconst = {static __init int snc_get_config (void ) { -int ret =topology_num_nodes_per_package (); +int ret; + +if (boot_cpu_data.x86_vendor !=X86_VENDOR_INTEL ) +return 1 ; + + ret =topology_num_nodes_per_package ();if (ret >1 && !x86_match_cpu (snc_cpu_ids)) {pr_warn ("CoD enabled system? Resctrl not supported\n" );