sched: Use trace_call__<tp>() to save a static branch
PATCH 1/1 sched: Use trace_call__<tp>() to save a static branch
The wrapper functions __trace_set_current_state() and __trace_set_need_resched() allow the tracepoints to be called from code outside sched/core.c, those calls are already guarded by a tracepoint_enabled(<tp>) so there is no need to repeat this check once again inside the call using trace_<tp>().
Use the new trace_call__<tp>() API to directly call the tracepoint without check. Those helper functions must be called after the appropriate check.
--- kernel/sched/core.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)
kernel/sched/core.c +11 -3
@@ -537,10 +537,14 @@ sched_core_dequeue(struct rq *rq, struct task_struct *p, int flags) { }/* need a wrapper since we may need to trace from modules */ EXPORT_TRACEPOINT_SYMBOL (sched_set_state_tp); -/* Call via the helper macro trace_set_current_state. */ +/* +* Call via the helper macro trace_set_current_state. +* Calls to this function MUST be guarded by a +* tracepoint_enabled(sched_set_state_tp) +*/ void __trace_set_current_state (int state_value) { -trace_sched_set_state_tp (current, state_value); +trace_call__sched_set_state_tp (current, state_value); }EXPORT_SYMBOL (__trace_set_current_state);
@@ -1203,9 +1207,13 @@ static void __resched_curr(struct rq *rq, int tif) } } +/* +* Calls to this function MUST be guarded by a +* tracepoint_enabled(sched_set_need_resched_tp) +*/ void __trace_set_need_resched (struct task_struct *curr,int tif) { -trace_sched_set_need_resched_tp (curr,smp_processor_id (), tif); +trace_call__sched_set_need_resched_tp (curr,smp_processor_id (), tif); }EXPORT_SYMBOL_GPL (__trace_set_need_resched);
base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731
Signature · 1 line
2.54.0
The following commit has been merged into the sched/core branch of tip:
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 4ac4d6549a6563878d7c19c154e017f6cb7114d3 Gitweb: https://git.kernel.org/tip/4ac4d6549a6563878d7c19c154e017f6cb7114d3 Author: Gabriele Monaco <[email protected]> AuthorDate: Wed, 29 Apr 2026 11:41:37 +02:00 Committer: Peter Zijlstra <[email protected]> CommitterDate: Tue, 05 May 2026 12:50:50 +02:00
sched: Use trace_call__<tp>() to save a static branch
The wrapper functions __trace_set_current_state() and __trace_set_need_resched() allow the tracepoints to be called from code outside sched/core.c, those calls are already guarded by a tracepoint_enabled(<tp>) so there is no need to repeat this check once again inside the call using trace_<tp>().
Use the new trace_call__<tp>() API to directly call the tracepoint without check. Those helper functions must be called after the appropriate check.
--- kernel/sched/core.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)
kernel/sched/core.c +11 -3
@@ -537,10 +537,14 @@ sched_core_dequeue(struct rq *rq, struct task_struct *p, int flags) { }/* need a wrapper since we may need to trace from modules */ EXPORT_TRACEPOINT_SYMBOL (sched_set_state_tp); -/* Call via the helper macro trace_set_current_state. */ +/* +* Call via the helper macro trace_set_current_state. +* Calls to this function MUST be guarded by a +* tracepoint_enabled(sched_set_state_tp) +*/ void __trace_set_current_state (int state_value) { -trace_sched_set_state_tp (current, state_value); +trace_call__sched_set_state_tp (current, state_value); }EXPORT_SYMBOL (__trace_set_current_state);
@@ -1203,9 +1207,13 @@ static void __resched_curr(struct rq *rq, int tif) } } +/* +* Calls to this function MUST be guarded by a +* tracepoint_enabled(sched_set_need_resched_tp) +*/ void __trace_set_need_resched (struct task_struct *curr,int tif) { -trace_sched_set_need_resched_tp (curr,smp_processor_id (), tif); +trace_call__sched_set_need_resched_tp (curr,smp_processor_id (), tif); }EXPORT_SYMBOL_GPL (__trace_set_need_resched);