Skip to contentSkip to conversation

x86/boot: remove commented out code in getchar()

PATCH NAK Thorsten Blum 2 participants 2 messages Apr 29 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/boot: remove commented out code in getchar()

The code has been commented out ever since commit df7699c56421 ("x86,
setup: "glove box" BIOS interrupts in the core boot code") - remove it.

---
 arch/x86/boot/tty.c | 1 -
 1 file changed, 1 deletion(-)
arch/x86/boot/tty.c +0 -1
index f7eb976b0a4b..3ca8115ef5eb 100644
@@ -88,7 +88,6 @@ int getchar(void)
 	struct biosregs ireg, oreg;
 
 	initregs(&ireg);
-	/* ireg.ah = 0x00; */
 	intcall(0x16, &ireg, &oreg);
 
 	return oreg.al;
reviewer NAK
#1 lore raw
Quoted 13 lines · Thorsten Blum

The code has been commented out ever since commit df7699c56421 ("x86,
setup: "glove box" BIOS interrupts in the core boot code") - remove it.

---
arch/x86/boot/tty.c | 1 -

1 file changed, 1 deletion(-)
arch/x86/boot/tty.c +0 -0
index f7eb976b0a4b..3ca8115ef5eb 100644

arch/x86/boot/tty.c int getchar(void) · line 93

Quoted 7 lines
arch/x86/boot/tty.c +0 -1
@@ -88,7 +88,6 @@ int getchar(void)
 	struct biosregs ireg, oreg;
 
 	initregs(&ireg);
-	/* ireg.ah = 0x00; */
 	intcall(0x16, &ireg, &oreg);
 
 	return oreg.al;

NAK.

It's a comment: it isn't necessary to set ireg.ah to zero there because it is already zero.