ASoC: cs35l56: Fix hibernate write in runtime resume error path
Subsystems (3)
Richard Fitzgerald
maintainerPATCH v2 1/1 ASoC: cs35l56: Fix hibernate write in runtime resume error path
The error path of cs35l56_runtime_resume_common() should only write the hibernation sequence if can_hibernate is true.
Something has already gone badly wrong if we ever reach the error path. But triggering hibernate on hardware that does not support it is likely to make the situation unrecoverable without a full reboot because there might not be any hardware signal to exit hibernate.
---
Change in v2:
Fixed commit message typo "necause" -> "because".
sound/soc/codecs/cs35l56-shared.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
sound/soc/codecs/cs35l56-shared.c +5 -3
@@ -851,9 +851,11 @@ int cs35l56_runtime_resume_common(struct cs35l56_base *cs35l56_base, bool is_sou err:regcache_cache_only (cs35l56_base->regmap, true); -regmap_multi_reg_write_bypassed (cs35l56_base->regmap, - cs35l56_hibernate_seq, -ARRAY_SIZE (cs35l56_hibernate_seq)); +if (cs35l56_base->can_hibernate) { +regmap_multi_reg_write_bypassed (cs35l56_base->regmap, + cs35l56_hibernate_seq, +ARRAY_SIZE (cs35l56_hibernate_seq)); + }return ret; }
Signature · 1 line
2.47.3
Mark Brown
maintainerQuoted 1 line · Richard Fitzgerald
ASoC: cs35l56: Fix hibernate write in runtime resume error path
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.1
Thanks!
[1/1] ASoC: cs35l56: Fix hibernate write in runtime resume error path
https://git.kernel.org/broonie/sound/c/c64e77490b7e
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark