Skip to contentSkip to conversation

memory: atmel-ebi: Allow deferred probing

PATCH Applied Alexander Dahl 3 participants 4 messages Apr 29 – May 29

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 memory: atmel-ebi: Allow deferred probing

After removing of_platform_default_populate() calls the atmel-ebi driver was affected by deferred probing. platform_driver_probe() is incompatible with deferred probing. This led to atmel-ebi driver eventually not being probed on at91 sam9x60-curiosity and other sam9x60 based boards. Subsequently the nand-controller driver (nand-controller being a child node of ebi) on that platform was not probed and thus raw NAND flash was inaccessible, preventing devices to boot with rootfs on raw NAND flash (e.g. with UBI/UBIFS).

Fixes 0b0f7e6539a7 ("ARM: at91: remove unnecessary of_platform_default_populate calls")

---

Notes:
Successfully tested on sam9x60-curiosity board, and on two custom boards based on sam9x60 and sama5d2.

 drivers/memory/atmel-ebi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/memory/atmel-ebi.c +2 -1
index 8db970da9af96..1e8e8aba2542d 100644
@@ -628,10 +628,11 @@ static __maybe_unused int atmel_ebi_resume(struct device *dev)
 static SIMPLE_DEV_PM_OPS(atmel_ebi_pm_ops, NULL, atmel_ebi_resume);
 
 static struct platform_driver atmel_ebi_driver = {
+	.probe = atmel_ebi_probe,
 	.driver = {
 		.name = "atmel-ebi",
 		.of_match_table	= atmel_ebi_id_table,
 		.pm = &atmel_ebi_pm_ops,
 	},
 };
-builtin_platform_driver_probe(atmel_ebi_driver, atmel_ebi_probe);
+builtin_platform_driver(atmel_ebi_driver);

base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731

Signature · 1 line
2.47.3
maintainer Applied
#1 lore raw
Quoted 10 lines · Alexander Dahl

After removing of_platform_default_populate() calls the atmel-ebi driver was affected by deferred probing. platform_driver_probe() is incompatible with deferred probing. This led to atmel-ebi driver eventually not being probed on at91 sam9x60-curiosity and other sam9x60 based boards. Subsequently the nand-controller driver (nand-controller being a child node of ebi) on that platform was not probed and thus raw NAND flash was inaccessible, preventing devices to boot with rootfs on raw NAND flash (e.g. with UBI/UBIFS).

[...]

Applied, thanks!

[1/1] memory: atmel-ebi: Allow deferred probing

      https://git.kernel.org/krzk/linux-mem-ctrl/c/754d60ad1c91895be0bc7d771fbf9fb3c9448640

Best regards,

Signature · 1 line
Krzysztof Kozlowski <[email protected]>
#2 lore raw
Quoted 11 lines · Krzysztof Kozlowski
Quoted 9 lines · Alexander Dahl

After removing of_platform_default_populate() calls the atmel-ebi driver was affected by deferred probing. platform_driver_probe() is incompatible with deferred probing. This led to atmel-ebi driver eventually not being probed on at91 sam9x60-curiosity and other sam9x60 based boards. Subsequently the nand-controller driver (nand-controller being a child node of ebi) on that platform was not probed and thus raw NAND flash was inaccessible, preventing devices to boot with rootfs on raw NAND flash (e.g. with UBI/UBIFS).

Quoted 6 lines
Quoted 1 line

[...]

Applied, thanks!

[1/1] memory: atmel-ebi: Allow deferred probing

      https://git.kernel.org/krzk/linux-mem-ctrl/c/754d60ad1c91895be0bc7d771fbf9fb3c9448640

Lo! What's the status of this regression fix? It seems to be sitting in next for a while already. To me as an outsider it looks like this should be on track to get it merged for -rc6, as that's when Linus ideally wants all regressions fixed; but it looks a bit like this is destined to be merged in the next merge window. But I might be entirely wrong here -- or I'm right and there are good reasons why the next merge window is better here.

Ciao, Thorsten

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

#3 lore raw
Quoted 19 lines · Thorsten Leemhuis
Quoted 11 lines · Krzysztof Kozlowski
Quoted 9 lines · Alexander Dahl

After removing of_platform_default_populate() calls the atmel-ebi driver was affected by deferred probing. platform_driver_probe() is incompatible with deferred probing. This led to atmel-ebi driver eventually not being probed on at91 sam9x60-curiosity and other sam9x60 based boards. Subsequently the nand-controller driver (nand-controller being a child node of ebi) on that platform was not probed and thus raw NAND flash was inaccessible, preventing devices to boot with rootfs on raw NAND flash (e.g. with UBI/UBIFS).

Quoted 6 lines
Quoted 1 line

[...]

Applied, thanks!

[1/1] memory: atmel-ebi: Allow deferred probing

      https://git.kernel.org/krzk/linux-mem-ctrl/c/754d60ad1c91895be0bc7d771fbf9fb3c9448640
Quoted 7 lines

Lo! What's the status of this regression fix? It seems to be sitting in next for a while already. To me as an outsider it looks like this should be on track to get it merged for -rc6, as that's when Linus ideally wants all regressions fixed; but it looks a bit like this is destined to be merged in the next merge window. But I might be entirely wrong here -- or I'm right and there are good reasons why the next merge window is better here.

Thanks for pinging. This indeed deserves fixing in current RC and I completely missed that. Or applied on wrong branch and forgot that it is a fix. I sent RC fix pull request with this now.

Best regards,
Krzysztof