Skip to contentSkip to conversation

libsepol: Change log level of "Failed to resolve" message

PATCH In review James Carter 1 participant 2 messages Apr 29 – May 13 SELinux security module

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libsepol: Change log level of "Failed to resolve" message

Commit bd56ae44 "libsepol: When resolving names check if a block is abstract" added a log message to report that a name failed to resolve. This message was given a log level of CIL_ERR, which means that it is always displayed. This can lead to a large number of log messages when a policy has many unresolved name look-ups because of optional blocks referring to policy that is not loaded.

Instead, make the log level CIL_INFO which will cause the message to be generated only when the user requests higher log level messages to be displayed.

---
 libsepol/cil/src/cil_resolve_ast.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
libsepol/cil/src/cil_resolve_ast.c +1 -1
index b0965f1d..048b3aaa 100644
@@ -4407,7 +4407,7 @@ int cil_resolve_name_keep_aliases(struct cil_tree_node *ast_node, char *name, en
 
 exit:
 	if (rc != SEPOL_OK) {
-		cil_tree_log(ast_node, CIL_ERR, "Failed to resolve %s", name);
+		cil_tree_log(ast_node, CIL_INFO, "Failed to resolve %s", name);
 		*datum = NULL;
 	}
 
Signature · 1 line
2.53.0
#1 lore raw
Quoted 8 lines · James Carter

Commit bd56ae44 "libsepol: When resolving names check if a block is abstract" added a log message to report that a name failed to resolve. This message was given a log level of CIL_ERR, which means that it is always displayed. This can lead to a large number of log messages when a policy has many unresolved name look-ups because of optional blocks referring to policy that is not loaded.

Quoted 6 lines

Instead, make the log level CIL_INFO which will cause the message to be generated only when the user requests higher log level messages to be displayed.

This patch has been merged.
Jim

Quoted 20 lines
---
 libsepol/cil/src/cil_resolve_ast.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
libsepol/cil/src/cil_resolve_ast.c +1 -2
index b0965f1d..048b3aaa 100644
@@ -4407,7 +4407,7 @@ int cil_resolve_name_keep_aliases(struct cil_tree_node *ast_node, char *name, en
 
 exit:
        if (rc != SEPOL_OK) {
-               cil_tree_log(ast_node, CIL_ERR, "Failed to resolve %s", name);
+               cil_tree_log(ast_node, CIL_INFO, "Failed to resolve %s", name);
                *datum = NULL;
        }
 
--

2.53.0