Skip to contentSkip to conversation

regulator: rpi-panel-attiny: add back GPIOLIB dependency

PATCH In review Arnd Bergmann 2 participants 2 messages Apr 29 – Apr 30 Voltage and current regulator framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 regulator: rpi-panel-attiny: add back GPIOLIB dependency

From: Arnd Bergmann <[email protected]>

This driver provides a gpio chip, which is only possible when GPIOLIB is enabled, which was previously guaranteed by the CONFIG_OF_GPIO dependency that is now gone:

ERROR: modpost: "gpiochip_get_data" [drivers/regulator/rpi-panel-attiny-regulator.ko] undefined!
ERROR: modpost: "devm_gpiochip_add_data_with_key" [drivers/regulator/rpi-panel-attiny-regulator.ko] undefined!

Add an explicit GPIOLIB dependency instead.

Fixes bf017304fce1 ("regulator: drop unneeded dependencies on OF_GPIO")
---
 drivers/regulator/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/regulator/Kconfig +1 -0
index 390b7e88868a..5d66ca3e1f8a 100644
@@ -1233,6 +1233,7 @@ config REGULATOR_RASPBERRYPI_TOUCHSCREEN_ATTINY
 	tristate "Raspberry Pi 7-inch touchscreen panel ATTINY regulator"
 	depends on ARM || ARM64 || COMPILE_TEST
 	depends on BACKLIGHT_CLASS_DEVICE
+	depends on GPIOLIB
 	depends on I2C
 	select REGMAP_I2C
 	help
Signature · 1 line
2.39.5
maintainer
#1 lore raw
Quoted 1 line · Arnd Bergmann

regulator: rpi-panel-attiny: add back GPIOLIB dependency

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-7.1

Thanks!

[1/1] regulator: rpi-panel-attiny: add back GPIOLIB dependency

      https://git.kernel.org/broonie/regulator/c/7dfc00630220

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark