Skip to contentSkip to conversation

staging: fbtft: remove unused function fbtft_write_gpio16_wr_latched

PATCH In review Hungyu Lin 2 participants 2 messages Apr 30

Subsystems (3)
lore
Share & tools
lore

Hungyu Lin

author
#0 lore raw

PATCH 1/1 staging: fbtft: remove unused function fbtft_write_gpio16_wr_latched

The function fbtft_write_gpio16_wr_latched is not referenced anywhere in the driver and only contains a stub implementation.

Remove it from the driver.

---
 drivers/staging/fbtft/fbtft-io.c | 7 -------
 drivers/staging/fbtft/fbtft.h    | 1 -
 2 files changed, 8 deletions(-)
drivers/staging/fbtft/fbtft-io.c +0 -7
index de1904a443c2..7d331eba947a 100644
@@ -227,10 +227,3 @@ int fbtft_write_gpio16_wr(struct fbtft_par *par, void *buf, size_t len)
 	return 0;
 }
 EXPORT_SYMBOL(fbtft_write_gpio16_wr);
-
-int fbtft_write_gpio16_wr_latched(struct fbtft_par *par, void *buf, size_t len)
-{
-	dev_err(par->info->device, "%s: function not implemented\n", __func__);
-	return -1;
-}
-EXPORT_SYMBOL(fbtft_write_gpio16_wr_latched);
drivers/staging/fbtft/fbtft.h +0 -1
index 317be17b95c1..c7afb0fd3943 100644
@@ -262,7 +262,6 @@ int fbtft_write_spi_emulate_9(struct fbtft_par *par, void *buf, size_t len);
 int fbtft_read_spi(struct fbtft_par *par, void *buf, size_t len);
 int fbtft_write_gpio8_wr(struct fbtft_par *par, void *buf, size_t len);
 int fbtft_write_gpio16_wr(struct fbtft_par *par, void *buf, size_t len);
-int fbtft_write_gpio16_wr_latched(struct fbtft_par *par, void *buf, size_t len);
 
 /* fbtft-bus.c */
 int fbtft_write_vmem8_bus8(struct fbtft_par *par, size_t offset, size_t len);
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 1 line · Hungyu Lin

The function fbtft_write_gpio16_wr_latched is not referenced anywhere

fbtft_write_gpio16_wr_latched()

Quoted 3 lines

in the driver and only contains a stub implementation.

Remove it from the driver.

Agree, pure code removal is always welcome.

Signature · 2 lines
With Best Regards,
Andy Shevchenko