stalld: make syslog logging opt-in by default
PATCH v2 1/1 stalld: make syslog logging opt-in by default
Previously, stalld enabled syslog output unconditionally with no mechanism to disable it. Users running the daemon from the command line with verbose logging directed to standard error would still generate unwanted syslog traffic.
Change the default behavior to make syslog logging strictly opt-in via the existing command line flag, aligning it with the opt-in nature of other logging destinations. Update the systemd service configuration to explicitly pass this flag, ensuring that default systemd deployments retain their current logging behavior. Finally, introduce a functional test to verify that syslog remains silent when the flag is omitted.
Signed-off-by Wander Lairson Costa <[email protected]>
--- src/stalld.c | 2 +- systemd/stalld.conf | 2 +- tests/functional/test_logging_destinations.sh | 44 ++++++++++++++++++- 3 files changed, 45 insertions(+), 3 deletions(-)
src/stalld.c +1 -1
@@ -48,7 +48,7 @@ const char *version = VERSION;*/ int config_verbose =0 ;int config_write_kmesg =0 ; -int config_log_syslog =1 ; +int config_log_syslog =0 ;int config_log_only =0 ;int config_foreground =0 ;
systemd/stalld.conf +1 -1
@@ -51,7 +51,7 @@ THRESH="-t 20" # --log_syslog # or Nothing (default) # ex: LOGONLY=--log_only -LOGGING= +LOGGING=--log_syslog # Run in the foreground # ex: FG=--foreground
tests/functional/test_logging_destinations.sh +43 -1
54 lines not on this page · raw message
Signature · 1 line
2.54.0