Skip to contentSkip to conversation

staging: greybus: bootrom: replace dev_info with dev_dbg for firmware name

PATCH In review Bentley Blacketer 2 participants 3 messages Apr 30 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 staging: greybus: bootrom: replace dev_info with dev_dbg for firmware name

The original dev_info call was intentionally temporary, with a FIXME comment noting it should be downgraded to dev_dbg once modules with valid VID/PID values were common. Project Ara was cancelled in 2016, so that time has long passed.

Remove the FIXME comment and downgrade to dev_dbg as originally intended.

Tested via code inspection only, as Project Ara hardware is no longer available.

---
Changes in v4:
- Fixed duplicate Signed-off-by
- Fixed missing tab on snprintf line
Changes in v3:
- Fixed author name mismatch
Changes in v2:
- Fixed whitespace issues
- Moved testing note below --- line

 drivers/staging/greybus/bootrom.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/staging/greybus/bootrom.c +1 -6
index 83921d90c..9e0f24d6d 100644
@@ -168,13 +168,8 @@ static int find_firmware(struct gb_bootrom *bootrom, u8 stage)
 		 intf->ddbl1_manufacturer_id, intf->ddbl1_product_id,
 		 intf->vendor_id, intf->product_id);
 
-	// FIXME:
-	// Turn to dev_dbg later after everyone has valid bootloaders with good
-	// ids, but leave this as dev_info for now to make it easier to track
-	// down "empty" vid/pid modules.
-	dev_info(&connection->bundle->dev, "Firmware file '%s' requested\n",
+	dev_dbg(&connection->bundle->dev, "Firmware file '%s' requested\n",
 		 firmware_name);
-
 	rc = request_firmware(&bootrom->fw, firmware_name,
 			      &connection->bundle->dev);
 	if (rc) {
Signature · 1 line
2.54.0
maintainer
#1 lore raw
Quoted 4 lines · Bentley Blacketer

The original dev_info call was intentionally temporary, with a FIXME comment noting it should be downgraded to dev_dbg once modules with valid VID/PID values were common. Project Ara was cancelled in 2016, so that time has long passed.

But other systems are now using greybus, and there was at least 2 different phone models that shipped with this code. So are you sure that there is no user for this anymore?

Quoted 5 lines

Remove the FIXME comment and downgrade to dev_dbg as originally intended.

Tested via code inspection only, as Project Ara hardware is no longer available.

You can run greybus on a beaglebone device today.

Quoted 1 line

You have an extra ' ' in there still.

Quoted 19 lines

---
Changes in v4:
- Fixed duplicate Signed-off-by
- Fixed missing tab on snprintf line
Changes in v3:
- Fixed author name mismatch
Changes in v2:
- Fixed whitespace issues
- Moved testing note below --- line

 drivers/staging/greybus/bootrom.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/staging/greybus/bootrom.c +0 -0
index 83921d90c..9e0f24d6d 100644
@@ -168,13 +168,8 @@ static int find_firmware(struct gb_bootrom *bootrom, u8 stage)
 		 intf->ddbl1_manufacturer_id, intf->ddbl1_product_id,

drivers/staging/greybus/bootrom.c static int find_firmware(struct gb_bootrom *bootrom, u8 stage) · line 177

Quoted 10 lines
drivers/staging/greybus/bootrom.c +1 -6
 		 intf->vendor_id, intf->product_id);
 
-	// FIXME:
-	// Turn to dev_dbg later after everyone has valid bootloaders with good
-	// ids, but leave this as dev_info for now to make it easier to track
-	// down "empty" vid/pid modules.
-	dev_info(&connection->bundle->dev, "Firmware file '%s' requested\n",
+	dev_dbg(&connection->bundle->dev, "Firmware file '%s' requested\n",
 		 firmware_name);
-

Why did you drop the blank line too?

thanks,

greg k-h

A message that is not in the archive (sent off-list or not yet received): CAD3iFGNtqoGUUybvM2kU-hz5vRstukmCY1x9TywF8BairgUypA@mail.gmail.com

maintainer
#3 lore raw
Quoted 2 lines · Bentley Blacketer
Quoted 2 lines

Hi Greg,

<snip>

For some reason this was oddly quoted and in html format which is rejected by the lists. Please fix up your email client settings to properly quote the emails (see the documentation in the kernel for how to do that), and resend it, and I'll be glad to respond.

thanks,

greg k-h