Skip to contentSkip to conversation

staging: rtl8723bs: add braces to if/else statements

PATCH In review Siwanan Bungtong 3 participants 5 messages May 1 – May 4 Staging

lore
Share & tools
lore
#0 lore raw

cover staging: rtl8723bs: add braces to if/else statements

This series adds missing braces to if/else statements in rtl8723bs to comply with the kernel coding style and improve code readability.

No functional changes.

Siwanan Bungtong (2):
staging: rtl8723bs: add braces to if/else arms in rtw_efuse.c
staging: rtl8723bs: add braces to if/else arms in HalBtc8723b1Ant.c

 drivers/staging/rtl8723bs/core/rtw_efuse.c      | 4 ++--
 drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 7 ++++---
 2 files changed, 6 insertions(+), 5 deletions(-)
Signature · 1 line
2.53.0
#1 lore raw

PATCH 1/2 staging: rtl8723bs: add braces to if/else arms in rtw_efuse.c

Add missing braces to if/else statements to comply with kernel coding style and improve readability.

No functional changes.

---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_efuse.c +2 -2
index 099320e4eb50..7600b723fda3 100644
@@ -76,9 +76,9 @@ u16		Address)
 				break;
 		}
 		return rtw_read8(Adapter, EFUSE_CTRL);
-	} else
+	} else {
 		return 0xFF;
-
+	}
 } /* EFUSE_Read1Byte */
 
 /*  11/16/2008 MH Read one byte from real Efuse. */
Signature · 1 line
2.53.0
maintainer
#2 lore raw

Re: [PATCH 1/2] staging: rtl8723bs: add braces to if/else arms in rtw_efuse.c

Quoted 30 lines · Siwanan Bungtong

Add missing braces to if/else statements to comply with kernel coding style and improve readability.

No functional changes.

---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_efuse.c +2 -2
index 099320e4eb50..7600b723fda3 100644
@@ -76,9 +76,9 @@ u16		Address)
 				break;
 		}
 		return rtw_read8(Adapter, EFUSE_CTRL);
-	} else
+	} else {
 		return 0xFF;
-
+	}
 } /* EFUSE_Read1Byte */
 
 /*  11/16/2008 MH Read one byte from real Efuse. */
Signature · 1 line
2.53.0

Does not apply to my tree :(

#3 lore raw

PATCH 2/2 staging: rtl8723bs: add braces to if/else arms in HalBtc8723b1Ant.c

In reply to Siwanan Bungtong

Add missing braces to if/else statements to comply with kernel coding style and improve readability.

No functional changes.

---
 drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c +4 -3
index b3e34f97cfc6..9bef096164fa 100644
@@ -1485,12 +1485,13 @@ static void halbtc8723b1ant_PsTdmaCheckForPowerSaveState(
 	if (lpsMode) {	/*  already under LPS state */
 		if (bNewPsState) {
 			/*  keep state under LPS, do nothing. */
-		} else /*  will leave LPS state, turn off psTdma first */
+		} else { /*  will leave LPS state, turn off psTdma first */
 			halbtc8723b1ant_PsTdma(pBtCoexist, NORMAL_EXEC, false, 0);
+		}
 	} else {						/*  NO PS state */
-		if (bNewPsState) /*  will enter LPS state, turn off psTdma first */
+		if (bNewPsState) { /*  will enter LPS state, turn off psTdma first */
 			halbtc8723b1ant_PsTdma(pBtCoexist, NORMAL_EXEC, false, 0);
-		else {
+		} else {
 			/*  keep state under NO PS state, do nothing. */
 		}
 	}
Signature · 1 line
2.53.0
#4 lore raw
In reply to Siwanan Bungtong
Quoted 5 lines · Siwanan Bungtong

This series adds missing braces to if/else statements in rtl8723bs to comply with the kernel coding style and improve code readability.

No functional changes.

Quoted 8 lines

Siwanan Bungtong (2):
staging: rtl8723bs: add braces to if/else arms in rtw_efuse.c
staging: rtl8723bs: add braces to if/else arms in HalBtc8723b1Ant.c

 drivers/staging/rtl8723bs/core/rtw_efuse.c      | 4 ++--
 drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 7 ++++---
 2 files changed, 6 insertions(+), 5 deletions(-)

This is not applicable to staging-next, please rebase.

Thanks,
Nikolay