Skip to contentSkip to conversation

dts: spacemit: set console baud rate on bpif3

PATCH Applied Conor Dooley 2 participants 5 messages Apr 30 – May 5

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dts: spacemit: set console baud rate on bpif3

From: Conor Dooley <[email protected]>

Because the default console's baud rate is not set, defconfig kernels do not have any serial output on this platform. Set the baud rate to 115200, matching what is used by U-Boot etc on this platform.

Fixes d60d57ab6b2a8 ("riscv: dts: spacemit: add Banana Pi BPI-F3 board device tree")

---
CC: Rob Herring <[email protected]>
CC: Krzysztof Kozlowski <[email protected]>
CC: Conor Dooley <[email protected]>
CC: Yixun Lan <[email protected]>
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

---
 arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts +1 -1
index 5790d927b93db..333ac8ebf3f51 100644
@@ -19,7 +19,7 @@ aliases {
 	};
 
 	chosen {
-		stdout-path = "serial0";
+		stdout-path = "serial0:115200n8";
 	};
 
 	leds {
Signature · 1 line
2.53.0
maintainer
#1 lore raw

Hi Conor,

Quoted 18 lines · Conor Dooley

From: Conor Dooley <[email protected]>

Because the default console's baud rate is not set, defconfig kernels do not have any serial output on this platform. Set the baud rate to 115200, matching what is used by U-Boot etc on this platform.

Fixes d60d57ab6b2a8 ("riscv: dts: spacemit: add Banana Pi BPI-F3 board device tree")

---
CC: Rob Herring <[email protected]>
CC: Krzysztof Kozlowski <[email protected]>
CC: Conor Dooley <[email protected]>
CC: Yixun Lan <[email protected]>
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

Quoted 2 lines
---
 arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 2 +-

Looks good to me, but I think the fix should also apply to other boards, so do you want to fix other dts? I'd be fine if you keep it to BPI-F3 only

Quoted 18 lines
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts +1 -1
index 5790d927b93db..333ac8ebf3f51 100644
@@ -19,7 +19,7 @@ aliases {
 	};
 
 	chosen {
-		stdout-path = "serial0";
+		stdout-path = "serial0:115200n8";
 	};
 
 	leds {
Signature · 1 line
2.53.0
Signature · 1 line
Yixun Lan (dlan)
#2 lore raw
Quoted 24 lines · Yixun Lan

Hi Conor,

Quoted 18 lines · Conor Dooley

From: Conor Dooley <[email protected]>

Because the default console's baud rate is not set, defconfig kernels do not have any serial output on this platform. Set the baud rate to 115200, matching what is used by U-Boot etc on this platform.

Fixes d60d57ab6b2a8 ("riscv: dts: spacemit: add Banana Pi BPI-F3 board device tree")

---
CC: Rob Herring <[email protected]>
CC: Krzysztof Kozlowski <[email protected]>
CC: Conor Dooley <[email protected]>
CC: Yixun Lan <[email protected]>
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

Quoted 2 lines
---
 arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 2 +-
Quoted 2 lines

Looks good to me, but I think the fix should also apply to other boards, so do you want to fix other dts? I'd be fine if you keep it to BPI-F3 only

I don't have any other boards, didn't/don't want to make the change elsewhere where I cannot test it.

Quoted 23 lines
Quoted 20 lines

 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts +1 -1
index 5790d927b93db..333ac8ebf3f51 100644
@@ -19,7 +19,7 @@ aliases {
 	};
 
 	chosen {
-		stdout-path = "serial0";
+		stdout-path = "serial0:115200n8";
 	};
 
 	leds {
Signature · 1 line
2.53.0
Signature · 1 line
Yixun Lan (dlan)
maintainer Reviewed-by on v1 1/1
#3 lore raw
In reply to Conor Dooley

Hi Conor,

Quoted 9 lines · Conor Dooley

From: Conor Dooley <[email protected]>

Because the default console's baud rate is not set, defconfig kernels do not have any serial output on this platform. Set the baud rate to 115200, matching what is used by U-Boot etc on this platform.

Fixes d60d57ab6b2a8 ("riscv: dts: spacemit: add Banana Pi BPI-F3 board device tree")
Signature · 1 line
Yixun Lan (dlan)
maintainer Applied
#4 lore raw
In reply to Conor Dooley
Quoted 5 lines · Conor Dooley

Because the default console's baud rate is not set, defconfig kernels do not have any serial output on this platform. Set the baud rate to 115200, matching what is used by U-Boot etc on this platform.

Applied, thanks!

[1/1] dts: spacemit: set console baud rate on bpif3

      https://github.com/spacemit-com/linux/commit/24c12ca43b12c104389d9a159207d0b25779d0af

Best regards,

Signature · 1 line
Yixun Lan <[email protected]>