Skip to contentSkip to conversation

lib/igt_kms: Add support for the BACKGROUND_COLOR property.

PATCH In review Maarten Lankhorst 6 participants 19 messages May 5 – May 25 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 lib/igt_kms: Add support for the BACKGROUND_COLOR property.

The background color is a 64-bits property that contains the ARGB values of the background with 16 bits for each component.

Add support for the BACKGROUND_COLOR property, and set to pitch black as the default.

---
 lib/igt_kms.c | 4 ++++
 lib/igt_kms.h | 1 +
 2 files changed, 5 insertions(+)
lib/igt_kms.c +4 -0
index 99fc9fa05c..b70aefe697 100644
@@ -731,6 +731,7 @@ const char * const igt_crtc_prop_names[IGT_NUM_CRTC_PROPS] = {
 	[IGT_CRTC_VRR_ENABLED] = "VRR_ENABLED",
 	[IGT_CRTC_SCALING_FILTER] = "SCALING_FILTER",
 	[IGT_CRTC_SHARPNESS_STRENGTH] = "SHARPNESS_STRENGTH",
+	[IGT_CRTC_BACKGROUND_COLOR] = "BACKGROUND_COLOR",
 };
 
 const char * const igt_connector_prop_names[IGT_NUM_CONNECTOR_PROPS] = {
@@ -2737,6 +2738,9 @@ static void igt_crtc_reset(igt_crtc_t *crtc)
 	if (igt_crtc_has_prop(crtc, IGT_CRTC_SHARPNESS_STRENGTH))
 		igt_crtc_set_prop_value(crtc, IGT_CRTC_SHARPNESS_STRENGTH, 0);
 
+	if (igt_crtc_has_prop(crtc, IGT_CRTC_BACKGROUND_COLOR))
+		igt_crtc_set_prop_value(crtc, IGT_CRTC_BACKGROUND_COLOR, 0xffff000000000000ULL);
+
 	crtc->out_fence_fd = -1;
 }
 
lib/igt_kms.h +1 -0
index a58cb5cd34..71f908d4f5 100644
@@ -165,6 +165,7 @@ enum igt_atomic_crtc_properties {
        IGT_CRTC_VRR_ENABLED,
        IGT_CRTC_SCALING_FILTER,
        IGT_CRTC_SHARPNESS_STRENGTH,
+       IGT_CRTC_BACKGROUND_COLOR,
        IGT_NUM_CRTC_PROPS
 };
 
Signature · 1 line
2.53.0
#1 lore raw

PATCH 2/4 includes: Remove DRM_XE_VM_BIND_FLAG_DECOMPRESS

This is already defined in xe_drm.h too.

---
 include/drm-uapi-experimental/intel_drm_local.h | 2 --
 1 file changed, 2 deletions(-)
include/drm-uapi-experimental/intel_drm_local.h +0 -2
index 10cc011f7f..b48c9e2195 100644
@@ -20,8 +20,6 @@ extern "C" {
  * clean these up when kernel uapi headers are sync'd.
  */
 
-#define DRM_XE_VM_BIND_FLAG_DECOMPRESS	(1 << 7)
-
 #if defined(__cplusplus)
 }
 #endif
Signature · 1 line
2.53.0
Reviewed-by on v1 2/4
#2 lore raw

Re: [PATCH i-g-t 2/4] includes: Remove DRM_XE_VM_BIND_FLAG_DECOMPRESS

Hi Maarten,

Quoted 3 lines · Maarten Lankhorst

This is already defined in xe_drm.h too.

LGTM

Regards,
Kamil

Quoted 20 lines
---
 include/drm-uapi-experimental/intel_drm_local.h | 2 --
 1 file changed, 2 deletions(-)
include/drm-uapi-experimental/intel_drm_local.h +0 -2
index 10cc011f7f..b48c9e2195 100644
@@ -20,8 +20,6 @@ extern "C" {
  * clean these up when kernel uapi headers are sync'd.
  */
 
-#define DRM_XE_VM_BIND_FLAG_DECOMPRESS	(1 << 7)
-
 #if defined(__cplusplus)
 }
 #endif
Signature · 1 line
2.53.0
#3 lore raw

PATCH 3/4 drm-uapi: Update drm_mode.h to latest linux upstream.

In reply to Maarten Lankhorst

Take the drm_mode.h from v7.1-rc2 to get all the
background property macros.

---
 include/drm-uapi/drm_mode.h | 193 ++++++++++++++++++++++++++++++++++--
 include/linux_scaffold.h    |   2 +
 2 files changed, 188 insertions(+), 7 deletions(-)
include/drm-uapi/drm_mode.h +186 -7
index de10ce859f..8513ce24f3 100644
@@ -166,6 +166,10 @@ extern "C" {
 #define DRM_MODE_LINK_STATUS_GOOD	0
 #define DRM_MODE_LINK_STATUS_BAD	1
 
+/* Panel type property */
+#define DRM_MODE_PANEL_TYPE_UNKNOWN	0
+#define DRM_MODE_PANEL_TYPE_OLED	1
+
 /*
  * DRM_MODE_ROTATE_<degrees>
  *
@@ -895,31 +899,48 @@ enum drm_colorop_type {
 	/**
 	 * @DRM_COLOROP_1D_CURVE:
 	 *
+	 * enum string "1D Curve"
+	 *
 	 * A 1D curve that is being applied to all color channels. The
-	 * curve is specified via tha CURVE_1D_TYPE colorop property.
+	 * curve is specified via the CURVE_1D_TYPE colorop property.
 	 */
 	DRM_COLOROP_1D_CURVE,
 
 	/**
 	 * @DRM_COLOROP_1D_LUT:
 	 *
+	 * enum string "1D LUT"
+	 *
 	 * A simple 1D LUT of uniformly spaced &drm_color_lut32 entries,
-	 * packed into a blob via the DATA property. The driver's expected
-	 * LUT size is advertised via the SIZE property.
+	 * packed into a blob via the DATA property. The driver's
+	 * expected LUT size is advertised via the SIZE property.
+	 *
+	 * The DATA blob is an array of struct drm_color_lut32 with size
+	 * of "size".
 	 */
 	DRM_COLOROP_1D_LUT,
 
 	/**
 	 * @DRM_COLOROP_CTM_3X4:
 	 *
+	 * enum string "3x4 Matrix"
+	 *
 	 * A 3x4 matrix. Its values are specified via the
 	 * &drm_color_ctm_3x4 struct provided via the DATA property.
+	 *
+	 * The DATA blob is a float[12]:
+	 * out   matrix          in
+	 * | R |   | 0  1  2  3  |   | R |
+	 * | G | = | 4  5  6  7  | x | G |
+	 * | B |   | 8  9  10 12 |   | B |
 	 */
 	DRM_COLOROP_CTM_3X4,
 
 	/**
 	 * @DRM_COLOROP_MULTIPLIER:
 	 *
+	 * enum string "Multiplier"
+	 *
 	 * A simple multiplier, applied to all color values. The
 	 * multiplier is specified as a S31.32 via the MULTIPLIER
 	 * property.
@@ -929,16 +950,28 @@ enum drm_colorop_type {
 	/**
 	 * @DRM_COLOROP_3D_LUT:
 	 *
-	 * A 3D LUT of &drm_color_lut entries,
+	 * enum string "3D LUT"
+	 *
+	 * A 3D LUT of &drm_color_lut32 entries,
 	 * packed into a blob via the DATA property. The driver's expected
-	 * LUT size is advertised via the SIZE property.
+	 * LUT size is advertised via the SIZE property, i.e., a 3D LUT with
+	 * 17x17x17 entries will have SIZE set to 17.
+	 *
+	 * The DATA blob is a 3D array of struct drm_color_lut32 with dimension
+	 * length of "size".
+	 * The LUT elements are traversed like so:
+	 *
+	 *   for B in range 0..n
+	 *     for G in range 0..n
+	 *       for R in range 0..n
+	 *        index = R + n * (G + n * B)
+	 *         color = lut3d[index]
 	 */
 	DRM_COLOROP_3D_LUT,
 };
 
 /**
  * enum drm_colorop_lut3d_interpolation_type - type of 3DLUT interpolation
- *
  */
 enum drm_colorop_lut3d_interpolation_type {
 	/**
@@ -949,6 +982,19 @@ enum drm_colorop_lut3d_interpolation_type {
 	DRM_COLOROP_LUT3D_INTERPOLATION_TETRAHEDRAL,
 };
 
+/**
+ * enum drm_colorop_lut1d_interpolation_type - type of interpolation for 1D LUTs
+ */
+enum drm_colorop_lut1d_interpolation_type {
+	/**
+	 * @DRM_COLOROP_LUT1D_INTERPOLATION_LINEAR:
+	 *
+	 * Linear interpolation. Values between points of the LUT will be
+	 * linearly interpolated.
+	 */
+	DRM_COLOROP_LUT1D_INTERPOLATION_LINEAR,
+};
+
 /**
  * struct drm_plane_size_hint - Plane size hints
  * @width: The width of the plane in pixel
@@ -1054,6 +1100,14 @@ struct hdr_output_metadata {
  * Request that the kernel sends back a vblank event (see
  * struct drm_event_vblank) with the &DRM_EVENT_FLIP_COMPLETE type when the
  * page-flip is done.
+ *
+ * When used with atomic uAPI, one event will be delivered per CRTC included in
+ * the atomic commit. A CRTC is included in an atomic commit if one of its
+ * properties is set, or if a property is set on a connector or plane linked
+ * via the CRTC_ID property to the CRTC. At least one CRTC must be included,
+ * and all pulled in CRTCs must be either previously or newly powered on (in
+ * other words, a powered off CRTC which stays off cannot be included in the
+ * atomic commit).
  */
 #define DRM_MODE_PAGE_FLIP_EVENT 0x01
 /**
@@ -1150,7 +1204,7 @@ struct drm_mode_crtc_page_flip_target {
  * struct drm_mode_create_dumb - Create a KMS dumb buffer for scanout.
  * @height: buffer height in pixels
  * @width: buffer width in pixels
- * @bpp: bits per pixel
+ * @bpp: color mode
  * @flags: must be zero
  * @handle: buffer object handle
  * @pitch: number of bytes between two consecutive lines
@@ -1158,6 +1212,54 @@ struct drm_mode_crtc_page_flip_target {
  *
  * User-space fills @height, @width, @bpp and @flags. If the IOCTL succeeds,
  * the kernel fills @handle, @pitch and @size.
+ *
+ * The value of @bpp is a color-mode number describing a specific format
+ * or a variant thereof. The value often corresponds to the number of bits
+ * per pixel for most modes, although there are exceptions. Each color mode
+ * maps to a DRM format plus a number of modes with similar pixel layout.
+ * Framebuffer layout is always linear.
+ *
+ * Support for all modes and formats is optional. Even if dumb-buffer
+ * creation with a certain color mode succeeds, it is not guaranteed that
+ * the DRM driver supports any of the related formats. Most drivers support
+ * a color mode of 32 with a format of DRM_FORMAT_XRGB8888 on their primary
+ * plane.
+ *
+ * +------------+------------------------+------------------------+
+ * | Color mode | Framebuffer format     | Compatible formats     |
+ * +============+========================+========================+
+ * |     32     |  * DRM_FORMAT_XRGB8888 |  * DRM_FORMAT_BGRX8888 |
+ * |            |                        |  * DRM_FORMAT_RGBX8888 |
+ * |            |                        |  * DRM_FORMAT_XBGR8888 |
+ * +------------+------------------------+------------------------+
+ * |     24     |  * DRM_FORMAT_RGB888   |  * DRM_FORMAT_BGR888   |
+ * +------------+------------------------+------------------------+
+ * |     16     |  * DRM_FORMAT_RGB565   |  * DRM_FORMAT_BGR565   |
+ * +------------+------------------------+------------------------+
+ * |     15     |  * DRM_FORMAT_XRGB1555 |  * DRM_FORMAT_BGRX1555 |
+ * |            |                        |  * DRM_FORMAT_RGBX1555 |
+ * |            |                        |  * DRM_FORMAT_XBGR1555 |
+ * +------------+------------------------+------------------------+
+ * |      8     |  * DRM_FORMAT_C8       |  * DRM_FORMAT_D8       |
+ * |            |                        |  * DRM_FORMAT_R8       |
+ * +------------+------------------------+------------------------+
+ * |      4     |  * DRM_FORMAT_C4       |  * DRM_FORMAT_D4       |
+ * |            |                        |  * DRM_FORMAT_R4       |
+ * +------------+------------------------+------------------------+
+ * |      2     |  * DRM_FORMAT_C2       |  * DRM_FORMAT_D2       |
+ * |            |                        |  * DRM_FORMAT_R2       |
+ * +------------+------------------------+------------------------+
+ * |      1     |  * DRM_FORMAT_C1       |  * DRM_FORMAT_D1       |
+ * |            |                        |  * DRM_FORMAT_R1       |
+ * +------------+------------------------+------------------------+
+ *
+ * Color modes of 10, 12, 15, 30 and 64 are only supported for use by
+ * legacy user space. Please don't use them in new code. Other modes
+ * are not support.
+ *
+ * Do not attempt to allocate anything but linear framebuffer memory
+ * with single-plane RGB data. Allocation of other framebuffer
+ * layouts requires dedicated ioctls in the respective DRM driver.
  */
 struct drm_mode_create_dumb {
 	__u32 height;
@@ -1447,6 +1549,83 @@ struct drm_mode_closefb {
 	__u32 pad;
 };
 
+/*
+ * Put 16-bit ARGB values into a standard 64-bit representation that can be
+ * used for ioctl parameters, inter-driver communication, etc.
+ *
+ * If the component values being provided contain less than 16 bits of
+ * precision, use a conversion ratio to get a better color approximation.
+ * The ratio is computed as (2^16 - 1) / (2^bpc - 1), where bpc and 16 are
+ * the input and output precision, respectively.
+ * Also note bpc must be greater than 0.
+ */
+#define __DRM_ARGB64_PREP(c, shift)					\
+	(((__u64)(c) & __GENMASK(15, 0)) << (shift))
+
+#define __DRM_ARGB64_PREP_BPC(c, shift, bpc)				\
+({									\
+	__u16 mask = __GENMASK((bpc) - 1, 0);				\
+	__u16 conv = __KERNEL_DIV_ROUND_CLOSEST((mask & (c)) *		\
+						__GENMASK(15, 0), mask);\
+	__DRM_ARGB64_PREP(conv, shift);					\
+})
+
+#define DRM_ARGB64_PREP(alpha, red, green, blue)			\
+(									\
+	__DRM_ARGB64_PREP(alpha, 48) |					\
+	__DRM_ARGB64_PREP(red,   32) |					\
+	__DRM_ARGB64_PREP(green, 16) |					\
+	__DRM_ARGB64_PREP(blue,   0)					\
+)
+
+#define DRM_ARGB64_PREP_BPC(alpha, red, green, blue, bpc)		\
+({									\
+	__typeof__(bpc) __bpc = bpc;					\
+	__DRM_ARGB64_PREP_BPC(alpha, 48, __bpc) |			\
+	__DRM_ARGB64_PREP_BPC(red,   32, __bpc) |			\
+	__DRM_ARGB64_PREP_BPC(green, 16, __bpc) |			\
+	__DRM_ARGB64_PREP_BPC(blue,   0, __bpc);			\
+})
+
+/*
+ * Extract the specified color component from a standard 64-bit ARGB value.
+ *
+ * If the requested precision is less than 16 bits, make use of a conversion
+ * ratio calculated as (2^bpc - 1) / (2^16 - 1), where bpc and 16 are the
+ * output and input precision, respectively.
+ *
+ * If speed is more important than accuracy, use DRM_ARGB64_GET*_BPCS()
+ * instead of DRM_ARGB64_GET*_BPC() in order to replace the expensive
+ * division with a simple bit right-shift operation.
+ */
+#define __DRM_ARGB64_GET(c, shift)					\
+	((__u16)(((__u64)(c) >> (shift)) & __GENMASK(15, 0)))
+
+#define __DRM_ARGB64_GET_BPC(c, shift, bpc)				\
+({									\
+	__u16 comp = __DRM_ARGB64_GET(c, shift);			\
+	__KERNEL_DIV_ROUND_CLOSEST(comp * __GENMASK((bpc) - 1, 0),	\
+				   __GENMASK(15, 0));			\
+})
+
+#define __DRM_ARGB64_GET_BPCS(c, shift, bpc)				\
+	(__DRM_ARGB64_GET(c, shift) >> (16 - (bpc)))
+
+#define DRM_ARGB64_GETA(c)		__DRM_ARGB64_GET(c, 48)
+#define DRM_ARGB64_GETR(c)		__DRM_ARGB64_GET(c, 32)
+#define DRM_ARGB64_GETG(c)		__DRM_ARGB64_GET(c, 16)
+#define DRM_ARGB64_GETB(c)		__DRM_ARGB64_GET(c, 0)
+
+#define DRM_ARGB64_GETA_BPC(c, bpc)	__DRM_ARGB64_GET_BPC(c, 48, bpc)
+#define DRM_ARGB64_GETR_BPC(c, bpc)	__DRM_ARGB64_GET_BPC(c, 32, bpc)
+#define DRM_ARGB64_GETG_BPC(c, bpc)	__DRM_ARGB64_GET_BPC(c, 16, bpc)
+#define DRM_ARGB64_GETB_BPC(c, bpc)	__DRM_ARGB64_GET_BPC(c, 0, bpc)
+
+#define DRM_ARGB64_GETA_BPCS(c, bpc)	__DRM_ARGB64_GET_BPCS(c, 48, bpc)
+#define DRM_ARGB64_GETR_BPCS(c, bpc)	__DRM_ARGB64_GET_BPCS(c, 32, bpc)
+#define DRM_ARGB64_GETG_BPCS(c, bpc)	__DRM_ARGB64_GET_BPCS(c, 16, bpc)
+#define DRM_ARGB64_GETB_BPCS(c, bpc)	__DRM_ARGB64_GET_BPCS(c, 0, bpc)
+
 #if defined(__cplusplus)
 }
 #endif
include/linux_scaffold.h +2 -0
index 0c970c8607..d5dba8e63e 100644
@@ -47,6 +47,8 @@ static inline s64 sign_extend64(u64 value, int index)
 	(((~_ULL(0)) - (_ULL(1) << (l)) + 1) & \
 	(~_ULL(0) >> (BITS_PER_LONG_LONG - 1 - (h))))
 
+#define __GENMASK GENMASK
+
 #define BITS_PER_BYTE 8
 #define BITS_PER_TYPE(t) (sizeof(t) * BITS_PER_BYTE)
 #define BITS_PER_LONG BITS_PER_TYPE(long)
Signature · 1 line
2.53.0
#4 lore raw

Re: [PATCH i-g-t 3/4] drm-uapi: Update drm_mode.h to latest linux upstream.

Hi Maarten,
On 2026-05-05 at 21:44:22 +0200, Maarten Lankhorst wrote:

Please remove dot from subject, also add a commit hash with which you are syncing, something like:

[PATCH i-g-t 3/4] drm-uapi/drm_mode: sync with drm-next commit a1b6cf8e5e7e

Quoted 2 lines

Take the drm_mode.h from v7.1-rc2 to get all the
background property macros.

Add in description list with which commits from drm-next you
are syncing, for example see https://patchwork.freedesktop.org/patch/723725/?series=166234&rev=1
drm-uapi/panthor: sync with kernel 5731bca6a656

so here write something like:

Sync drm_mode.h uapi with drm-next up to commit a1b6cf8e5e7e, this will bring following changes:

a1b6cf8e5e7e ("drm: uapi: Use SPDX in DRM core uAPI headers") 4c684596cde4 ("drm: Add CRTC background color property")
...
follow like above up to last new commit.

If you are syncing with drm-tip (becuase some changes still do not landed in drm-next), I suggest make two commits, or one in which you write in description which one is from which tree:

Sync with drm-tip commit HASH, which brings:
...commits

and with changes from drm-next:
...commits

+cc Adrián Larumbe <[email protected]>
+cc other maintainers

Regards,
Kamil

Quoted 305 lines
---
 include/drm-uapi/drm_mode.h | 193 ++++++++++++++++++++++++++++++++++--
 include/linux_scaffold.h    |   2 +
 2 files changed, 188 insertions(+), 7 deletions(-)
include/drm-uapi/drm_mode.h +186 -7
index de10ce859f..8513ce24f3 100644
@@ -166,6 +166,10 @@ extern "C" {
 #define DRM_MODE_LINK_STATUS_GOOD	0
 #define DRM_MODE_LINK_STATUS_BAD	1
 
+/* Panel type property */
+#define DRM_MODE_PANEL_TYPE_UNKNOWN	0
+#define DRM_MODE_PANEL_TYPE_OLED	1
+
 /*
  * DRM_MODE_ROTATE_<degrees>
  *
@@ -895,31 +899,48 @@ enum drm_colorop_type {
 	/**
 	 * @DRM_COLOROP_1D_CURVE:
 	 *
+	 * enum string "1D Curve"
+	 *
 	 * A 1D curve that is being applied to all color channels. The
-	 * curve is specified via tha CURVE_1D_TYPE colorop property.
+	 * curve is specified via the CURVE_1D_TYPE colorop property.
 	 */
 	DRM_COLOROP_1D_CURVE,
 
 	/**
 	 * @DRM_COLOROP_1D_LUT:
 	 *
+	 * enum string "1D LUT"
+	 *
 	 * A simple 1D LUT of uniformly spaced &drm_color_lut32 entries,
-	 * packed into a blob via the DATA property. The driver's expected
-	 * LUT size is advertised via the SIZE property.
+	 * packed into a blob via the DATA property. The driver's
+	 * expected LUT size is advertised via the SIZE property.
+	 *
+	 * The DATA blob is an array of struct drm_color_lut32 with size
+	 * of "size".
 	 */
 	DRM_COLOROP_1D_LUT,
 
 	/**
 	 * @DRM_COLOROP_CTM_3X4:
 	 *
+	 * enum string "3x4 Matrix"
+	 *
 	 * A 3x4 matrix. Its values are specified via the
 	 * &drm_color_ctm_3x4 struct provided via the DATA property.
+	 *
+	 * The DATA blob is a float[12]:
+	 * out   matrix          in
+	 * | R |   | 0  1  2  3  |   | R |
+	 * | G | = | 4  5  6  7  | x | G |
+	 * | B |   | 8  9  10 12 |   | B |
 	 */
 	DRM_COLOROP_CTM_3X4,
 
 	/**
 	 * @DRM_COLOROP_MULTIPLIER:
 	 *
+	 * enum string "Multiplier"
+	 *
 	 * A simple multiplier, applied to all color values. The
 	 * multiplier is specified as a S31.32 via the MULTIPLIER
 	 * property.
@@ -929,16 +950,28 @@ enum drm_colorop_type {
 	/**
 	 * @DRM_COLOROP_3D_LUT:
 	 *
-	 * A 3D LUT of &drm_color_lut entries,
+	 * enum string "3D LUT"
+	 *
+	 * A 3D LUT of &drm_color_lut32 entries,
 	 * packed into a blob via the DATA property. The driver's expected
-	 * LUT size is advertised via the SIZE property.
+	 * LUT size is advertised via the SIZE property, i.e., a 3D LUT with
+	 * 17x17x17 entries will have SIZE set to 17.
+	 *
+	 * The DATA blob is a 3D array of struct drm_color_lut32 with dimension
+	 * length of "size".
+	 * The LUT elements are traversed like so:
+	 *
+	 *   for B in range 0..n
+	 *     for G in range 0..n
+	 *       for R in range 0..n
+	 *        index = R + n * (G + n * B)
+	 *         color = lut3d[index]
 	 */
 	DRM_COLOROP_3D_LUT,
 };
 
 /**
  * enum drm_colorop_lut3d_interpolation_type - type of 3DLUT interpolation
- *
  */
 enum drm_colorop_lut3d_interpolation_type {
 	/**
@@ -949,6 +982,19 @@ enum drm_colorop_lut3d_interpolation_type {
 	DRM_COLOROP_LUT3D_INTERPOLATION_TETRAHEDRAL,
 };
 
+/**
+ * enum drm_colorop_lut1d_interpolation_type - type of interpolation for 1D LUTs
+ */
+enum drm_colorop_lut1d_interpolation_type {
+	/**
+	 * @DRM_COLOROP_LUT1D_INTERPOLATION_LINEAR:
+	 *
+	 * Linear interpolation. Values between points of the LUT will be
+	 * linearly interpolated.
+	 */
+	DRM_COLOROP_LUT1D_INTERPOLATION_LINEAR,
+};
+
 /**
  * struct drm_plane_size_hint - Plane size hints
  * @width: The width of the plane in pixel
@@ -1054,6 +1100,14 @@ struct hdr_output_metadata {
  * Request that the kernel sends back a vblank event (see
  * struct drm_event_vblank) with the &DRM_EVENT_FLIP_COMPLETE type when the
  * page-flip is done.
+ *
+ * When used with atomic uAPI, one event will be delivered per CRTC included in
+ * the atomic commit. A CRTC is included in an atomic commit if one of its
+ * properties is set, or if a property is set on a connector or plane linked
+ * via the CRTC_ID property to the CRTC. At least one CRTC must be included,
+ * and all pulled in CRTCs must be either previously or newly powered on (in
+ * other words, a powered off CRTC which stays off cannot be included in the
+ * atomic commit).
  */
 #define DRM_MODE_PAGE_FLIP_EVENT 0x01
 /**
@@ -1150,7 +1204,7 @@ struct drm_mode_crtc_page_flip_target {
  * struct drm_mode_create_dumb - Create a KMS dumb buffer for scanout.
  * @height: buffer height in pixels
  * @width: buffer width in pixels
- * @bpp: bits per pixel
+ * @bpp: color mode
  * @flags: must be zero
  * @handle: buffer object handle
  * @pitch: number of bytes between two consecutive lines
@@ -1158,6 +1212,54 @@ struct drm_mode_crtc_page_flip_target {
  *
  * User-space fills @height, @width, @bpp and @flags. If the IOCTL succeeds,
  * the kernel fills @handle, @pitch and @size.
+ *
+ * The value of @bpp is a color-mode number describing a specific format
+ * or a variant thereof. The value often corresponds to the number of bits
+ * per pixel for most modes, although there are exceptions. Each color mode
+ * maps to a DRM format plus a number of modes with similar pixel layout.
+ * Framebuffer layout is always linear.
+ *
+ * Support for all modes and formats is optional. Even if dumb-buffer
+ * creation with a certain color mode succeeds, it is not guaranteed that
+ * the DRM driver supports any of the related formats. Most drivers support
+ * a color mode of 32 with a format of DRM_FORMAT_XRGB8888 on their primary
+ * plane.
+ *
+ * +------------+------------------------+------------------------+
+ * | Color mode | Framebuffer format     | Compatible formats     |
+ * +============+========================+========================+
+ * |     32     |  * DRM_FORMAT_XRGB8888 |  * DRM_FORMAT_BGRX8888 |
+ * |            |                        |  * DRM_FORMAT_RGBX8888 |
+ * |            |                        |  * DRM_FORMAT_XBGR8888 |
+ * +------------+------------------------+------------------------+
+ * |     24     |  * DRM_FORMAT_RGB888   |  * DRM_FORMAT_BGR888   |
+ * +------------+------------------------+------------------------+
+ * |     16     |  * DRM_FORMAT_RGB565   |  * DRM_FORMAT_BGR565   |
+ * +------------+------------------------+------------------------+
+ * |     15     |  * DRM_FORMAT_XRGB1555 |  * DRM_FORMAT_BGRX1555 |
+ * |            |                        |  * DRM_FORMAT_RGBX1555 |
+ * |            |                        |  * DRM_FORMAT_XBGR1555 |
+ * +------------+------------------------+------------------------+
+ * |      8     |  * DRM_FORMAT_C8       |  * DRM_FORMAT_D8       |
+ * |            |                        |  * DRM_FORMAT_R8       |
+ * +------------+------------------------+------------------------+
+ * |      4     |  * DRM_FORMAT_C4       |  * DRM_FORMAT_D4       |
+ * |            |                        |  * DRM_FORMAT_R4       |
+ * +------------+------------------------+------------------------+
+ * |      2     |  * DRM_FORMAT_C2       |  * DRM_FORMAT_D2       |
+ * |            |                        |  * DRM_FORMAT_R2       |
+ * +------------+------------------------+------------------------+
+ * |      1     |  * DRM_FORMAT_C1       |  * DRM_FORMAT_D1       |
+ * |            |                        |  * DRM_FORMAT_R1       |
+ * +------------+------------------------+------------------------+
+ *
+ * Color modes of 10, 12, 15, 30 and 64 are only supported for use by
+ * legacy user space. Please don't use them in new code. Other modes
+ * are not support.
+ *
+ * Do not attempt to allocate anything but linear framebuffer memory
+ * with single-plane RGB data. Allocation of other framebuffer
+ * layouts requires dedicated ioctls in the respective DRM driver.
  */
 struct drm_mode_create_dumb {
 	__u32 height;
@@ -1447,6 +1549,83 @@ struct drm_mode_closefb {
 	__u32 pad;
 };
 
+/*
+ * Put 16-bit ARGB values into a standard 64-bit representation that can be
+ * used for ioctl parameters, inter-driver communication, etc.
+ *
+ * If the component values being provided contain less than 16 bits of
+ * precision, use a conversion ratio to get a better color approximation.
+ * The ratio is computed as (2^16 - 1) / (2^bpc - 1), where bpc and 16 are
+ * the input and output precision, respectively.
+ * Also note bpc must be greater than 0.
+ */
+#define __DRM_ARGB64_PREP(c, shift)					\
+	(((__u64)(c) & __GENMASK(15, 0)) << (shift))
+
+#define __DRM_ARGB64_PREP_BPC(c, shift, bpc)				\
+({									\
+	__u16 mask = __GENMASK((bpc) - 1, 0);				\
+	__u16 conv = __KERNEL_DIV_ROUND_CLOSEST((mask & (c)) *		\
+						__GENMASK(15, 0), mask);\
+	__DRM_ARGB64_PREP(conv, shift);					\
+})
+
+#define DRM_ARGB64_PREP(alpha, red, green, blue)			\
+(									\
+	__DRM_ARGB64_PREP(alpha, 48) |					\
+	__DRM_ARGB64_PREP(red,   32) |					\
+	__DRM_ARGB64_PREP(green, 16) |					\
+	__DRM_ARGB64_PREP(blue,   0)					\
+)
+
+#define DRM_ARGB64_PREP_BPC(alpha, red, green, blue, bpc)		\
+({									\
+	__typeof__(bpc) __bpc = bpc;					\
+	__DRM_ARGB64_PREP_BPC(alpha, 48, __bpc) |			\
+	__DRM_ARGB64_PREP_BPC(red,   32, __bpc) |			\
+	__DRM_ARGB64_PREP_BPC(green, 16, __bpc) |			\
+	__DRM_ARGB64_PREP_BPC(blue,   0, __bpc);			\
+})
+
+/*
+ * Extract the specified color component from a standard 64-bit ARGB value.
+ *
+ * If the requested precision is less than 16 bits, make use of a conversion
+ * ratio calculated as (2^bpc - 1) / (2^16 - 1), where bpc and 16 are the
+ * output and input precision, respectively.
+ *
+ * If speed is more important than accuracy, use DRM_ARGB64_GET*_BPCS()
+ * instead of DRM_ARGB64_GET*_BPC() in order to replace the expensive
+ * division with a simple bit right-shift operation.
+ */
+#define __DRM_ARGB64_GET(c, shift)					\
+	((__u16)(((__u64)(c) >> (shift)) & __GENMASK(15, 0)))
+
+#define __DRM_ARGB64_GET_BPC(c, shift, bpc)				\
+({									\
+	__u16 comp = __DRM_ARGB64_GET(c, shift);			\
+	__KERNEL_DIV_ROUND_CLOSEST(comp * __GENMASK((bpc) - 1, 0),	\
+				   __GENMASK(15, 0));			\
+})
+
+#define __DRM_ARGB64_GET_BPCS(c, shift, bpc)				\
+	(__DRM_ARGB64_GET(c, shift) >> (16 - (bpc)))
+
+#define DRM_ARGB64_GETA(c)		__DRM_ARGB64_GET(c, 48)
+#define DRM_ARGB64_GETR(c)		__DRM_ARGB64_GET(c, 32)
+#define DRM_ARGB64_GETG(c)		__DRM_ARGB64_GET(c, 16)
+#define DRM_ARGB64_GETB(c)		__DRM_ARGB64_GET(c, 0)
+
+#define DRM_ARGB64_GETA_BPC(c, bpc)	__DRM_ARGB64_GET_BPC(c, 48, bpc)
+#define DRM_ARGB64_GETR_BPC(c, bpc)	__DRM_ARGB64_GET_BPC(c, 32, bpc)
+#define DRM_ARGB64_GETG_BPC(c, bpc)	__DRM_ARGB64_GET_BPC(c, 16, bpc)
+#define DRM_ARGB64_GETB_BPC(c, bpc)	__DRM_ARGB64_GET_BPC(c, 0, bpc)
+
+#define DRM_ARGB64_GETA_BPCS(c, bpc)	__DRM_ARGB64_GET_BPCS(c, 48, bpc)
+#define DRM_ARGB64_GETR_BPCS(c, bpc)	__DRM_ARGB64_GET_BPCS(c, 32, bpc)
+#define DRM_ARGB64_GETG_BPCS(c, bpc)	__DRM_ARGB64_GET_BPCS(c, 16, bpc)
+#define DRM_ARGB64_GETB_BPCS(c, bpc)	__DRM_ARGB64_GET_BPCS(c, 0, bpc)
+
 #if defined(__cplusplus)
 }
 #endif
include/linux_scaffold.h +2 -0
index 0c970c8607..d5dba8e63e 100644
@@ -47,6 +47,8 @@ static inline s64 sign_extend64(u64 value, int index)
 	(((~_ULL(0)) - (_ULL(1) << (l)) + 1) & \
 	(~_ULL(0) >> (BITS_PER_LONG_LONG - 1 - (h))))
 
+#define __GENMASK GENMASK
+
 #define BITS_PER_BYTE 8
 #define BITS_PER_TYPE(t) (sizeof(t) * BITS_PER_BYTE)
 #define BITS_PER_LONG BITS_PER_TYPE(long)
Signature · 1 line
2.53.0
#5 lore raw

PATCH 4/4 tests/kms_color: Add background-color subtest to test the BACKGROUND_COLOR property

In reply to Maarten Lankhorst

The BACKGROUND_COLOR crtc property has recently been added. Add some intel CRC tests to verify this property.

---
 tests/kms_color.c | 79 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 79 insertions(+)
tests/kms_color.c +79 -0
index 565edb2dc9..e445c8b002 100644
@@ -46,6 +46,10 @@
  * Description: Verify that setting the legacy gamma LUT resets the gamma LUT
  *              set through GAMMA_LUT property
  *
+ * SUBTEST: background-color
+ * Description: Verify that a 8-bit background color has the same CRC
+ * as a 8-bit primary plane in the same color.
+ *
  * SUBTEST: ctm-%s
  * Description: Check the color transformation %arg[1]
  *
@@ -957,6 +961,68 @@ run_deep_color_tests_for_crtc(data_t *data, igt_crtc_t *crtc)
 	test_cleanup(data);
 }
 
+static void
+run_background_color_tests_for_crtc(data_t *data, igt_crtc_t *crtc)
+{
+	igt_output_t *output;
+	struct igt_fb fb;
+	typeof(data->mode) mode;
+	uint64_t black = DRM_ARGB64_PREP(0xffff, 0, 0, 0);
+	uint64_t red  = DRM_ARGB64_PREP(0xffff, 0xffff, 0, 0);
+	uint64_t green = DRM_ARGB64_PREP(0xffff, 0, 0xffff, 0);
+	uint64_t blue = DRM_ARGB64_PREP(0xffff, 0, 0, 0xffff);
+	uint64_t colors[] = { black, red, green, blue };
+
+	igt_require(igt_crtc_has_prop(crtc, IGT_CRTC_BACKGROUND_COLOR));
+	test_setup(data, crtc);
+
+	output = igt_get_single_output_for_crtc(crtc);
+	igt_require(output);
+
+	mode = igt_output_get_mode(output);
+
+	data->color_depth = 8;
+	data->drm_format = DRM_FORMAT_XRGB8888;
+	data->output = output;
+	data->mode = NULL;
+
+	igt_create_fb(data->drm_fd, mode->hdisplay, mode->vdisplay,
+		      data->drm_format, DRM_FORMAT_MOD_LINEAR, &fb);
+
+	igt_output_set_crtc(output, crtc);
+
+	for (unsigned long i = 0; i < ARRAY_SIZE(colors); i++) {
+		igt_crc_t plane_crc, bg_crc;
+
+		uint64_t color = colors[i];
+		uint32_t xrgb =
+			(DRM_ARGB64_GETA_BPCS(color, 8) << 24) |
+			(DRM_ARGB64_GETR_BPCS(color, 8) << 16) |
+			(DRM_ARGB64_GETG_BPCS(color, 8) << 8) |
+			(DRM_ARGB64_GETB_BPCS(color, 8));
+
+		/*
+		 * Set a different background color and  a fully opaque plane
+		 * with the correct color.
+		 */
+		igt_draw_fill_fb(data->drm_fd, &fb, xrgb);
+		igt_plane_set_fb(data->primary, &fb);
+		igt_crtc_set_prop_value(crtc, IGT_CRTC_BACKGROUND_COLOR, colors[i ^ 1]);
+		igt_display_commit2(&data->display, COMMIT_ATOMIC);
+		igt_pipe_crc_collect_crc(data->pipe_crc, &plane_crc);
+
+		igt_plane_set_fb(data->primary, NULL);
+		igt_crtc_set_prop_value(crtc, IGT_CRTC_BACKGROUND_COLOR, color);
+		igt_display_commit2(&data->display, COMMIT_ATOMIC);
+		igt_pipe_crc_collect_crc(data->pipe_crc, &bg_crc);
+
+		igt_assert_crc_equal(&plane_crc, &bg_crc);
+	}
+
+
+	test_cleanup(data);
+}
+
 static void
 run_invalid_tests_for_pipe(data_t *data)
 {
@@ -1165,6 +1231,19 @@ run_tests_for_pipe(data_t *data)
 				break;
 		}
 	}
+
+	igt_describe("Verify that the background color is set correctly");
+	igt_subtest_with_dynamic("background-color") {
+		for_each_crtc(&data->display, crtc) {
+			igt_dynamic_f("pipe-%s-background-color", igt_crtc_name(crtc)) {
+				run_background_color_tests_for_crtc(data, crtc);
+
+				if (igt_run_in_simulation())
+					break;
+			}
+
+		}
+	}
 }
 
 int igt_main()
Signature · 1 line
2.53.0
#6 lore raw

RE: [PATCH i-g-t 4/4] tests/kms_color: Add background-color subtest to test the BACKGROUND_COLOR property

Hi Maarten,

Quoted 115 lines

-----Original Message-----

From: igt-dev <[email protected]<mailto:[email protected]>> On Behalf Of

Maarten Lankhorst

Sent: Wednesday, May 6, 2026 1:14 AM

To: [email protected]<mailto:[email protected]>

Cc Maarten Lankhorst <[email protected]<mailto:[email protected]>>

Subject: [PATCH i-g-t 4/4] tests/kms_color: Add background-color subtest to

test the BACKGROUND_COLOR property

The BACKGROUND_COLOR crtc property has recently been added.

Add some intel CRC tests to verify this property.

---

 tests/kms_color.c | 79

+++++++++++++++++++++++++++++++++++++++++++++++

 1 file changed, 79 insertions(+)
tests/kms_color.c index renamed from tests/kms_color.c +0 -0

565edb2dc9..e445c8b002 100644

--- a/tests/kms_color.c

+++ b/tests/kms_color.c

tests/kms_color.c index renamed from tests/kms_color.c +0 -0
@@ -46,6 +46,10 @@
 
  * Description: Verify that setting the legacy gamma LUT resets the gamma
 

LUT

* set through GAMMA_LUT property

*

+ * SUBTEST: background-color

+ * Description: Verify that a 8-bit background color has the same CRC

+ * as a 8-bit primary plane in the same color.

+ *

* SUBTEST: ctm-%s

* Description: Check the color transformation %arg[1]

*

tests/kms_color.c index renamed from tests/kms_color.c +12 -0
@@ -957,6 +961,68 @@ run_deep_color_tests_for_crtc(data_t *data,
 
 igt_crtc_t *crtc)
 
            test_cleanup(data);
 
 }
 
 
 
+static void
 
+run_background_color_tests_for_crtc(data_t *data, igt_crtc_t *crtc) {
 
+          igt_output_t *output;
 
+          struct igt_fb fb;
 
+          typeof(data->mode) mode;
 
+          uint64_t black = DRM_ARGB64_PREP(0xffff, 0, 0, 0);
 
+          uint64_t red  = DRM_ARGB64_PREP(0xffff, 0xffff, 0, 0);
 
+          uint64_t green = DRM_ARGB64_PREP(0xffff, 0, 0xffff, 0);
 
+          uint64_t blue = DRM_ARGB64_PREP(0xffff, 0, 0, 0xffff);
 
+          uint64_t colors[] = { black, red, green, blue };
 
+
 
+          igt_require(igt_crtc_has_prop(crtc,

IGT_CRTC_BACKGROUND_COLOR));

tests/kms_color.c index renamed from tests/kms_color.c +6 -0
+          test_setup(data, crtc);
 
+
 
+          output = igt_get_single_output_for_crtc(crtc);
 
+          igt_require(output);
 
+
 
+          mode = igt_output_get_mode(output);

tests/kms_color.c index

Quoted 10 lines
tests/kms_color.c index renamed from tests/kms_color.c +5 -0
 
+
 
+          data->color_depth = 8;
 
+          data->drm_format = DRM_FORMAT_XRGB8888;
 
+          data->output = output;
 
+          data->mode = NULL;

After fetching mode into a local variable, setting data->mode = NULL is not required.

Either you can remove this data->mode or fetch mode into data->mode itself and

avoid use of mode variable.

Quoted 61 lines
tests/kms_color.c index renamed from tests/kms_color.c +23 -0
+
 
+          igt_create_fb(data->drm_fd, mode->hdisplay, mode->vdisplay,
 
+                               data->drm_format, DRM_FORMAT_MOD_LINEAR, &fb);
 
+
 
+          igt_output_set_crtc(output, crtc);
 
+
 
+          for (unsigned long i = 0; i < ARRAY_SIZE(colors); i++) {
 
+                         igt_crc_t plane_crc, bg_crc;
 
+
 
+                         uint64_t color = colors[i];
 
+                         uint32_t xrgb =
 
+                                        (DRM_ARGB64_GETA_BPCS(color, 8) << 24) |
 
+                                        (DRM_ARGB64_GETR_BPCS(color, 8) << 16) |
 
+                                        (DRM_ARGB64_GETG_BPCS(color, 8) << 8) |
 
+                                        (DRM_ARGB64_GETB_BPCS(color, 8));
 
+
 
+                         /*
 
+                         * Set a different background color and  a fully opaque plane
 
+                         * with the correct color.
 
+                         */
 
+                         igt_draw_fill_fb(data->drm_fd, &fb, xrgb);
 
+                         igt_plane_set_fb(data->primary, &fb);
 
+                         igt_crtc_set_prop_value(crtc,

IGT_CRTC_BACKGROUND_COLOR, colors[i ^ 1]);

tests/kms_color.c index renamed from tests/kms_color.c +5 -0
+                         igt_display_commit2(&data->display, COMMIT_ATOMIC);
 
+                         igt_pipe_crc_collect_crc(data->pipe_crc, &plane_crc);
 
+
 
+                         igt_plane_set_fb(data->primary, NULL);
 
+                         igt_crtc_set_prop_value(crtc,

IGT_CRTC_BACKGROUND_COLOR, color);

tests/kms_color.c index renamed from tests/kms_color.c +1 -0
+                         igt_display_commit2(&data->display, COMMIT_ATOMIC);

tests/kms_color.c index

Quoted 10 lines
tests/kms_color.c index renamed from tests/kms_color.c +5 -0
 
+                         igt_pipe_crc_collect_crc(data->pipe_crc, &bg_crc);
 
+
 
+                         igt_assert_crc_equal(&plane_crc, &bg_crc);
 
+          }
 
+

The FB is never cleaned up, and output is not detached from the CRTC on exit.

Please add full teardown (igt_output_set_crtc(.., NULL), final atomic commit, and igt_remove_fb(..)).

Quoted 1 line

+

Please avoid this extra blank line.

Quoted 18 lines
tests/kms_color.c index renamed from tests/kms_color.c +3 -0
+          test_cleanup(data);
 
+}
 
+
 
 static void
 
 run_invalid_tests_for_pipe(data_t *data)  { @@ -1165,6 +1231,19 @@

run_tests_for_pipe(data_t *data)

                                                         break;

                           }

            }

tests/kms_color.c index

Quoted 7 lines
tests/kms_color.c index renamed from tests/kms_color.c +4 -0
+
 
+          igt_describe("Verify that the background color is set correctly");
 
+          igt_subtest_with_dynamic("background-color") {
 
+                         for_each_crtc(&data->display, crtc) {

Since test iterates over all CRTCs with one compatible output each, lets use for_each_crtc_with_single_output() helper. It already provides a single valid output per CRTC, so we can drop the extra igt_get_single_output_for_crtc() lookup and avoid igt_require(output) inside the dynamic subtest.

Quoted 8 lines

+ igt_dynamic_f("pipe-%s-background-color",

igt_crtc_name(crtc)) {

+ run_background_color_tests_for_crtc(data,

crtc);

tests/kms_color.c index

Quoted 9 lines
tests/kms_color.c index renamed from tests/kms_color.c +5 -0
+
 
+                                                       if (igt_run_in_simulation())
 
+                                                                      break;
 
+                                        }
 
+

Please avoid this extra blank line.

Regards,

Pranay.

Quoted 13 lines
tests/kms_color.c index renamed from tests/kms_color.c +2 -1
+                         }
 
+          }
 
 }
 
 
 
 int igt_main()
 
--

2.53.0

#7 lore raw

Re: [PATCH i-g-t 4/4] tests/kms_color: Add background-color subtest to test the BACKGROUND_COLOR property

Hello,

Den 2026-05-19 kl. 16:25, skrev Samala, Pranay:

Quoted 130 lines

Hi Maarten,

Quoted 115 lines

-----Original Message-----

From: igt-dev <[email protected] <mailto:[email protected]>> On Behalf Of

Maarten Lankhorst

Sent: Wednesday, May 6, 2026 1:14 AM

To: [email protected] <mailto:[email protected]>

Cc Maarten Lankhorst <[email protected] <mailto:[email protected]>>

Subject: [PATCH i-g-t 4/4] tests/kms_color: Add background-color subtest to

test the BACKGROUND_COLOR property

The BACKGROUND_COLOR crtc property has recently been added.

Add some intel CRC tests to verify this property.

Signed-off-by Maarten Lankhorst <[email protected] <mailto:[email protected]>>

---

  tests/kms_color.c | 79

+++++++++++++++++++++++++++++++++++++++++++++++

  1 file changed, 79 insertions(+)
tests/kms_color.c index renamed from tests/kms_color.c +0 -0

565edb2dc9..e445c8b002 100644

--- a/tests/kms_color.c

+++ b/tests/kms_color.c

tests/kms_color.c index renamed from tests/kms_color.c +0 -0
@@ -46,6 +46,10 @@
 
    * Description: Verify that setting the legacy gamma LUT resets the gamma
 

LUT

   *              set through GAMMA_LUT property

   *

+ * SUBTEST: background-color

+ * Description: Verify that a 8-bit background color has the same CRC

+ * as a 8-bit primary plane in the same color.

+ *

   * SUBTEST: ctm-%s

   * Description: Check the color transformation %arg[1]

   *

tests/kms_color.c index renamed from tests/kms_color.c +12 -0
@@ -957,6 +961,68 @@ run_deep_color_tests_for_crtc(data_t *data,
 
 igt_crtc_t *crtc)
 
              test_cleanup(data);
 
   }
 
 
 
+static void
 
+run_background_color_tests_for_crtc(data_t *data, igt_crtc_t *crtc) {
 
+          igt_output_t *output;
 
+          struct igt_fb fb;
 
+          typeof(data->mode) mode;
 
+          uint64_t black = DRM_ARGB64_PREP(0xffff, 0, 0, 0);
 
+          uint64_t red  = DRM_ARGB64_PREP(0xffff, 0xffff, 0, 0);
 
+          uint64_t green = DRM_ARGB64_PREP(0xffff, 0, 0xffff, 0);
 
+          uint64_t blue = DRM_ARGB64_PREP(0xffff, 0, 0, 0xffff);
 
+          uint64_t colors[] = { black, red, green, blue };
 
+
 
+          igt_require(igt_crtc_has_prop(crtc,

IGT_CRTC_BACKGROUND_COLOR));

+          test_setup(data, crtc);

tests/kms_color.c index renamed from tests/kms_color.c +5 -0
+
 
+          output = igt_get_single_output_for_crtc(crtc);
 
+          igt_require(output);
 
+
 
+          mode = igt_output_get_mode(output);

tests/kms_color.c index

Quoted 10 lines
tests/kms_color.c index renamed from tests/kms_color.c +5 -0
 
+
 
+          data->color_depth = 8;
 
+          data->drm_format = DRM_FORMAT_XRGB8888;
 
+          data->output = output;
 
+          data->mode = NULL;
Quoted 7 lines

After fetching mode into a local variable, setting data->mode = NULL is not required.

Either you can remove this data->mode or fetch mode into data->mode itself and

avoid use of mode variable.

I zero it in case it's used elsewhere an to prevent dangling pointers.

That said, I'll just remove the assignment.

Quoted 73 lines

Quoted 69 lines
tests/kms_color.c index renamed from tests/kms_color.c +23 -0
+
 
+          igt_create_fb(data->drm_fd, mode->hdisplay, mode->vdisplay,
 
+                               data->drm_format, DRM_FORMAT_MOD_LINEAR, &fb);
 
+
 
+          igt_output_set_crtc(output, crtc);
 
+
 
+          for (unsigned long i = 0; i < ARRAY_SIZE(colors); i++) {
 
+                         igt_crc_t plane_crc, bg_crc;
 
+
 
+                         uint64_t color = colors[i];
 
+                         uint32_t xrgb =
 
+                                        (DRM_ARGB64_GETA_BPCS(color, 8) << 24) |
 
+                                        (DRM_ARGB64_GETR_BPCS(color, 8) << 16) |
 
+                                        (DRM_ARGB64_GETG_BPCS(color, 8) << 8) |
 
+                                        (DRM_ARGB64_GETB_BPCS(color, 8));
 
+
 
+                         /*
 
+                         * Set a different background color and  a fully opaque plane
 
+                         * with the correct color.
 
+                         */
 
+                         igt_draw_fill_fb(data->drm_fd, &fb, xrgb);
 
+                         igt_plane_set_fb(data->primary, &fb);
 
+                         igt_crtc_set_prop_value(crtc,

IGT_CRTC_BACKGROUND_COLOR, colors[i ^ 1]);

+                         igt_display_commit2(&data->display, COMMIT_ATOMIC);

+                         igt_pipe_crc_collect_crc(data->pipe_crc, &plane_crc);

+

+                         igt_plane_set_fb(data->primary, NULL);

+                         igt_crtc_set_prop_value(crtc,

IGT_CRTC_BACKGROUND_COLOR, color);

+                         igt_display_commit2(&data->display, COMMIT_ATOMIC);

+                         igt_pipe_crc_collect_crc(data->pipe_crc, &bg_crc);

+

+                         igt_assert_crc_equal(&plane_crc, &bg_crc);

+          }

Quoted 7 lines
Quoted 1 line

+

The FB is never cleaned up, and output is not detached from the CRTC on exit.

Please add full teardown (igt_output_set_crtc(.., NULL), final atomic commit, and igt_remove_fb(..)).

My personal preference here is to perform as little cleanup as possible, in particular always assume the previous subtest failed and the subtest cleanup never ran.

With this, I don't bother with cleanup as the next subtest *must* assume the previous test failed somewhere in the middle, and call igt_display_reset() in order to not fail with different expectations on the current atomic state.

Personally I wouldn't even add igt_display_fini() and close() calls, and have all cleanups handled by performing a process exit instead.

Removing the fb should be done though, I'll add that.

Quoted 36 lines

Quoted 1 line

+

Please avoid this extra blank line.

Quoted 18 lines

+          test_cleanup(data);

tests/kms_color.c index renamed from tests/kms_color.c +2 -0
+}
 
+

  static void

  run_invalid_tests_for_pipe(data_t *data)  { @@ -1165,6 +1231,19 @@

run_tests_for_pipe(data_t *data)

                                                          break;

                            }

             }

Quoted 7 lines

+

+          igt_describe("Verify that the background color is set correctly");

+          igt_subtest_with_dynamic("background-color") {

+                         for_each_crtc(&data->display, crtc) {

Quoted 8 lines

Since test iterates over all CRTCs with one compatible output each, lets use

for_each_crtc_with_single_output() helper. It already provides a single valid

output per CRTC, so we can drop the extra igt_get_single_output_for_crtc()

lookup and avoid igt_require(output) inside the dynamic subtest.

I should have known, having written for_each_pipe_with_single_output in 2018. :-)

Kind regards,
~Maarten Lankhorst

#8 lore raw

✓ Xe.CI.BAT: success for series starting with [i-g-t,1/4] lib/igt_kms: Add support for the BACKGROUND_COLOR property.

In reply to Maarten Lankhorst
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,1/4] lib/igt_kms: Add support for the BACKGROUND_COLOR property.
URL : https://patchwork.freedesktop.org/series/166016/
State : success

== Summary ==

CI Bug Log - changes from XEIGT_8888_BAT -> XEIGTPW_15102_BAT
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (12 -> 12)
------------------------------

No changes in participating hosts

Known issues
------------

Here are the changes found in XEIGTPW_15102_BAT that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1:
- bat-adlp-7: [PASS][1] -> [DMESG-WARN][2] ([Intel XE#7483])
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8888/bat-adlp-7/igt@kms_flip@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/bat-adlp-7/igt@kms_flip@[email protected]

#### Possible fixes ####

* igt@kms_flip@basic-flip-vs-wf_vblank@d-edp1:
- bat-adlp-7: [DMESG-WARN][3] ([Intel XE#7483]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8888/bat-adlp-7/igt@kms_flip@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/bat-adlp-7/igt@kms_flip@[email protected]

[Intel XE#7483]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7483

Build changes
-------------

* IGT: IGT_8888 -> IGTPW_15102

IGTPW_15102: fd41a765a6c87d118b00e59ee6ac91baec5eca68 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
IGT_8888: 77f31f709ee65bb20ad7d64d8aa012ba7688b112 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-4990-835de80ce9b34b618442ba91483170201b50b553: 835de80ce9b34b618442ba91483170201b50b553

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/index.html

#9 lore raw

✗ i915.CI.BAT: failure for series starting with [i-g-t,1/4] lib/igt_kms: Add support for the BACKGROUND_COLOR property.

In reply to Maarten Lankhorst
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,1/4] lib/igt_kms: Add support for the BACKGROUND_COLOR property.
URL : https://patchwork.freedesktop.org/series/166016/
State : failure

== Summary ==

CI Bug Log - changes from IGT_8888 -> IGTPW_15102
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_15102 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in IGTPW_15102, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15102/index.html

Participating hosts (42 -> 39)
------------------------------

Missing (3): bat-dg2-13 fi-glk-j4005 fi-snb-2520m

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_15102:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live@gt_pm:
- bat-arls-5: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8888/bat-arls-5/igt@i915_selftest@live@gt_pm.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15102/bat-arls-5/igt@i915_selftest@live@gt_pm.html

Known issues
------------

Here are the changes found in IGTPW_15102 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live@workarounds:
- bat-arls-5: [PASS][3] -> [DMESG-FAIL][4] ([i915#12061]) +1 other test dmesg-fail
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8888/bat-arls-5/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15102/bat-arls-5/igt@i915_selftest@[email protected]

[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_8888 -> IGTPW_15102

CI-20190529: 20190529
CI_DRM_18417: 835de80ce9b34b618442ba91483170201b50b553 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_15102: fd41a765a6c87d118b00e59ee6ac91baec5eca68 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
IGT_8888: 77f31f709ee65bb20ad7d64d8aa012ba7688b112 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15102/index.html

#10 lore raw

✗ Xe.CI.FULL: failure for series starting with [i-g-t,1/4] lib/igt_kms: Add support for the BACKGROUND_COLOR property.

In reply to Maarten Lankhorst
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,1/4] lib/igt_kms: Add support for the BACKGROUND_COLOR property.
URL : https://patchwork.freedesktop.org/series/166016/
State : failure

== Summary ==

CI Bug Log - changes from XEIGT_8888_FULL -> XEIGTPW_15102_FULL
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with XEIGTPW_15102_FULL absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in XEIGTPW_15102_FULL, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (2 -> 2)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in XEIGTPW_15102_FULL:

### IGT changes ###

#### Possible regressions ####

* igt@kms_frontbuffer_tracking@fbcdrrshdr-2p-primscrn-pri-indfb-draw-blt:
- shard-lnl: NOTRUN -> [SKIP][1] +6 other tests skip
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-3/igt@kms_frontbuffer_tracking@fbcdrrshdr-2p-primscrn-pri-indfb-draw-blt.html

* igt@kms_frontbuffer_tracking@fbcdrrshdr-tiling-y:
- shard-bmg: NOTRUN -> [SKIP][2] +3 other tests skip
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-1/igt@[email protected]

* igt@xe_wedged@wedged-mode-toggle:
- shard-bmg: [PASS][3] -> [ABORT][4]
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8888/shard-bmg-2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-7/igt@[email protected]

#### Warnings ####

* igt@kms_content_protection@legacy:
- shard-lnl: [SKIP][5] ([Intel XE#7642]) -> [ABORT][6]
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8888/shard-lnl-3/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-1/igt@[email protected]

* igt@kms_frontbuffer_tracking@drrshdr-2p-primscrn-cur-indfb-move:
- shard-lnl: [ABORT][7] -> [SKIP][8]
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8888/shard-lnl-7/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-8/igt@[email protected]

New tests
---------

New tests have been introduced between XEIGT_8888_FULL and XEIGTPW_15102_FULL:

### New IGT tests (5) ###

* igt@kms_color@background-color:
- Statuses : 2 skip(s)
- Exec time: [0.00] s

* igt@kms_color@background-color@pipe-a-background-color:
- Statuses : 2 skip(s)
- Exec time: [0.0] s

* igt@kms_color@background-color@pipe-b-background-color:
- Statuses : 2 skip(s)
- Exec time: [0.0] s

* igt@kms_color@background-color@pipe-c-background-color:
- Statuses : 2 skip(s)
- Exec time: [0.0] s

* igt@kms_color@background-color@pipe-d-background-color:
- Statuses : 1 skip(s)
- Exec time: [0.0] s

Known issues
------------

Here are the changes found in XEIGTPW_15102_FULL that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_big_fb@4-tiled-16bpp-rotate-270:
- shard-lnl: NOTRUN -> [SKIP][9] ([Intel XE#1407])
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-1/igt@[email protected]
- shard-bmg: NOTRUN -> [SKIP][10] ([Intel XE#2327]) +1 other test skip
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-1/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0:
- shard-lnl: NOTRUN -> [SKIP][11] ([Intel XE#1124]) +1 other test skip
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-2/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-bmg: NOTRUN -> [SKIP][12] ([Intel XE#1124]) +4 other tests skip
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-10/igt@[email protected]

* igt@kms_bw@connected-linear-tiling-4-displays-target-1920x1080p:
- shard-bmg: NOTRUN -> [SKIP][13] ([Intel XE#7679]) +1 other test skip
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-1/igt@[email protected]

* igt@kms_bw@connected-linear-tiling-4-displays-target-3840x2160p:
- shard-lnl: NOTRUN -> [SKIP][14] ([Intel XE#7676])
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-5/igt@[email protected]

* igt@kms_ccs@bad-rotation-90-4-tiled-bmg-ccs@pipe-a-edp-1:
- shard-lnl: NOTRUN -> [SKIP][15] ([Intel XE#2669] / [Intel XE#7389]) +3 other tests skip
[15]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-7/igt@kms_ccs@[email protected]

* igt@kms_ccs@ccs-on-another-bo-4-tiled-mtl-mc-ccs:
- shard-lnl: NOTRUN -> [SKIP][16] ([Intel XE#2887])
[16]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-1/igt@[email protected]

* igt@kms_ccs@ccs-on-another-bo-y-tiled-gen12-mc-ccs:
- shard-bmg: NOTRUN -> [SKIP][17] ([Intel XE#2887]) +8 other tests skip
[17]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-1/igt@[email protected]

* igt@kms_ccs@crc-primary-suspend-yf-tiled-ccs:
- shard-bmg: NOTRUN -> [SKIP][18] ([Intel XE#3432]) +2 other tests skip
[18]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-5/igt@[email protected]
- shard-lnl: NOTRUN -> [SKIP][19] ([Intel XE#3432]) +1 other test skip
[19]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-5/igt@[email protected]

* igt@kms_chamelium_frames@hdmi-crc-single:
- shard-bmg: NOTRUN -> [SKIP][20] ([Intel XE#2252]) +5 other tests skip
[20]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-1/igt@[email protected]

* igt@kms_chamelium_hpd@hdmi-hpd:
- shard-lnl: NOTRUN -> [SKIP][21] ([Intel XE#373]) +2 other tests skip
[21]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-1/igt@[email protected]

* {igt@kms_color@background-color} (NEW):
- shard-bmg: NOTRUN -> [SKIP][22] ([Intel XE#3297]) +1 other test skip
[22]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-10/igt@[email protected]

* {igt@kms_color@background-color@pipe-c-background-color} (NEW):
- shard-lnl: NOTRUN -> [SKIP][23] ([Intel XE#3297]) +1 other test skip
[23]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-1/igt@kms_color@[email protected]

* igt@kms_content_protection@dp-mst-type-0-suspend-resume:
- shard-lnl: NOTRUN -> [SKIP][24] ([Intel XE#6974])
[24]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-7/igt@[email protected]
- shard-bmg: NOTRUN -> [SKIP][25] ([Intel XE#6974])
[25]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-9/igt@[email protected]

* igt@kms_cursor_crc@cursor-onscreen-128x42:
- shard-bmg: NOTRUN -> [SKIP][26] ([Intel XE#2320]) +3 other tests skip
[26]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-4/igt@[email protected]
- shard-lnl: NOTRUN -> [SKIP][27] ([Intel XE#1424])
[27]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-3/igt@[email protected]

* igt@kms_cursor_legacy@cursorb-vs-flipb-legacy:
- shard-lnl: NOTRUN -> [SKIP][28] ([Intel XE#309] / [Intel XE#7343]) +1 other test skip
[28]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-8/igt@[email protected]

* igt@kms_dp_link_training@non-uhbr-mst:
- shard-bmg: NOTRUN -> [SKIP][29] ([Intel XE#4354] / [Intel XE#5882])
[29]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-7/igt@[email protected]

* igt@kms_dsc@dsc-fractional-bpp:
- shard-bmg: NOTRUN -> [SKIP][30] ([Intel XE#2244]) +1 other test skip
[30]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-5/igt@[email protected]
- shard-lnl: NOTRUN -> [SKIP][31] ([Intel XE#2244])
[31]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-5/igt@[email protected]

* igt@kms_fbcon_fbt@psr:
- shard-bmg: NOTRUN -> [SKIP][32] ([Intel XE#6126] / [Intel XE#776])
[32]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-2/igt@[email protected]

* igt@kms_feature_discovery@psr1:
- shard-bmg: NOTRUN -> [SKIP][33] ([Intel XE#2374] / [Intel XE#6127])
[33]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-10/igt@[email protected]

* igt@kms_flip@2x-absolute-wf_vblank-interruptible:
- shard-lnl: NOTRUN -> [SKIP][34] ([Intel XE#1421])
[34]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-5/igt@kms_flip@2x-absolute-wf_vblank-interruptible.html

* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-lnl: [PASS][35] -> [FAIL][36] ([Intel XE#301])
[35]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8888/shard-lnl-3/igt@kms_flip@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-5/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling:
- shard-lnl: NOTRUN -> [SKIP][37] ([Intel XE#7178] / [Intel XE#7349])
[37]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-7/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling.html

* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling:
- shard-bmg: NOTRUN -> [SKIP][38] ([Intel XE#7178] / [Intel XE#7349]) +1 other test skip
[38]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-6/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling.html

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling:
- shard-bmg: NOTRUN -> [SKIP][39] ([Intel XE#7178] / [Intel XE#7351])
[39]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-4/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling.html

* igt@kms_flip_scaled_crc@flip-nv12-linear-to-nv12-linear-reflect-x:
- shard-bmg: NOTRUN -> [SKIP][40] ([Intel XE#7179])
[40]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-8/igt@kms_flip_scaled_crc@flip-nv12-linear-to-nv12-linear-reflect-x.html

* igt@kms_frontbuffer_tracking@drrs-rgb565-draw-render:
- shard-lnl: NOTRUN -> [SKIP][41] ([Intel XE#6312] / [Intel XE#651]) +2 other tests skip
[41]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-7/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- shard-bmg: NOTRUN -> [SKIP][42] ([Intel XE#4141]) +6 other tests skip
[42]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-4/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcdrrs-2p-rte:
- shard-lnl: NOTRUN -> [SKIP][43] ([Intel XE#656]) +8 other tests skip
[43]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-3/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcdrrshdr-1p-primscrn-shrfb-msflip-blt:
- shard-lnl: NOTRUN -> [SKIP][44] ([Intel XE#6312]) +4 other tests skip
[44]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-8/igt@kms_frontbuffer_tracking@fbcdrrshdr-1p-primscrn-shrfb-msflip-blt.html

* igt@kms_frontbuffer_tracking@fbcdrrshdr-rgb565-draw-blt:
- shard-bmg: NOTRUN -> [SKIP][45] ([Intel XE#2311]) +34 other tests skip
[45]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-10/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbchdr-1p-primscrn-spr-indfb-draw-blt:
- shard-lnl: NOTRUN -> [SKIP][46] ([Intel XE#7865]) +6 other tests skip
[46]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-1/igt@kms_frontbuffer_tracking@fbchdr-1p-primscrn-spr-indfb-draw-blt.html

* igt@kms_frontbuffer_tracking@fbchdr-abgr161616f-draw-blt:
- shard-bmg: NOTRUN -> [SKIP][47] ([Intel XE#7061]) +1 other test skip
[47]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-1/igt@[email protected]

* igt@kms_frontbuffer_tracking@hdr-argb161616f-draw-render:
- shard-lnl: NOTRUN -> [SKIP][48] ([Intel XE#7061])
[48]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-5/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-plflip-blt:
- shard-bmg: NOTRUN -> [SKIP][49] ([Intel XE#2313]) +29 other tests skip
[49]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-8/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-argb161616f-draw-blt:
- shard-bmg: NOTRUN -> [SKIP][50] ([Intel XE#7061] / [Intel XE#7356]) +1 other test skip
[50]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-2/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-argb161616f-draw-render:
- shard-lnl: NOTRUN -> [SKIP][51] ([Intel XE#7061] / [Intel XE#7356])
[51]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-2/igt@[email protected]

* igt@kms_hdmi_inject@inject-audio:
- shard-lnl: NOTRUN -> [SKIP][52] ([Intel XE#1470] / [Intel XE#2853])
[52]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-3/igt@[email protected]
- shard-bmg: NOTRUN -> [SKIP][53] ([Intel XE#7308])
[53]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-4/igt@[email protected]

* igt@kms_pipe_stress@stress-xrgb8888-ytiled:
- shard-bmg: NOTRUN -> [SKIP][54] ([Intel XE#4329] / [Intel XE#6912] / [Intel XE#7375])
[54]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-2/igt@[email protected]

* igt@kms_plane@pixel-format-4-tiled-mtl-rc-ccs-cc-modifier:
- shard-lnl: NOTRUN -> [SKIP][55] ([Intel XE#7283])
[55]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-7/igt@[email protected]

* igt@kms_plane@pixel-format-yf-tiled-modifier-source-clamping:
- shard-bmg: NOTRUN -> [SKIP][56] ([Intel XE#7283]) +2 other tests skip
[56]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-2/igt@[email protected]

* igt@kms_plane_lowres@tiling-4:
- shard-lnl: NOTRUN -> [SKIP][57] ([Intel XE#599] / [Intel XE#7382]) +3 other tests skip
[57]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-3/igt@[email protected]

* igt@kms_plane_multiple@2x-tiling-yf:
- shard-bmg: NOTRUN -> [SKIP][58] ([Intel XE#5021] / [Intel XE#7377])
[58]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-8/igt@[email protected]

* igt@kms_plane_scaling@intel-max-src-size:
- shard-lnl: NOTRUN -> [SKIP][59] ([Intel XE#3307])
[59]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-7/igt@[email protected]

* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a:
- shard-lnl: NOTRUN -> [SKIP][60] ([Intel XE#2763] / [Intel XE#6886]) +3 other tests skip
[60]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-4/igt@kms_plane_scaling@[email protected]

* igt@kms_pm_backlight@fade:
- shard-bmg: NOTRUN -> [SKIP][61] ([Intel XE#7376] / [Intel XE#870])
[61]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-10/igt@[email protected]

* igt@kms_pm_dc@dc5-dpms:
- shard-lnl: [PASS][62] -> [FAIL][63] ([Intel XE#7340] / [Intel XE#7504])
[62]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8888/shard-lnl-7/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-3/igt@[email protected]

* igt@kms_pm_dc@dc6-dpms:
- shard-lnl: [PASS][64] -> [FAIL][65] ([Intel XE#7340])
[64]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8888/shard-lnl-1/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-5/igt@[email protected]

* igt@kms_psr2_sf@fbc-pr-cursor-plane-move-continuous-sf:
- shard-bmg: NOTRUN -> [SKIP][66] ([Intel XE#1489]) +3 other tests skip
[66]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-2/igt@[email protected]
- shard-lnl: NOTRUN -> [SKIP][67] ([Intel XE#2893] / [Intel XE#7304])
[67]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-4/igt@[email protected]

* igt@kms_psr2_su@page_flip-p010:
- shard-bmg: NOTRUN -> [SKIP][68] ([Intel XE#2387] / [Intel XE#7429])
[68]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-8/igt@kms_psr2_su@page_flip-p010.html

* igt@kms_psr@fbc-pr-primary-render:
- shard-bmg: NOTRUN -> [SKIP][69] ([Intel XE#2234] / [Intel XE#2850]) +4 other tests skip
[69]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-6/igt@[email protected]
- shard-lnl: NOTRUN -> [SKIP][70] ([Intel XE#1406])
[70]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-8/igt@[email protected]

* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-bmg: NOTRUN -> [SKIP][71] ([Intel XE#7795])
[71]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-6/igt@[email protected]
- shard-lnl: [PASS][72] -> [SKIP][73] ([Intel XE#4692] / [Intel XE#7508])
[72]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8888/shard-lnl-5/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-4/igt@[email protected]

* igt@kms_rotation_crc@primary-rotation-90:
- shard-bmg: NOTRUN -> [SKIP][74] ([Intel XE#3904] / [Intel XE#7342])
[74]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-5/igt@[email protected]
- shard-lnl: NOTRUN -> [SKIP][75] ([Intel XE#3414] / [Intel XE#3904] / [Intel XE#7342]) +1 other test skip
[75]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-5/igt@[email protected]

* igt@kms_scaling_modes@scaling-mode-full-aspect:
- shard-bmg: NOTRUN -> [SKIP][76] ([Intel XE#2413])
[76]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-5/igt@[email protected]

* igt@kms_sharpness_filter@invalid-filter-with-scaling-mode:
- shard-bmg: NOTRUN -> [SKIP][77] ([Intel XE#6503]) +1 other test skip
[77]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-1/igt@[email protected]

* igt@kms_vrr@flip-dpms:
- shard-bmg: NOTRUN -> [SKIP][78] ([Intel XE#1499])
[78]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-10/igt@[email protected]

* igt@xe_eudebug@basic-client:
- shard-lnl: NOTRUN -> [SKIP][79] ([Intel XE#7636]) +2 other tests skip
[79]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-7/igt@[email protected]

* igt@xe_eudebug_online@set-breakpoint-sigint-debugger:
- shard-bmg: NOTRUN -> [SKIP][80] ([Intel XE#7636]) +8 other tests skip
[80]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-9/igt@[email protected]

* igt@xe_evict@evict-large-external-cm:
- shard-lnl: NOTRUN -> [SKIP][81] ([Intel XE#6540] / [Intel XE#688]) +3 other tests skip
[81]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-1/igt@[email protected]

* igt@xe_evict@evict-mixed-many-threads-small:
- shard-bmg: [PASS][82] -> [INCOMPLETE][83] ([Intel XE#6321])
[82]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8888/shard-bmg-9/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-8/igt@[email protected]

* igt@xe_evict@evict-small-external-multi-queue-cm:
- shard-bmg: NOTRUN -> [SKIP][84] ([Intel XE#7140])
[84]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-5/igt@[email protected]

* igt@xe_exec_balancer@virtual-all-active:
- shard-lnl: NOTRUN -> [SKIP][85] ([Intel XE#7482]) +3 other tests skip
[85]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-5/igt@[email protected]

* igt@xe_exec_basic@multigpu-many-execqueues-many-vm-basic-defer-mmap:
- shard-bmg: NOTRUN -> [SKIP][86] ([Intel XE#2322] / [Intel XE#7372]) +5 other tests skip
[86]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-5/igt@xe_exec_basic@multigpu-many-execqueues-many-vm-basic-defer-mmap.html

* igt@xe_exec_basic@multigpu-no-exec-basic-defer-bind:
- shard-lnl: NOTRUN -> [SKIP][87] ([Intel XE#1392]) +1 other test skip
[87]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-8/igt@[email protected]

* igt@xe_exec_fault_mode@many-multi-queue-rebind-prefetch:
- shard-bmg: NOTRUN -> [SKIP][88] ([Intel XE#7136]) +5 other tests skip
[88]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-8/igt@[email protected]

* igt@xe_exec_fault_mode@once-multi-queue-prefetch:
- shard-lnl: NOTRUN -> [SKIP][89] ([Intel XE#7136]) +1 other test skip
[89]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-8/igt@[email protected]

* igt@xe_exec_multi_queue@few-execs-preempt-mode-basic-smem:
- shard-lnl: NOTRUN -> [SKIP][90] ([Intel XE#6874]) +4 other tests skip
[90]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-1/igt@[email protected]

* igt@xe_exec_multi_queue@many-execs-close-fd-smem:
- shard-bmg: NOTRUN -> [SKIP][91] ([Intel XE#6874]) +15 other tests skip
[91]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-9/igt@[email protected]

* igt@xe_exec_reset@cm-multi-queue-cat-error-on-secondary:
- shard-bmg: NOTRUN -> [SKIP][92] ([Intel XE#7866]) +1 other test skip
[92]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-5/igt@[email protected]

* igt@xe_exec_threads@threads-multi-queue-mixed-userptr-invalidate-race:
- shard-bmg: NOTRUN -> [SKIP][93] ([Intel XE#7138]) +5 other tests skip
[93]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-9/igt@xe_exec_threads@threads-multi-queue-mixed-userptr-invalidate-race.html

* igt@xe_exec_threads@threads-multi-queue-userptr-rebind:
- shard-lnl: NOTRUN -> [SKIP][94] ([Intel XE#7138]) +2 other tests skip
[94]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-2/igt@[email protected]

* igt@xe_multigpu_svm@mgpu-atomic-op-prefetch:
- shard-bmg: NOTRUN -> [SKIP][95] ([Intel XE#6964])
[95]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-2/igt@[email protected]
- shard-lnl: NOTRUN -> [SKIP][96] ([Intel XE#6964])
[96]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-7/igt@[email protected]

* igt@xe_oa@oa-tlb-invalidate:
- shard-lnl: NOTRUN -> [SKIP][97] ([Intel XE#2248] / [Intel XE#7325] / [Intel XE#7393])
[97]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-7/igt@[email protected]
- shard-bmg: NOTRUN -> [SKIP][98] ([Intel XE#2248] / [Intel XE#7325] / [Intel XE#7393])
[98]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-9/igt@[email protected]

* igt@xe_page_reclaim@binds-full-pd:
- shard-bmg: NOTRUN -> [SKIP][99] ([Intel XE#7793])
[99]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-10/igt@[email protected]

* igt@xe_pat@pat-index-xehpc:
- shard-bmg: NOTRUN -> [SKIP][100] ([Intel XE#1420] / [Intel XE#7590])
[100]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-7/igt@[email protected]

* igt@xe_pat@pat-index-xelpg:
- shard-bmg: NOTRUN -> [SKIP][101] ([Intel XE#2236] / [Intel XE#7590])
[101]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-4/igt@[email protected]

* igt@xe_pm@d3cold-basic:
- shard-bmg: NOTRUN -> [SKIP][102] ([Intel XE#2284] / [Intel XE#7370])
[102]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-4/igt@[email protected]

* igt@xe_pmu@fn-engine-activity-load:
- shard-lnl: NOTRUN -> [SKIP][103] ([Intel XE#4650] / [Intel XE#7347])
[103]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-4/igt@[email protected]

* igt@xe_pxp@pxp-termination-key-update-post-termination-irq:
- shard-bmg: NOTRUN -> [SKIP][104] ([Intel XE#4733] / [Intel XE#7417])
[104]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-9/igt@[email protected]

* igt@xe_query@multigpu-query-invalid-cs-cycles:
- shard-bmg: NOTRUN -> [SKIP][105] ([Intel XE#944]) +1 other test skip
[105]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-2/igt@[email protected]
- shard-lnl: NOTRUN -> [SKIP][106] ([Intel XE#944])
[106]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-4/igt@[email protected]

* igt@xe_sriov_flr@flr-twice:
- shard-bmg: [PASS][107] -> [FAIL][108] ([Intel XE#6569])
[107]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8888/shard-bmg-7/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-5/igt@[email protected]

* igt@xe_sriov_vfio@open-basic:
- shard-lnl: NOTRUN -> [SKIP][109] ([Intel XE#7724])
[109]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-1/igt@[email protected]

* igt@xe_sriov_vfio@region-info:
- shard-bmg: [PASS][110] -> [FAIL][111] ([Intel XE#5937])
[110]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8888/shard-bmg-4/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-9/igt@[email protected]

* igt@xe_vm@overcommit-nonfault-vram-lr-defer:
- shard-lnl: NOTRUN -> [SKIP][112] ([Intel XE#7892])
[112]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-3/igt@[email protected]

#### Possible fixes ####

* igt@kms_ccs@crc-primary-suspend-4-tiled-bmg-ccs:
- shard-bmg: [INCOMPLETE][113] ([Intel XE#7084]) -> [PASS][114] +1 other test pass
[113]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8888/shard-bmg-1/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-8/igt@[email protected]

* igt@kms_cursor_legacy@cursor-vs-flip-varying-size:
- shard-bmg: [DMESG-WARN][115] ([Intel XE#5354]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8888/shard-bmg-9/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-7/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-bmg: [FAIL][117] ([Intel XE#7571]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8888/shard-bmg-9/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-5/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-lnl: [FAIL][119] ([Intel XE#301] / [Intel XE#3149]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8888/shard-lnl-3/igt@kms_flip@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-5/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@b-edp1:
- shard-lnl: [FAIL][121] ([Intel XE#301]) -> [PASS][122] +1 other test pass
[121]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8888/shard-lnl-2/igt@kms_flip@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-7/igt@kms_flip@[email protected]

* igt@kms_hdr@invalid-hdr:
- shard-bmg: [SKIP][123] ([Intel XE#1503]) -> [PASS][124]
[123]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8888/shard-bmg-4/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-1/igt@[email protected]

* igt@xe_evict@evict-beng-mixed-many-threads-small:
- shard-bmg: [INCOMPLETE][125] ([Intel XE#6321]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8888/shard-bmg-7/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-1/igt@[email protected]

* igt@xe_sriov_vram@vf-access-after-resize-up:
- shard-bmg: [FAIL][127] ([Intel XE#5937]) -> [PASS][128] +2 other tests pass
[127]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8888/shard-bmg-2/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-1/igt@[email protected]

#### Warnings ####

* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-lnl: [FAIL][129] ([Intel XE#301] / [Intel XE#3149]) -> [FAIL][130] ([Intel XE#301])
[129]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8888/shard-lnl-3/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-lnl-5/igt@[email protected]

* igt@kms_frontbuffer_tracking@drrshdr-2p-primscrn-cur-indfb-move:
- shard-bmg: [ABORT][131] -> [SKIP][132] ([Intel XE#2311])
[131]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8888/shard-bmg-2/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-2/igt@[email protected]

* igt@kms_tiled_display@basic-test-pattern-with-chamelium:
- shard-bmg: [SKIP][133] ([Intel XE#2426] / [Intel XE#5848]) -> [SKIP][134] ([Intel XE#2509] / [Intel XE#7437])
[133]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8888/shard-bmg-1/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/shard-bmg-10/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[Intel XE#1124]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1124
[Intel XE#1392]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1392
[Intel XE#1406]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1406
[Intel XE#1407]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1407
[Intel XE#1420]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1420
[Intel XE#1421]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1421
[Intel XE#1424]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1424
[Intel XE#1470]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1470
[Intel XE#1489]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1489
[Intel XE#1499]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1499
[Intel XE#1503]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1503
[Intel XE#2234]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2234
[Intel XE#2236]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2236
[Intel XE#2244]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2244
[Intel XE#2248]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2248
[Intel XE#2252]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2252
[Intel XE#2284]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2284
[Intel XE#2311]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2311
[Intel XE#2313]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2313
[Intel XE#2320]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2320
[Intel XE#2322]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2322
[Intel XE#2327]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2327
[Intel XE#2374]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2374
[Intel XE#2387]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2387
[Intel XE#2413]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2413
[Intel XE#2426]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2426
[Intel XE#2509]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2509
[Intel XE#2669]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2669
[Intel XE#2763]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2763
[Intel XE#2850]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2850
[Intel XE#2853]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2853
[Intel XE#2887]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2887
[Intel XE#2893]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2893
[Intel XE#301]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/301
[Intel XE#309]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/309
[Intel XE#3149]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3149
[Intel XE#3297]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3297
[Intel XE#3307]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3307
[Intel XE#3414]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3414
[Intel XE#3432]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3432
[Intel XE#373]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/373
[Intel XE#3904]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3904
[Intel XE#4141]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4141
[Intel XE#4329]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4329
[Intel XE#4354]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4354
[Intel XE#4650]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4650
[Intel XE#4692]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4692
[Intel XE#4733]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4733
[Intel XE#5021]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5021
[Intel XE#5354]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5354
[Intel XE#5848]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5848
[Intel XE#5882]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5882
[Intel XE#5937]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5937
[Intel XE#599]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/599
[Intel XE#6126]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6126
[Intel XE#6127]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6127
[Intel XE#6312]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6312
[Intel XE#6321]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6321
[Intel XE#6503]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6503
[Intel XE#651]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/651
[Intel XE#6540]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6540
[Intel XE#656]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/656
[Intel XE#6569]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6569
[Intel XE#6874]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6874
[Intel XE#688]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/688
[Intel XE#6886]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6886
[Intel XE#6912]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6912
[Intel XE#6964]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6964
[Intel XE#6974]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6974
[Intel XE#7061]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7061
[Intel XE#7084]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7084
[Intel XE#7136]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7136
[Intel XE#7138]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7138
[Intel XE#7140]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7140
[Intel XE#7178]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7178
[Intel XE#7179]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7179
[Intel XE#7283]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7283
[Intel XE#7304]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7304
[Intel XE#7308]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7308
[Intel XE#7325]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7325
[Intel XE#7340]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7340
[Intel XE#7342]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7342
[Intel XE#7343]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7343
[Intel XE#7347]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7347
[Intel XE#7349]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7349
[Intel XE#7351]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7351
[Intel XE#7356]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7356
[Intel XE#7370]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7370
[Intel XE#7372]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7372
[Intel XE#7375]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7375
[Intel XE#7376]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7376
[Intel XE#7377]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7377
[Intel XE#7382]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7382
[Intel XE#7389]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7389
[Intel XE#7393]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7393
[Intel XE#7417]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7417
[Intel XE#7429]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7429
[Intel XE#7437]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7437
[Intel XE#7482]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7482
[Intel XE#7504]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7504
[Intel XE#7508]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7508
[Intel XE#7571]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7571
[Intel XE#7590]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7590
[Intel XE#7636]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7636
[Intel XE#7642]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7642
[Intel XE#7676]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7676
[Intel XE#7679]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7679
[Intel XE#7724]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7724
[Intel XE#776]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/776
[Intel XE#7793]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7793
[Intel XE#7795]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7795
[Intel XE#7865]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7865
[Intel XE#7866]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7866
[Intel XE#7892]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7892
[Intel XE#870]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/870
[Intel XE#944]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/944

Build changes
-------------

* IGT: IGT_8888 -> IGTPW_15102

IGTPW_15102: fd41a765a6c87d118b00e59ee6ac91baec5eca68 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
IGT_8888: 77f31f709ee65bb20ad7d64d8aa012ba7688b112 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-4990-835de80ce9b34b618442ba91483170201b50b553: 835de80ce9b34b618442ba91483170201b50b553

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15102/index.html

#11 lore raw
In reply to Maarten Lankhorst

Hi Maarten,
On 2026-05-05 at 21:44:20 +0200, Maarten Lankhorst wrote:

please remove a dot from end of subject, so it will be:

[PATCH i-g-t 1/4] lib/igt_kms: Add support for the BACKGROUND_COLOR property

+cc Karthik, J-P and Swati

Cc Juha-Pekka Heikkila <[email protected]>
Cc Juha-Pekka Heikkila <[email protected]>
Cc Karthik B S <[email protected]>
Cc Swati Sharma <[email protected]>

Regards,
Kamil

Quoted 49 lines

The background color is a 64-bits property that contains the ARGB values of the background with 16 bits for each component.

Add support for the BACKGROUND_COLOR property, and set to pitch black as the default.

---
 lib/igt_kms.c | 4 ++++
 lib/igt_kms.h | 1 +
 2 files changed, 5 insertions(+)
lib/igt_kms.c +4 -0
index 99fc9fa05c..b70aefe697 100644
@@ -731,6 +731,7 @@ const char * const igt_crtc_prop_names[IGT_NUM_CRTC_PROPS] = {
 	[IGT_CRTC_VRR_ENABLED] = "VRR_ENABLED",
 	[IGT_CRTC_SCALING_FILTER] = "SCALING_FILTER",
 	[IGT_CRTC_SHARPNESS_STRENGTH] = "SHARPNESS_STRENGTH",
+	[IGT_CRTC_BACKGROUND_COLOR] = "BACKGROUND_COLOR",
 };
 
 const char * const igt_connector_prop_names[IGT_NUM_CONNECTOR_PROPS] = {
@@ -2737,6 +2738,9 @@ static void igt_crtc_reset(igt_crtc_t *crtc)
 	if (igt_crtc_has_prop(crtc, IGT_CRTC_SHARPNESS_STRENGTH))
 		igt_crtc_set_prop_value(crtc, IGT_CRTC_SHARPNESS_STRENGTH, 0);
 
+	if (igt_crtc_has_prop(crtc, IGT_CRTC_BACKGROUND_COLOR))
+		igt_crtc_set_prop_value(crtc, IGT_CRTC_BACKGROUND_COLOR, 0xffff000000000000ULL);
+
 	crtc->out_fence_fd = -1;
 }
 
lib/igt_kms.h +1 -0
index a58cb5cd34..71f908d4f5 100644
@@ -165,6 +165,7 @@ enum igt_atomic_crtc_properties {
        IGT_CRTC_VRR_ENABLED,
        IGT_CRTC_SCALING_FILTER,
        IGT_CRTC_SHARPNESS_STRENGTH,
+       IGT_CRTC_BACKGROUND_COLOR,
        IGT_NUM_CRTC_PROPS
 };
 
Signature · 1 line
2.53.0
Reviewed-by on v1 1/4
#12 lore raw
In reply to Maarten Lankhorst

Hi Maarten,

Quoted 41 lines

-----Original Message-----
From: igt-dev <[email protected]> On Behalf Of Maarten Lankhorst
Sent: Wednesday, May 6, 2026 1:14 AM
To: [email protected]
Cc: Maarten Lankhorst <[email protected]>
Subject: [PATCH i-g-t 1/4] lib/igt_kms: Add support for the BACKGROUND_COLOR property.

The background color is a 64-bits property that contains the ARGB values of the background with 16 bits for each component.

Add support for the BACKGROUND_COLOR property, and set to pitch black as the default.

---
 lib/igt_kms.c | 4 ++++
 lib/igt_kms.h | 1 +
 2 files changed, 5 insertions(+)
lib/igt_kms.c +1 -0
@@ -731,6 +731,7 @@ const char * const
 igt_crtc_prop_names[IGT_NUM_CRTC_PROPS] = {
 	[IGT_CRTC_VRR_ENABLED] = "VRR_ENABLED",
 	[IGT_CRTC_SCALING_FILTER] = "SCALING_FILTER",
 	[IGT_CRTC_SHARPNESS_STRENGTH] = "SHARPNESS_STRENGTH",
+	[IGT_CRTC_BACKGROUND_COLOR] = "BACKGROUND_COLOR",
 };
 

const char * const
igt_connector_prop_names[IGT_NUM_CONNECTOR_PROPS] = { @@ -2737,6 +2738,9 @@ static void igt_crtc_reset(igt_crtc_t *crtc)

lib/igt_kms.c +0 -0
 	if (igt_crtc_has_prop(crtc, IGT_CRTC_SHARPNESS_STRENGTH))
 		igt_crtc_set_prop_value(crtc,

IGT_CRTC_SHARPNESS_STRENGTH, 0);

lib/igt_kms.c +2 -0
+	if (igt_crtc_has_prop(crtc, IGT_CRTC_BACKGROUND_COLOR))
+		igt_crtc_set_prop_value(crtc,
Quoted 2 lines

IGT_CRTC_BACKGROUND_COLOR,
+0xffff000000000000ULL);

Imho, add a short inline comment to clarify the channel packing. /* BACKGROUND_COLOR is ARGB16161616; set opaque black (A=0xffff, RGB=0) */

lib/igt_kms.h enum igt_atomic_crtc_properties { · line 168

Quoted 13 lines
lib/igt_kms.c +1 -0
+
 	crtc->out_fence_fd = -1;
 }
lib/igt_kms.h index a58cb5cd34..71f908d4f5 renamed from lib/igt_kms.h +0 -0

100644

lib/igt_kms.h +1 -0
@@ -165,6 +165,7 @@ enum igt_atomic_crtc_properties {
        IGT_CRTC_VRR_ENABLED,
        IGT_CRTC_SCALING_FILTER,
        IGT_CRTC_SHARPNESS_STRENGTH,
+       IGT_CRTC_BACKGROUND_COLOR,

Please use tab for indentation.
Along with Kamil's suggestion, changes LGTM.

Quoted 5 lines
lib/igt_kms.h +0 -1
        IGT_NUM_CRTC_PROPS
 };
 
--

2.53.0

#13 lore raw

Hi Samala,,

Quoted 53 lines · Pranay

Hi Maarten,

Quoted 41 lines

-----Original Message-----
From: igt-dev <[email protected]> On Behalf Of Maarten Lankhorst
Sent: Wednesday, May 6, 2026 1:14 AM
To: [email protected]
Cc: Maarten Lankhorst <[email protected]>
Subject: [PATCH i-g-t 1/4] lib/igt_kms: Add support for the BACKGROUND_COLOR property.

The background color is a 64-bits property that contains the ARGB values of the background with 16 bits for each component.

Add support for the BACKGROUND_COLOR property, and set to pitch black as the default.

---
 lib/igt_kms.c | 4 ++++
 lib/igt_kms.h | 1 +
 2 files changed, 5 insertions(+)
lib/igt_kms.c +1 -0
@@ -731,6 +731,7 @@ const char * const
 igt_crtc_prop_names[IGT_NUM_CRTC_PROPS] = {
 	[IGT_CRTC_VRR_ENABLED] = "VRR_ENABLED",
 	[IGT_CRTC_SCALING_FILTER] = "SCALING_FILTER",
 	[IGT_CRTC_SHARPNESS_STRENGTH] = "SHARPNESS_STRENGTH",
+	[IGT_CRTC_BACKGROUND_COLOR] = "BACKGROUND_COLOR",
 };
 

const char * const
igt_connector_prop_names[IGT_NUM_CONNECTOR_PROPS] = { @@ -2737,6 +2738,9 @@ static void igt_crtc_reset(igt_crtc_t *crtc)

lib/igt_kms.c +0 -0
 	if (igt_crtc_has_prop(crtc, IGT_CRTC_SHARPNESS_STRENGTH))
 		igt_crtc_set_prop_value(crtc,

IGT_CRTC_SHARPNESS_STRENGTH, 0);

lib/igt_kms.c +2 -0
+	if (igt_crtc_has_prop(crtc, IGT_CRTC_BACKGROUND_COLOR))
+		igt_crtc_set_prop_value(crtc,
Quoted 2 lines

IGT_CRTC_BACKGROUND_COLOR,
+0xffff000000000000ULL);

Imho, add a short inline comment to clarify the channel packing. /* BACKGROUND_COLOR is ARGB16161616; set opaque black (A=0xffff, RGB=0) */

Quoted 4 lines
lib/igt_kms.c +1 -0
+
 	crtc->out_fence_fd = -1;
 }
Quoted 11 lines

lib/igt_kms.h enum igt_atomic_crtc_properties { · line 168

Quoted 9 lines
lib/igt_kms.h index a58cb5cd34..71f908d4f5 renamed from lib/igt_kms.h +0 -0

100644

lib/igt_kms.h +1 -0
@@ -165,6 +165,7 @@ enum igt_atomic_crtc_properties {
        IGT_CRTC_VRR_ENABLED,
        IGT_CRTC_SCALING_FILTER,
        IGT_CRTC_SHARPNESS_STRENGTH,
+       IGT_CRTC_BACKGROUND_COLOR,

Please use tab for indentation.

This enum needs a cleanup, it already uses spaces... We could go with spaces for now and a cleanup in a future?

Regards,
Kamil

Quoted 10 lines

Along with Kamil's suggestion, changes LGTM.

Quoted 5 lines
lib/igt_kms.h +0 -1
        IGT_NUM_CRTC_PROPS
 };
 
--

2.53.0

#14 lore raw

Hi Kamil,

Quoted 79 lines

-----Original Message-----
From: Kamil Konieczny <[email protected]>
Sent: Tuesday, May 19, 2026 9:31 PM
To: Samala, Pranay <[email protected]>
Cc: Maarten Lankhorst <[email protected]>; [email protected]
Subject: Re: [PATCH i-g-t 1/4] lib/igt_kms: Add support for the BACKGROUND_COLOR property.

Hi Samala,,

Quoted 35 lines · Pranay

Hi Maarten,

Quoted 33 lines

-----Original Message-----
From: igt-dev <[email protected]> On Behalf Of Maarten Lankhorst
Sent: Wednesday, May 6, 2026 1:14 AM
To: [email protected]
Cc: Maarten Lankhorst <[email protected]>
Subject: [PATCH i-g-t 1/4] lib/igt_kms: Add support for the BACKGROUND_COLOR property.

The background color is a 64-bits property that contains the ARGB values of the background with 16 bits for each component.

Add support for the BACKGROUND_COLOR property, and set to pitch black as the default.

---
 lib/igt_kms.c | 4 ++++
 lib/igt_kms.h | 1 +
 2 files changed, 5 insertions(+)
lib/igt_kms.c index renamed from lib/igt_kms.c +0 -0

99fc9fa05c..b70aefe697 100644

lib/igt_kms.c +1 -0
@@ -731,6 +731,7 @@ const char * const
 igt_crtc_prop_names[IGT_NUM_CRTC_PROPS] = {
 	[IGT_CRTC_VRR_ENABLED] = "VRR_ENABLED",
 	[IGT_CRTC_SCALING_FILTER] = "SCALING_FILTER",
 	[IGT_CRTC_SHARPNESS_STRENGTH] = "SHARPNESS_STRENGTH",
+	[IGT_CRTC_BACKGROUND_COLOR] = "BACKGROUND_COLOR",
 };
 
Quoted 2 lines
Quoted 2 lines

const char * const
igt_connector_prop_names[IGT_NUM_CONNECTOR_PROPS] = { @@ -

2737,6

Quoted 18 lines
Quoted 9 lines

+2738,9 @@ static void igt_crtc_reset(igt_crtc_t *crtc)

lib/igt_kms.c +0 -0
 	if (igt_crtc_has_prop(crtc, IGT_CRTC_SHARPNESS_STRENGTH))
 		igt_crtc_set_prop_value(crtc,

IGT_CRTC_SHARPNESS_STRENGTH, 0);

lib/igt_kms.c +2 -0
+	if (igt_crtc_has_prop(crtc, IGT_CRTC_BACKGROUND_COLOR))
+		igt_crtc_set_prop_value(crtc,

IGT_CRTC_BACKGROUND_COLOR,
+0xffff000000000000ULL);

Imho, add a short inline comment to clarify the channel packing. /* BACKGROUND_COLOR is ARGB16161616; set opaque black (A=0xffff, RGB=0) */

Quoted 4 lines
lib/igt_kms.c +1 -0
+
 	crtc->out_fence_fd = -1;
 }
Quoted 12 lines

lib/igt_kms.h enum igt_atomic_crtc_properties { · line 168

Quoted 10 lines
lib/igt_kms.h index renamed from lib/igt_kms.h +0 -0

a58cb5cd34..71f908d4f5
100644

lib/igt_kms.h +1 -0
@@ -165,6 +165,7 @@ enum igt_atomic_crtc_properties {
        IGT_CRTC_VRR_ENABLED,
        IGT_CRTC_SCALING_FILTER,
        IGT_CRTC_SHARPNESS_STRENGTH,
+       IGT_CRTC_BACKGROUND_COLOR,

Please use tab for indentation.

Quoted 3 lines

This enum needs a cleanup, it already uses spaces... We could go with spaces for now and a cleanup in a future?

Yes, this approach sounds good. We can keep the existing spacing for now, and handle the enum cleanup separately in future.

Regards,
Pranay.

Quoted 13 lines

Regards,
Kamil

Quoted 10 lines

Along with Kamil's suggestion, changes LGTM.

Quoted 5 lines
lib/igt_kms.h +0 -1
        IGT_NUM_CRTC_PROPS
 };
 
--

2.53.0

#15 lore raw
In reply to Samala, Pranay

Den 2026-05-19 kl. 14:07, skrev Samala, Pranay:

Quoted 41 lines

Hi Maarten,

Quoted 39 lines

-----Original Message-----
From: igt-dev <[email protected]> On Behalf Of Maarten Lankhorst
Sent: Wednesday, May 6, 2026 1:14 AM
To: [email protected]
Cc: Maarten Lankhorst <[email protected]>
Subject: [PATCH i-g-t 1/4] lib/igt_kms: Add support for the BACKGROUND_COLOR property.

The background color is a 64-bits property that contains the ARGB values of the background with 16 bits for each component.

Add support for the BACKGROUND_COLOR property, and set to pitch black as the default.

---
 lib/igt_kms.c | 4 ++++
 lib/igt_kms.h | 1 +
 2 files changed, 5 insertions(+)
lib/igt_kms.c +1 -0
@@ -731,6 +731,7 @@ const char * const
 igt_crtc_prop_names[IGT_NUM_CRTC_PROPS] = {
 	[IGT_CRTC_VRR_ENABLED] = "VRR_ENABLED",
 	[IGT_CRTC_SCALING_FILTER] = "SCALING_FILTER",
 	[IGT_CRTC_SHARPNESS_STRENGTH] = "SHARPNESS_STRENGTH",
+	[IGT_CRTC_BACKGROUND_COLOR] = "BACKGROUND_COLOR",
 };
 

const char * const
igt_connector_prop_names[IGT_NUM_CONNECTOR_PROPS] = { @@ -2737,6 +2738,9 @@ static void igt_crtc_reset(igt_crtc_t *crtc)

lib/igt_kms.c +0 -0
 	if (igt_crtc_has_prop(crtc, IGT_CRTC_SHARPNESS_STRENGTH))
 		igt_crtc_set_prop_value(crtc,

IGT_CRTC_SHARPNESS_STRENGTH, 0);

Quoted 8 lines
Quoted 4 lines
lib/igt_kms.c +2 -0
+	if (igt_crtc_has_prop(crtc, IGT_CRTC_BACKGROUND_COLOR))
+		igt_crtc_set_prop_value(crtc,

IGT_CRTC_BACKGROUND_COLOR,
+0xffff000000000000ULL);

Imho, add a short inline comment to clarify the channel packing. /* BACKGROUND_COLOR is ARGB16161616; set opaque black (A=0xffff, RGB=0) */

Using the DRM_ARGB64_PREP() macro directly is likely equally informative. I'll do that instead and reorder patch 1 and 3.

Quoted 18 lines

lib/igt_kms.h enum igt_atomic_crtc_properties { · line 168

Quoted 13 lines
lib/igt_kms.c +1 -0
+
 	crtc->out_fence_fd = -1;
 }
lib/igt_kms.h index a58cb5cd34..71f908d4f5 renamed from lib/igt_kms.h +0 -0

100644

lib/igt_kms.h +1 -0
@@ -165,6 +165,7 @@ enum igt_atomic_crtc_properties {
        IGT_CRTC_VRR_ENABLED,
        IGT_CRTC_SCALING_FILTER,
        IGT_CRTC_SHARPNESS_STRENGTH,
+       IGT_CRTC_BACKGROUND_COLOR,

Please use tab for indentation.
Along with Kamil's suggestion, changes LGTM.

#16 lore raw
In reply to Maarten Lankhorst

Hi Maarten,

Quoted 5 lines · Maarten Lankhorst

The background color is a 64-bits property that contains the ARGB values of the background with 16 bits for each component.

Add support for the BACKGROUND_COLOR property, and set to pitch black as the default.

Did you see the previous attempt at
https://lists.freedesktop.org/archives/igt-dev/2025-December/101222.html
? It unfortunately passed without review.

I think we should take whichever series is best, but it would be great if you could please look at the prior one to see if there's anything your series could gain from that, and equally Cristi if you could please check this one out on VOP2.

Cheers,
Daniel

#17 lore raw

Hi,

Quoted 9 lines · Daniel Stone

Hi Maarten,

Quoted 5 lines · Maarten Lankhorst

The background color is a 64-bits property that contains the ARGB values of the background with 16 bits for each component.

Add support for the BACKGROUND_COLOR property, and set to pitch black as the default.

Quoted 8 lines

Did you see the previous attempt at
https://lists.freedesktop.org/archives/igt-dev/2025-December/101222.html
? It unfortunately passed without review.

I think we should take whichever series is best, but it would be great if you could please look at the prior one to see if there's anything your series could gain from that, and equally Cristi if you could please check this one out on VOP2.

I originally used the USB-C DP AltMode on my ROCK 5B for the initial CRC tests over the DisplayPort AUX channel, but it was always very unstable — the board would frequently fail to detect the display or randomly reset due to various USB-PD/TCPM issues. That was actually one of the main reasons I moved to VKMS-based validation.

Unfortunately, USB-C DP appears to be completely broken on my setup at the moment. It's on my TODO list since I'd like to upstream the CRC support, but it may be a while before I can get it sorted out.

Regards,
Cristian

#18 lore raw
In reply to Daniel Stone

Hey,

Den 2026-05-22 kl. 21:54, skrev Daniel Stone:

Quoted 9 lines

Hi Maarten,

Quoted 5 lines · Maarten Lankhorst

The background color is a 64-bits property that contains the ARGB values of the background with 16 bits for each component.

Add support for the BACKGROUND_COLOR property, and set to pitch black as the default.

Quoted 8 lines

Did you see the previous attempt at
https://lists.freedesktop.org/archives/igt-dev/2025-December/101222.html
? It unfortunately passed without review.

I think we should take whichever series is best, but it would be great if you could please look at the prior one to see if there's anything your series could gain from that, and equally Cristi if you could please check this one out on VOP2.

I checked, the test itself is similar in the big picture.
A few differences I noted:
- kms_crtc_background_color also checks a few more colors and creates a subtest for each color.
- kms_crtc_background_color should probably use igt_display_reset for cleanup.
- kms_crtc_background_color should use igt_crtc_has_prop() in the igt_require
- kms_color version sets the background color to something
else while the plane is shown to ensure background is not visible.
- kms_color uses the definitions from drm_mode.h instead of defining them locally, so that's tested too.

So perhaps I can use the extra colors, perhaps we should test some values other than 0xffff too, and perhaps use X2R10G10B10 if available. I intend not to create a subtest as debug logs will be enough to determine the value of the failing different color.

The changes I made here are a bit more generic as they will catch failures when header definitions are updated incorrectly too.

I believe this version is slightly better, but both would work in theory.

Kind regards,
~Maarten Lankhorst