Skip to contentSkip to conversation

cpufreq.c: add new test for cpufreq sysfs interface validation

PATCH Superseded Piotr Kubaj 2 participants 2 messages May 6

v7 of 9 Superseded Latest is v9 →

lore
Share & tools
lore
#0 lore raw

PATCH v7 1/1 cpufreq.c: add new test for cpufreq sysfs interface validation

Runs various sanity checks for intel_pstate cpufreq sysfs interface.

Checks whether intel_pstate driver is used, whether it is possible to switch scaling_governor to powersave and performance, whether it is possible to disable turbo frequency and whether it is possible to change scaling_min_freq and scaling_max_freq to its minimal valid and maximal valid values.

---
Address review to fix -i 2 runs.

 runtest/power_management_tests               |   1 +
 testcases/kernel/power_management/.gitignore |   1 +
 testcases/kernel/power_management/cpufreq.c  | 413 +++++++++++++++++++
 3 files changed, 415 insertions(+)
 create mode 100644 testcases/kernel/power_management/.gitignore
 create mode 100644 testcases/kernel/power_management/cpufreq.c
runtest/power_management_tests +1 -0
index b670da6ec..0bc7dd0c8 100644
@@ -1,4 +1,5 @@
 #POWER_MANAGEMENT
+cpufreq cpufreq
 runpwtests03 runpwtests03.sh
 runpwtests04 runpwtests04.sh
 runpwtests06 runpwtests06.sh
testcases/kernel/power_management/.gitignore new file +1 -0
new file mode 100644
index 000000000..7f34e4c2f
@@ -0,0 +1 @@
+cpufreq
testcases/kernel/power_management/cpufreq.c new file +413 -0

413 lines not on this page · raw message

Signature · 13 lines
2.47.3

---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Hi Piotr,

Quoted 4 lines · Piotr Kubaj

cpufreq.c: add new test for cpufreq sysfs interface validation

Runs various sanity checks for intel_pstate cpufreq sysfs interface. [...]

The commit body describes what the test does but not why it is needed. The motivation ("LTP has no regression coverage for the intel_pstate cpufreq sysfs interface...") belongs in the commit body, not only in the in-source doc comment.

testcases/kernel/power_management/cpufreq.c line 164

Quoted 3 lines
testcases/kernel/power_management/cpufreq.c new file +3 -0
+	fd = SAFE_OPEN(path, O_RDONLY);
+	SAFE_READ(0, fd, contents, sizeof(contents));
+	SAFE_CLOSE(fd);

If SAFE_READ fails it calls tst_brk(), skipping SAFE_CLOSE(). cleanup() has no fd handling so the descriptor leaks. Use SAFE_FILE_SCANF() instead. This pattern appears twice (~line 184 and ~line 298).

Quoted 1 line

+static bool setup_done;

[...]

testcases/kernel/power_management/cpufreq.c line 107

Quoted 1 line
testcases/kernel/power_management/cpufreq.c new file +1 -0
+	setup_done = true;

setup_done is never reset in cleanup(). With -i, a partial setup failure on a later iteration sees stale 'true' and incorrectly enters the restore path. Reset it at the start of setup() or end of cleanup().

---
Note:

Our agent completed the review of the patch. The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp