Skip to contentSkip to conversation

futex: Add error coverage tests for wait, wake and cmp_requeue

PATCH In review Michael Menasherov via ltp 2 participants 6 messages May 6

lore
Share & tools
lore
#0 lore raw

v2 cover futex: Add error coverage tests for wait, wake and cmp_requeue

Improve error handling coverage for futex syscalls by adding tests for missing error conditions that were previously untested.

futex_wait06 verifies EFAULT is returned when uaddr or timeout points to unmapped memory.

futex_wait07 verifies EINTR is returned when futex_wait() is interrupted by a signal.

futex_wake05 verifies EFAULT is returned when uaddr points to unmapped or PROT_NONE memory.

futex_cmp_requeue03 verifies EFAULT is returned when uaddr or uaddr2 points to unmapped memory, and EACCES or EFAULT when uaddr points to memory without read permission (PROT_NONE). The EACCES behavior was introduced in kernel 5.9.

v2:
- Rebased on latest master
- Added [ltp] subject prefix
- Split into one patch per test case

Michael Menasherov (4):
futex_wait06: Add EFAULT error coverage test
futex_wait07: Add EINTR error coverage test
futex_wake05: Add EFAULT error coverage test
futex_cmp_requeue03: Add EFAULT and EACCES error coverage test

 runtest/syscalls                              |  4 +
 testcases/kernel/syscalls/futex/.gitignore    |  4 +
 .../syscalls/futex/futex_cmp_requeue03.c      | 96 +++++++++++++++++++
 .../kernel/syscalls/futex/futex_wait06.c      | 73 ++++++++++++++
 .../kernel/syscalls/futex/futex_wait07.c      | 91 ++++++++++++++++++
 .../kernel/syscalls/futex/futex_wake05.c      | 86 +++++++++++++++++
 6 files changed, 354 insertions(+)
 create mode 100644 testcases/kernel/syscalls/futex/futex_cmp_requeue03.c
 create mode 100644 testcases/kernel/syscalls/futex/futex_wait06.c
 create mode 100644 testcases/kernel/syscalls/futex/futex_wait07.c
 create mode 100644 testcases/kernel/syscalls/futex/futex_wake05.c
Signature · 5 lines
2.53.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

PATCH v2 1/4 futex_wait06: Add EFAULT error coverage test

---
 runtest/syscalls                              |  1 +
 testcases/kernel/syscalls/futex/.gitignore    |  1 +
 .../kernel/syscalls/futex/futex_wait06.c      | 73 +++++++++++++++++++
 3 files changed, 75 insertions(+)
 create mode 100644 testcases/kernel/syscalls/futex/futex_wait06.c
runtest/syscalls +1 -0
index df5dc02b5..621355e04 100644
@@ -1905,3 +1905,4 @@ io_uring03 io_uring03
 
 # Tests below may cause kernel memory leak
 perf_event_open03 perf_event_open03
+futex_wait06 futex_wait06
testcases/kernel/syscalls/futex/.gitignore +1 -0
index 9d08ba7d3..56596dcb4 100644
@@ -13,3 +13,4 @@
 /futex_waitv01
 /futex_waitv02
 /futex_waitv03
+/futex_wait06
testcases/kernel/syscalls/futex/futex_wait06.c new file +73 -0

73 lines not on this page · raw message

Signature · 5 lines
2.53.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw

Re: [LTP] futex_wait06: Add EFAULT error coverage test

Hi Michael,

All four patches are missing a commit body and Signed-off-by tag. Please add at least one sentence explaining why each test is being added (gap in coverage, related kernel change, regression, etc.), and add your Signed-off-by trailer to each commit.

--- [PATCH 4/4] ---

Review

Quoted 5 lines · Michael Menasherov

futex_cmp_requeue03: Add EFAULT and EACCES error coverage test

+ * The EACCES behavior for PROT_NONE was introduced in kernel 5.9.

(quoted diff) +1 -0
+		.exp_errno = tst_kvercmp(5, 9, 0) >= 0 ? EACCES : EFAULT,

I cannot find a kernel code path that returns -EACCES for a PROT_NONE futex address. get_futex_key() in kernel/futex/core.c returns -EFAULT when get_user_pages_fast() fails on an inaccessible page, regardless of whether the failure is due to unmapped or PROT_NONE memory. Please cite the specific kernel commit that introduced this behaviour, or replace the conditional with unconditional EFAULT.

[...]

---
Note:

Our agent completed the review of the patch. The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#3 lore raw

PATCH v2 2/4 futex_wait07: Add EINTR error coverage test

In reply to Michael Menasherov via ltp
---
 runtest/syscalls                              |  1 +
 testcases/kernel/syscalls/futex/.gitignore    |  1 +
 .../kernel/syscalls/futex/futex_wait07.c      | 91 +++++++++++++++++++
 3 files changed, 93 insertions(+)
 create mode 100644 testcases/kernel/syscalls/futex/futex_wait07.c
runtest/syscalls +1 -0
index 621355e04..75b7754db 100644
@@ -1906,3 +1906,4 @@ io_uring03 io_uring03
 # Tests below may cause kernel memory leak
 perf_event_open03 perf_event_open03
 futex_wait06 futex_wait06
+futex_wait07 futex_wait07
testcases/kernel/syscalls/futex/.gitignore +1 -0
index 56596dcb4..74ac9a926 100644
@@ -14,3 +14,4 @@
 /futex_waitv02
 /futex_waitv03
 /futex_wait06
+/futex_wait07
testcases/kernel/syscalls/futex/futex_wait07.c new file +91 -0

91 lines not on this page · raw message

Signature · 5 lines
2.53.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#4 lore raw

PATCH v2 3/4 futex_wake05: Add EFAULT error coverage test

In reply to Michael Menasherov via ltp
---
 runtest/syscalls                              |  1 +
 testcases/kernel/syscalls/futex/.gitignore    |  1 +
 .../kernel/syscalls/futex/futex_wake05.c      | 86 +++++++++++++++++++
 3 files changed, 88 insertions(+)
 create mode 100644 testcases/kernel/syscalls/futex/futex_wake05.c
runtest/syscalls +1 -0
index 75b7754db..4d85a1d26 100644
@@ -1907,3 +1907,4 @@ io_uring03 io_uring03
 perf_event_open03 perf_event_open03
 futex_wait06 futex_wait06
 futex_wait07 futex_wait07
+futex_wake05 futex_wake05
testcases/kernel/syscalls/futex/.gitignore +1 -0
index 74ac9a926..c11546e07 100644
@@ -15,3 +15,4 @@
 /futex_waitv03
 /futex_wait06
 /futex_wait07
+/futex_wake05
testcases/kernel/syscalls/futex/futex_wake05.c new file +86 -0

86 lines not on this page · raw message

Signature · 5 lines
2.53.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#5 lore raw

PATCH v2 4/4 futex_cmp_requeue03: Add EFAULT and EACCES error coverage test

In reply to Michael Menasherov via ltp
---
 runtest/syscalls                              |  1 +
 testcases/kernel/syscalls/futex/.gitignore    |  1 +
 .../syscalls/futex/futex_cmp_requeue03.c      | 96 +++++++++++++++++++
 3 files changed, 98 insertions(+)
 create mode 100644 testcases/kernel/syscalls/futex/futex_cmp_requeue03.c
runtest/syscalls +1 -0
index 4d85a1d26..65baa44dc 100644
@@ -1908,3 +1908,4 @@ perf_event_open03 perf_event_open03
 futex_wait06 futex_wait06
 futex_wait07 futex_wait07
 futex_wake05 futex_wake05
+futex_cmp_requeue03 futex_cmp_requeue03
testcases/kernel/syscalls/futex/.gitignore +1 -0
index c11546e07..231b6bd25 100644
@@ -16,3 +16,4 @@
 /futex_wait06
 /futex_wait07
 /futex_wake05
+/futex_cmp_requeue03
testcases/kernel/syscalls/futex/futex_cmp_requeue03.c new file +96 -0

96 lines not on this page · raw message

Signature · 5 lines
2.53.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp