Skip to contentSkip to conversation

io_uring: Add io_uring04 test for vectored I/O operations

PATCH Superseded Sachin Sant 2 participants 5 messages May 6

lore
Share & tools
lore
#0 lore raw

PATCH v7 1/4 io_uring: Add io_uring04 test for vectored I/O operations

Add new test case io_uring04.c to validate IORING_OP_READV and IORING_OP_WRITEV operations with uniform buffer sizes.

Test performs:
- Vectored write using multiple uniform buffers (4 x 1024 bytes)
- Vectored read back into multiple uniform buffers
- Data integrity verification across all vectors

Also add helper functions to io_uring_common.h:
- io_uring_init_iovec_pattern(): Initialize iovec buffers with patterns
- io_uring_clear_iovec(): Clear iovec buffers by zeroing data
- io_uring_verify_iovec(): Verify data integrity between write/read iovecs

Update runtest/syscalls and .gitignore to include the new test.

---
V6 changes:
- Split io_uring04.c into 3 independent tests
- Linux to v5 https://lore.kernel.org/ltp/[email protected]/T/#t

V5 changes:
- Add clear_iovec_buffers() at the top of run()
- Link to v4 https://lore.kernel.org/ltp/[email protected]/T/

V4 changes:
- Updated commit message to remove references to non-existent function
- Removed extra blank line before test_writev_readv()
- Link to v3 https://lore.kernel.org/ltp/[email protected]/T/

V3 changes (2/3 io_uring04 only):
- 1/3 and 3/3 from the patch series already merged.
- Merged prepare_read_buffers() and clear_iovec_buffers() into
single clear_iovec_buffers() function
- Merged io_uring_init_buffer_pattern() into unified
init_iovec_buffers() function that supports both rotating and
simple character patterns
- Removed io_uring_init_buffer_pattern() from io_uring_common.h as it's
only used in io_uring04.c
- Link to V2: https://lore.kernel.org/ltp/[email protected]/T/

V2 changes:
- Use guarded buffer(including iovec) allocation
- Move setup/cleanup code from run to appropriate path
- Add a function to map the OP to the enum name
- Define and use generic cleanup functions
- Add a buffer size 0 in the middle of the iovec
- Simplify setup_io_uring_test to use common code.
- Link to V1: https://lore.kernel.org/ltp/[email protected]/T/#t

Changes after RFC patch series:
- Addressed review comments
- Refactored io_uring01 test to use common code
- Removed git tags
- Link to RFC: https://lore.kernel.org/ltp/[email protected]/T/#t

---
 runtest/syscalls                              |  1 +
 testcases/kernel/syscalls/io_uring/.gitignore |  1 +
 .../kernel/syscalls/io_uring/io_uring04.c     | 84 ++++++++++++++++++
 .../syscalls/io_uring/io_uring_common.h       | 86 +++++++++++++++++++
 4 files changed, 172 insertions(+)
 create mode 100644 testcases/kernel/syscalls/io_uring/io_uring04.c
runtest/syscalls +1 -0
index f790e8f84..6b047b5fd 100644
@@ -1904,6 +1904,7 @@ membarrier01 membarrier01
 io_uring01 io_uring01
 io_uring02 io_uring02
 io_uring03 io_uring03
+io_uring04 io_uring04
 
 # Tests below may cause kernel memory leak
 perf_event_open03 perf_event_open03
testcases/kernel/syscalls/io_uring/.gitignore +1 -0
index 9382ae413..36cd24662 100644
@@ -1,3 +1,4 @@
 /io_uring01
 /io_uring02
 /io_uring03
+/io_uring04
testcases/kernel/syscalls/io_uring/io_uring04.c new file +84 -0

84 lines not on this page · raw message

testcases/kernel/syscalls/io_uring/io_uring_common.h +86 -0

90 lines not on this page · raw message

Signature · 5 lines
2.39.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

PATCH 2/4 syscalls/io_uring: Add test for partial vector operations

Add new test case io_uring05.c to validate vectored I/O operations using partial vector sets with different file offsets.

The test performs:
- IORING_OP_WRITEV: Write first half using first 2 vectors at offset 0
- IORING_OP_WRITEV: Write second half using next 2 vectors at offset 2048
- IORING_OP_READV: Read entire file using all 4 vectors
- Data integrity verification across all vectors

This validates that io_uring correctly handles partial vector operations and maintains data integrity when using different vector subsets with specific file offsets.

---
 runtest/syscalls                              |  1 +
 testcases/kernel/syscalls/io_uring/.gitignore |  1 +
 .../kernel/syscalls/io_uring/io_uring05.c     | 94 +++++++++++++++++++
 3 files changed, 96 insertions(+)
 create mode 100644 testcases/kernel/syscalls/io_uring/io_uring05.c
runtest/syscalls +1 -0
index 6b047b5fd..bab0e8f3b 100644
@@ -1905,6 +1905,7 @@ io_uring01 io_uring01
 io_uring02 io_uring02
 io_uring03 io_uring03
 io_uring04 io_uring04
+io_uring05 io_uring05
 
 # Tests below may cause kernel memory leak
 perf_event_open03 perf_event_open03
testcases/kernel/syscalls/io_uring/.gitignore +1 -0
index 36cd24662..bce7048cd 100644
@@ -2,3 +2,4 @@
 /io_uring02
 /io_uring03
 /io_uring04
+/io_uring05
testcases/kernel/syscalls/io_uring/io_uring05.c new file +94 -0

94 lines not on this page · raw message

Signature · 5 lines
2.39.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw

PATCH 3/4 io_uring: Add test for varying buffer sizes with zero-length buffer

In reply to Sachin Sant

Add io_uring06 test to validate vectored I/O operations (IORING_OP_READV and IORING_OP_WRITEV) with non-uniform buffer sizes including a zero-length buffer.

The test verifies:
- Writing data using iovec with varying sizes (512, 0, 1024, 256 bytes)
- Reading data back into buffers of the same varying sizes
- Data integrity verification with zero-length buffer handling
- Proper handling of iovec arrays with mixed buffer sizes

This test ensures the kernel correctly handles zero-length buffers in vectored I/O operations, which is important for applications that may dynamically construct iovec arrays.

---
 runtest/syscalls                              |  1 +
 testcases/kernel/syscalls/io_uring/.gitignore |  1 +
 .../kernel/syscalls/io_uring/io_uring06.c     | 97 +++++++++++++++++++
 3 files changed, 99 insertions(+)
 create mode 100644 testcases/kernel/syscalls/io_uring/io_uring06.c
runtest/syscalls +1 -0
index bab0e8f3b..fc4892221 100644
@@ -1906,6 +1906,7 @@ io_uring02 io_uring02
 io_uring03 io_uring03
 io_uring04 io_uring04
 io_uring05 io_uring05
+io_uring06 io_uring06
 
 # Tests below may cause kernel memory leak
 perf_event_open03 perf_event_open03
testcases/kernel/syscalls/io_uring/.gitignore +1 -0
index bce7048cd..dfe7cca5a 100644
@@ -3,3 +3,4 @@
 /io_uring03
 /io_uring04
 /io_uring05
+/io_uring06
testcases/kernel/syscalls/io_uring/io_uring06.c new file +97 -0

97 lines not on this page · raw message

Signature · 5 lines
2.39.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#3 lore raw

PATCH 4/4 io_uring: remove unused io_uring_init_buffer_pattern()

In reply to Sachin Sant

The io_uring04 test merged the functionality of io_uring_init_buffer_pattern() into the unified function io_uring_init_iovec_buffers(). Since io_uring_init_buffer_pattern() is not used by any existing test, remove it.

---
 .../kernel/syscalls/io_uring/io_uring_common.h      | 13 -------------
 1 file changed, 13 deletions(-)
testcases/kernel/syscalls/io_uring/io_uring_common.h +0 -13
index 523f686f8..84f93c7b1 100644
@@ -230,19 +230,6 @@ static inline void io_uring_wait_cqe(struct io_uring_submit *s,
 	*cring->head = head + 1;
 }
 
-/*
- * Initialize buffer with a repeating character pattern
- * Useful for creating test data with predictable patterns
- */
-static inline void io_uring_init_buffer_pattern(char *buf, size_t size,
-						char pattern)
-{
-	size_t i;
-
-	for (i = 0; i < size; i++)
-		buf[i] = pattern;
-}
-
 /*
  * Submit and wait for a non-vectored I/O operation
  * Combines io_uring_submit_sqe() and io_uring_wait_cqe() with result reporting
Signature · 5 lines
2.39.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#4 lore raw
In reply to Sachin Sant

Hi Sachin,

--- [PATCH 2/4] ---

Quoted 1 line · Sachin Sant

syscalls/io_uring: Add test for partial vector operations

Nit: the subject prefix "syscalls/io_uring:" should be "io_uring:" to match the rest of the series.

--- [PATCH 4/4] ---

Quoted 5 lines · Sachin Sant

io_uring: remove unused io_uring_init_buffer_pattern()

The io_uring04 test merged the functionality of io_uring_init_buffer_pattern() into the unified function io_uring_init_iovec_buffers().

The function name is wrong here. The replacement function introduced in this series is io_uring_init_iovec_pattern(), not io_uring_init_iovec_buffers() (which does not exist).

--- [PATCH 1/4, 2/4, 3/4] ---

testcases/kernel/syscalls/io_uring/io_uring04.c line 35

Quoted 5 lines · Sachin Sant
testcases/kernel/syscalls/io_uring/io_uring04.c new file +5 -0
+static void run(void)
+{
+	int fd = -1;
+	...
+	fd = SAFE_OPEN(TEST_FILE, O_RDWR | O_CREAT | O_TRUNC, 0644);

fd is a local variable; if tst_brk() fires between SAFE_OPEN and SAFE_CLOSE (e.g. inside io_uring_do_vec_io_op or SAFE_FSYNC), cleanup() has no reference to it and cannot close it. Declare fd as static int fd = -1 at file scope, reset it at the top of run(), and close it in cleanup() if >= 0. Applies to all three new test files.

Quoted 3 lines

+/*\
+ *
+ * Test partial vector operations with IORING_OP_READV and IORING_OP_WRITEV.

(io_uring05.c, io_uring06.c) Extra blank line after /*\; the description must start on the very next line. See io_uring04.c for the correct style.

---
Note:

Our agent completed the review of the patch. The full review can be found at: https://github.com/linux-test-project/ltp-agent/actions/runs/25458989491

The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp