xfs/216: pass -t xfs to _mount
PATCH 1/1 xfs/216: pass -t xfs to _mount
Without this, mount probes different file system type, which ended up exposing kernel bugs in blocksize > PAGE_SIZE bugs in tons of legacy file systems. Bypass that by forcing XFS and making the mount a little more efficient.
--- tests/xfs/216 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/xfs/216 +1 -1
@@ -57,7 +57,7 @@ _do_mkfs() echo -n "fssize=${i}g " $MKFS_XFS_PROG -f -b size=4096 -l version=2 \ -d size=${i}g $loop_mkfs_opts $loop_dev |grep log - _mount $loop_dev $LOOP_MNT + _mount -t xfs $loop_dev $LOOP_MNT echo "test write" > $LOOP_MNT/test _unmount $LOOP_MNT > /dev/null 2>&1 done
Signature · 1 line
2.53.0
Quoted 6 lines · Christoph Hellwig
Without this, mount probes different file system type, which ended up exposing kernel bugs in blocksize >
PAGE_SIZEbugs in tons of legacy file systems. Bypass that by forcing XFS and making the mount a little more efficient.Signed-off-by Christoph Hellwig <[email protected]>
Looks good to me
Signature · 1 line
- Andrey
Quoted 7 lines · Christoph Hellwig
Without this, mount probes different file system type, which ended up exposing kernel bugs in blocksize >
PAGE_SIZEbugs in tons of legacy file systems. Bypass that by forcing XFS and making the mount a little more efficient.Signed-off-by Christoph Hellwig <[email protected]>---
This change makes sense to me, thanks for fixing one more lbs testing failure.
Quoted 19 lines
tests/xfs/216 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/xfs/216 +1
-1@@ -57,7 +57,7 @@ _do_mkfs() echo -n "fssize=${i}g " $MKFS_XFS_PROG -f -b size=4096 -l version=2 \ -d size=${i}g $loop_mkfs_opts $loop_dev |grep log - _mount $loop_dev $LOOP_MNT + _mount -t xfs $loop_dev $LOOP_MNT echo "test write" > $LOOP_MNT/test _unmount $LOOP_MNT > /dev/null 2>&1 doneSignature · 1 line
2.53.0