Linux 6.18.27

index 19470d938b23..4d7ef5cc36b6 100644
@@ -304,8 +304,10 @@ void __sync_icache_dcache(pte_t pteval)
 	else
 		mapping = NULL;
 
-	if (!test_and_set_bit(PG_dcache_clean, &folio->flags.f))
+	if (!test_bit(PG_dcache_clean, &folio->flags.f)) {
 		__flush_dcache_folio(mapping, folio);
+		set_bit(PG_dcache_clean, &folio->flags.f);
+	}
 
 	if (pte_exec(pteval))
 		__flush_icache_all();

index 78a4dbf75e60..c5d187769c6c 100644
@@ -112,5 +112,7 @@ void kpti_install_ng_mappings(void);
 static inline void kpti_install_ng_mappings(void) {}
 #endif
 
+extern bool page_alloc_available;
+
 #endif	/* !__ASSEMBLY__ */
 #endif

index 524d34a0e921..341ae4f15845 100644
@@ -357,7 +357,6 @@ void __init arch_mm_preinit(void)
 	}
 
 	swiotlb_init(swiotlb, flags);
-	swiotlb_update_mem_attributes();
 
 	/*
 	 * Check boundaries twice: Some fundamental inconsistencies can be

@@ -384,6 +383,14 @@ void __init arch_mm_preinit(void)
 	}
 }
 
+bool page_alloc_available __ro_after_init;
+
+void __init mem_init(void)
+{
+	page_alloc_available = true;
+	swiotlb_update_mem_attributes();
+}
+
 void free_initmem(void)
 {
 	void *lm_init_begin = lm_alias(__init_begin);

156 lines not on this page · raw message

index a2060a24b39f..4ac9c9599167 100644
@@ -7,6 +7,7 @@
 #include <linux/init.h>
 #include <linux/kernel.h>
 #include <linux/ptrace.h>
+#include <linux/cpu.h>
 #include <linux/smp.h>
 #include <linux/stddef.h>
 #include <linux/export.h>

@@ -387,3 +388,9 @@ void cpu_probe(void)
 
 	cpu_report();
 }
+
+ssize_t cpu_show_spectre_v1(struct device *dev,
+			    struct device_attribute *attr, char *buf)
+{
+	return sysfs_emit(buf, "Mitigation: __user pointer sanitization\n");
+}

index 168bd97540f8..d0257935078e 100644
@@ -9,6 +9,7 @@
 #include <linux/entry-common.h>
 #include <linux/errno.h>
 #include <linux/linkage.h>
+#include <linux/nospec.h>
 #include <linux/objtool.h>
 #include <linux/randomize_kstack.h>
 #include <linux/syscalls.h>

@@ -61,7 +62,7 @@ void noinstr __no_stack_protector do_syscall(struct pt_regs *regs)
 	add_random_kstack_offset();
 
 	if (nr < NR_syscalls) {
-		syscall_fn = sys_call_table[nr];
+		syscall_fn = sys_call_table[array_index_nospec(nr, NR_syscalls)];
 		regs->regs[4] = syscall_fn(regs->orig_a0, regs->regs[5], regs->regs[6],
 					   regs->regs[7], regs->regs[8], regs->regs[9]);
 	}

index 14bd36597ab3..a7510b403f52 100644
@@ -375,7 +375,7 @@ bool kvm_arch_vcpu_in_kernel(struct kvm_vcpu *vcpu)
 	val = gcsr_read(LOONGARCH_CSR_CRMD);
 	preempt_enable();
 
-	return (val & CSR_PRMD_PPLV) == PLV_KERN;
+	return (val & CSR_CRMD_PLV) == PLV_KERN;
 }
 
 #ifdef CONFIG_GUEST_PERF_EVENTS

101 lines not on this page · raw message

99 lines not on this page · raw message

index 29b46581ddd1..dc1d1bcd85ec 100644
@@ -15,6 +15,12 @@
 #include "cow.h"
 #include "cow_sys.h"
 
+/*
+ * arch/um/Makefile remaps strrchr to kernel_strrchr; call the kernel
+ * name directly to avoid glibc >= 2.43's C23 strrchr macro.
+ */
+char *kernel_strrchr(const char *, int);
+
 #define PATH_LEN_V1 256
 
 /* unsigned time_t works until year 2106 */

@@ -153,7 +159,7 @@ static int absolutize(char *to, int size, char *from)
 			   errno);
 		return -1;
 	}
-	slash = strrchr(from, '/');
+	slash = kernel_strrchr(from, '/');
 	if (slash != NULL) {
 		*slash = '\0';
 		if (chdir(from)) {

69 lines not on this page · raw message

index 6ce160ffa678..6301f79fcbae 100644
@@ -305,14 +305,6 @@ static inline bool kvm_hv_has_stimer_pending(struct kvm_vcpu *vcpu)
 {
 	return false;
 }
-static inline bool kvm_hv_is_tlb_flush_hcall(struct kvm_vcpu *vcpu)
-{
-	return false;
-}
-static inline bool guest_hv_cpuid_has_l2_tlb_flush(struct kvm_vcpu *vcpu)
-{
-	return false;
-}
 static inline int kvm_hv_verify_vp_assist(struct kvm_vcpu *vcpu)
 {
 	return 0;

index d3f8bfc05832..f70d076911a6 100644
@@ -41,10 +41,17 @@ static inline bool nested_svm_l2_tlb_flush_enabled(struct kvm_vcpu *vcpu)
 	return hv_vcpu->vp_assist_page.nested_control.features.directhypercall;
 }
 
+static inline bool nested_svm_is_l2_tlb_flush_hcall(struct kvm_vcpu *vcpu)
+{
+	return guest_hv_cpuid_has_l2_tlb_flush(vcpu) &&
+	       nested_svm_l2_tlb_flush_enabled(vcpu) &&
+	       kvm_hv_is_tlb_flush_hcall(vcpu);
+}
+
 void svm_hv_inject_synthetic_vmexit_post_tlb_flush(struct kvm_vcpu *vcpu);
 #else /* CONFIG_KVM_HYPERV */
 static inline void nested_svm_hv_update_vm_vp_ids(struct kvm_vcpu *vcpu) {}
-static inline bool nested_svm_l2_tlb_flush_enabled(struct kvm_vcpu *vcpu)
+static inline bool nested_svm_is_l2_tlb_flush_hcall(struct kvm_vcpu *vcpu)
 {
 	return false;
 }

380 lines not on this page · raw message

219 lines not on this page · raw message

index e66a16e59b1a..54e30b08801f 100644
@@ -142,6 +142,7 @@ struct kvm_vmcb_info {
 };
 
 struct vmcb_save_area_cached {
+	struct vmcb_seg cs;
 	u64 efer;
 	u64 cr4;
 	u64 cr3;

@@ -688,8 +689,16 @@ static inline void *svm_vcpu_alloc_msrpm(void)
 	return svm_alloc_permissions_map(MSRPM_SIZE, GFP_KERNEL_ACCOUNT);
 }
 
+#define svm_copy_lbrs(to, from)					\
+do {								\
+	(to)->dbgctl		= (from)->dbgctl;		\
+	(to)->br_from		= (from)->br_from;		\
+	(to)->br_to		= (from)->br_to;		\
+	(to)->last_excp_from	= (from)->last_excp_from;	\
+	(to)->last_excp_to	= (from)->last_excp_to;		\
+} while (0)
+
 void svm_vcpu_free_msrpm(void *msrpm);
-void svm_copy_lbrs(struct vmcb *to_vmcb, struct vmcb *from_vmcb);
 void svm_enable_lbrv(struct kvm_vcpu *vcpu);
 void svm_update_lbrv(struct kvm_vcpu *vcpu);
 

108 lines not on this page · raw message

index b10d4d131dce..af9176968fa2 100644
@@ -105,6 +105,11 @@ void __init pti_check_boottime_disable(void)
 		pr_debug("PTI enabled, disabling INVLPGB\n");
 		setup_clear_cpu_cap(X86_FEATURE_INVLPGB);
 	}
+
+	if (cpu_feature_enabled(X86_FEATURE_FRED)) {
+		pr_debug("PTI enabled, disabling FRED\n");
+		setup_clear_cpu_cap(X86_FEATURE_FRED);
+	}
 }
 
 static int __init pti_parse_cmdline(char *arg)

index bed26f1ec869..12d887349c26 100644
@@ -128,10 +128,10 @@ int bio_integrity_add_page(struct bio *bio, struct page *page,
 	if (bip->bip_vcnt > 0) {
 		struct bio_vec *bv = &bip->bip_vec[bip->bip_vcnt - 1];
 
-		if (!zone_device_pages_have_same_pgmap(bv->bv_page, page))
+		if (!zone_device_pages_compatible(bv->bv_page, page))
 			return 0;
-
-		if (bvec_try_merge_hw_page(q, bv, page, len, offset)) {
+		if (zone_device_pages_have_same_pgmap(bv->bv_page, page) &&
+		    bvec_try_merge_hw_page(q, bv, page, len, offset)) {
 			bip->bip_iter.bi_size += len;
 			return len;
 		}

index b3a79285c278..b184f0a3fcb2 100644
@@ -1030,10 +1030,10 @@ int bio_add_page(struct bio *bio, struct page *page,
 	if (bio->bi_vcnt > 0) {
 		struct bio_vec *bv = &bio->bi_io_vec[bio->bi_vcnt - 1];
 
-		if (!zone_device_pages_have_same_pgmap(bv->bv_page, page))
+		if (!zone_device_pages_compatible(bv->bv_page, page))
 			return 0;
-
-		if (bvec_try_merge_page(bv, page, len, offset)) {
+		if (zone_device_pages_have_same_pgmap(bv->bv_page, page) &&
+		    bvec_try_merge_page(bv, page, len, offset)) {
 			bio->bi_iter.bi_size += len;
 			return len;
 		}

index 0c812f3bd7df..e98bd9ad0232 100644
@@ -801,13 +801,17 @@ static void disk_zone_wplug_schedule_bio_work(struct gendisk *disk,
 					      struct blk_zone_wplug *zwplug)
 {
 	/*
-	 * Take a reference on the zone write plug and schedule the submission
-	 * of the next plugged BIO. blk_zone_wplug_bio_work() will release the
-	 * reference we take here.
+	 * Schedule the submission of the next plugged BIO. Taking a reference
+	 * to the zone write plug is required as the bio_work belongs to the
+	 * plug, and thus we must ensure that the write plug does not go away
+	 * while the work is being scheduled but has not run yet.
+	 * blk_zone_wplug_bio_work() will release the reference we take here,
+	 * and we also drop this reference if the work is already scheduled.
 	 */
 	WARN_ON_ONCE(!(zwplug->flags & BLK_ZONE_WPLUG_PLUGGED));
 	refcount_inc(&zwplug->ref);
-	queue_work(disk->zone_wplugs_wq, &zwplug->bio_work);
+	if (!queue_work(disk->zone_wplugs_wq, &zwplug->bio_work))
+		disk_put_zone_wplug(zwplug);
 }
 
 static inline void disk_zone_wplug_add_bio(struct gendisk *disk,

index 06dfb5b67017..80a6a942a10a 100644
@@ -139,6 +139,25 @@ static inline bool biovec_phys_mergeable(struct request_queue *q,
 	return true;
 }
 
+/*
+ * Check if two pages from potentially different zone device pgmaps can
+ * coexist as separate bvec entries in the same bio.
+ *
+ * The block DMA iterator (blk_dma_map_iter_start) caches the P2PDMA mapping
+ * state from the first segment and applies it to all subsequent segments, so
+ * P2PDMA pages from different pgmaps must not be mixed in the same bio.
+ *
+ * Other zone device types (FS_DAX, GENERIC) use the same dma_map_phys() path
+ * as normal RAM.  PRIVATE and COHERENT pages never appear in bios.
+ */
+static inline bool zone_device_pages_compatible(const struct page *a,
+						const struct page *b)
+{
+	if (is_pci_p2pdma_page(a) || is_pci_p2pdma_page(b))
+		return zone_device_pages_have_same_pgmap(a, b);
+	return true;
+}
+
 static inline bool __bvec_gap_to_prev(const struct queue_limits *lim,
 		struct bio_vec *bprv, unsigned int offset)
 {

index 7d6d468ed612..54ecd1024274 100644
@@ -43,7 +43,9 @@ void format(void)
 	exit(2);
 }
 
+#ifdef USE_PKCS11_ENGINE
 static const char *key_pass;
+#endif
 static BIO *wb;
 static char *cert_dst;
 static bool verbose;

@@ -135,7 +137,9 @@ int main(int argc, char **argv)
 	if (verbose_env && strchr(verbose_env, '1'))
 		verbose = true;
 
-        key_pass = getenv("KBUILD_SIGN_PIN");
+#ifdef USE_PKCS11_ENGINE
+	key_pass = getenv("KBUILD_SIGN_PIN");
+#endif
 
 	if (argc != 3)
 		format();

index be28cbfd22e3..25af7697d6bb 100644
@@ -171,15 +171,13 @@ static void acomp_save_req(struct acomp_req *req, crypto_completion_t cplt)
 	state->compl = req->base.complete;
 	state->data = req->base.data;
 	req->base.complete = cplt;
-	req->base.data = state;
+	req->base.data = req;
 }
 
 static void acomp_restore_req(struct acomp_req *req)
 {
-	struct acomp_req_chain *state = req->base.data;
-
-	req->base.complete = state->compl;
-	req->base.data = state->data;
+	req->base.complete = req->chain.compl;
+	req->base.data = req->chain.data;
 }
 
 static void acomp_reqchain_virt(struct acomp_req *req)

index f8bd45f7dc83..cb651ab58d62 100644
@@ -72,8 +72,10 @@ static int _aead_recvmsg(struct socket *sock, struct msghdr *msg,
 	struct af_alg_ctx *ctx = ask->private;
 	struct crypto_aead *tfm = pask->private;
 	unsigned int as = crypto_aead_authsize(tfm);
+	unsigned int ivsize = crypto_aead_ivsize(tfm);
 	struct af_alg_async_req *areq;
 	struct scatterlist *rsgl_src, *tsgl_src = NULL;
+	void *iv;
 	int err = 0;
 	size_t used = 0;		/* [in]  TX bufs to be en/decrypted */
 	size_t outlen = 0;		/* [out] RX bufs produced by kernel */

@@ -125,10 +127,14 @@ static int _aead_recvmsg(struct socket *sock, struct msghdr *msg,
 
 	/* Allocate cipher request for current operation. */
 	areq = af_alg_alloc_areq(sk, sizeof(struct af_alg_async_req) +
-				     crypto_aead_reqsize(tfm));
+				     crypto_aead_reqsize(tfm) + ivsize);
 	if (IS_ERR(areq))
 		return PTR_ERR(areq);
 
+	iv = (u8 *)aead_request_ctx(&areq->cra_u.aead_req) +
+	     crypto_aead_reqsize(tfm);
+	memcpy(iv, ctx->iv, ivsize);
+
 	/* convert iovecs of output buffers into RX SGL */
 	err = af_alg_get_rsgl(sk, msg, flags, areq, outlen, &usedpages);
 	if (err)

@@ -187,7 +193,7 @@ static int _aead_recvmsg(struct socket *sock, struct msghdr *msg,
 
 	/* Initialize the crypto operation */
 	aead_request_set_crypt(&areq->cra_u.aead_req, tsgl_src,
-			       areq->first_rsgl.sgl.sgt.sgl, used, ctx->iv);
+			       areq->first_rsgl.sgl.sgt.sgl, used, iv);
 	aead_request_set_ad(&areq->cra_u.aead_req, ctx->aead_assoclen);
 	aead_request_set_tfm(&areq->cra_u.aead_req, tfm);
 

index af3d584e584f..522df41365d8 100644
@@ -390,6 +390,11 @@ static int crypto_authenc_esn_create(struct crypto_template *tmpl,
 	auth = crypto_spawn_ahash_alg(&ctx->auth);
 	auth_base = &auth->base;
 
+	if (auth->digestsize > 0 && auth->digestsize < 4) {
+		err = -EINVAL;
+		goto err_free_inst;
+	}
+
 	err = crypto_grab_skcipher(&ctx->enc, aead_crypto_instance(inst),
 				   crypto_attr_alg_name(tb[2]), 0, mask);
 	if (err)

index c3a9d4f2995c..ed0feaba2383 100644
@@ -69,6 +69,9 @@ static void pcrypt_aead_done(void *data, int err)
 	struct pcrypt_request *preq = aead_request_ctx(req);
 	struct padata_priv *padata = pcrypt_request_padata(preq);
 
+	if (err == -EINPROGRESS)
+		return;
+
 	padata->info = err;
 
 	padata_do_serial(padata);

@@ -82,7 +85,7 @@ static void pcrypt_aead_enc(struct padata_priv *padata)
 
 	ret = crypto_aead_encrypt(req);
 
-	if (ret == -EINPROGRESS)
+	if (ret == -EINPROGRESS || ret == -EBUSY)
 		return;
 
 	padata->info = ret;

@@ -133,7 +136,7 @@ static void pcrypt_aead_dec(struct padata_priv *padata)
 
 	ret = crypto_aead_decrypt(req);
 
-	if (ret == -EINPROGRESS)
+	if (ret == -EINPROGRESS || ret == -EBUSY)
 		return;
 
 	padata->info = ret;

index 3099dbca234a..01e14f787916 100644
@@ -182,7 +182,7 @@ void fw_devlink_purge_absent_suppliers(struct fwnode_handle *fwnode)
 	if (fwnode->dev)
 		return;
 
-	fwnode->flags |= FWNODE_FLAG_NOT_DEVICE;
+	fwnode_set_flag(fwnode, FWNODE_FLAG_NOT_DEVICE);
 	fwnode_links_purge_consumers(fwnode);
 
 	fwnode_for_each_available_child_node(fwnode, child)

@@ -228,7 +228,7 @@ static void __fw_devlink_pickup_dangling_consumers(struct fwnode_handle *fwnode,
 	if (fwnode->dev && fwnode->dev->bus)
 		return;
 
-	fwnode->flags |= FWNODE_FLAG_NOT_DEVICE;
+	fwnode_set_flag(fwnode, FWNODE_FLAG_NOT_DEVICE);
 	__fwnode_links_move_consumers(fwnode, new_sup);
 
 	fwnode_for_each_available_child_node(fwnode, child)

@@ -1012,7 +1012,7 @@ static void device_links_missing_supplier(struct device *dev)
 static bool dev_is_best_effort(struct device *dev)
 {
 	return (fw_devlink_best_effort && dev->can_match) ||
-		(dev->fwnode && (dev->fwnode->flags & FWNODE_FLAG_BEST_EFFORT));
+		(dev->fwnode && fwnode_test_flag(dev->fwnode, FWNODE_FLAG_BEST_EFFORT));
 }
 
 static struct fwnode_handle *fwnode_links_check_suppliers(

@@ -1723,11 +1723,11 @@ bool fw_devlink_is_strict(void)
 
 static void fw_devlink_parse_fwnode(struct fwnode_handle *fwnode)
 {
-	if (fwnode->flags & FWNODE_FLAG_LINKS_ADDED)
+	if (fwnode_test_flag(fwnode, FWNODE_FLAG_LINKS_ADDED))
 		return;
 
 	fwnode_call_int_op(fwnode, add_links);
-	fwnode->flags |= FWNODE_FLAG_LINKS_ADDED;
+	fwnode_set_flag(fwnode, FWNODE_FLAG_LINKS_ADDED);
 }
 
 static void fw_devlink_parse_fwtree(struct fwnode_handle *fwnode)

@@ -1885,7 +1885,7 @@ static bool fwnode_init_without_drv(struct fwnode_handle *fwnode)
 	struct device *dev;
 	bool ret;
 
-	if (!(fwnode->flags & FWNODE_FLAG_INITIALIZED))
+	if (!fwnode_test_flag(fwnode, FWNODE_FLAG_INITIALIZED))
 		return false;
 
 	dev = get_dev_from_fwnode(fwnode);

@@ -2001,10 +2001,10 @@ static bool __fw_devlink_relax_cycles(struct fwnode_handle *con_handle,
 	 * We aren't trying to find all cycles. Just a cycle between con and
 	 * sup_handle.
 	 */
-	if (sup_handle->flags & FWNODE_FLAG_VISITED)
+	if (fwnode_test_flag(sup_handle, FWNODE_FLAG_VISITED))
 		return false;
 
-	sup_handle->flags |= FWNODE_FLAG_VISITED;
+	fwnode_set_flag(sup_handle, FWNODE_FLAG_VISITED);
 
 	/* Termination condition. */
 	if (sup_handle == con_handle) {

@@ -2074,7 +2074,7 @@ static bool __fw_devlink_relax_cycles(struct fwnode_handle *con_handle,
 	}
 
 out:
-	sup_handle->flags &= ~FWNODE_FLAG_VISITED;
+	fwnode_clear_flag(sup_handle, FWNODE_FLAG_VISITED);
 	put_device(sup_dev);
 	put_device(con_dev);
 	put_device(par_dev);

@@ -2127,7 +2127,7 @@ static int fw_devlink_create_devlink(struct device *con,
 	 * When such a flag is set, we can't create device links where P is the
 	 * supplier of C as that would delay the probe of C.
 	 */
-	if (sup_handle->flags & FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD &&
+	if (fwnode_test_flag(sup_handle, FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD) &&
 	    fwnode_is_ancestor_of(sup_handle, con->fwnode))
 		return -EINVAL;
 

@@ -2150,7 +2150,7 @@ static int fw_devlink_create_devlink(struct device *con,
 	else
 		flags = FW_DEVLINK_FLAGS_PERMISSIVE;
 
-	if (sup_handle->flags & FWNODE_FLAG_NOT_DEVICE)
+	if (fwnode_test_flag(sup_handle, FWNODE_FLAG_NOT_DEVICE))
 		sup_dev = fwnode_get_next_parent_dev(sup_handle);
 	else
 		sup_dev = get_dev_from_fwnode(sup_handle);

@@ -2162,7 +2162,7 @@ static int fw_devlink_create_devlink(struct device *con,
 		 * supplier device indefinitely.
 		 */
 		if (sup_dev->links.status == DL_DEV_NO_DRIVER &&
-		    sup_handle->flags & FWNODE_FLAG_INITIALIZED) {
+		    fwnode_test_flag(sup_handle, FWNODE_FLAG_INITIALIZED)) {
 			dev_dbg(con,
 				"Not linking %pfwf - dev might never probe\n",
 				sup_handle);

@@ -3688,6 +3688,21 @@ int device_add(struct device *dev)
 		fw_devlink_link_device(dev);
 	}
 
+	/*
+	 * The moment the device was linked into the bus's "klist_devices" in
+	 * bus_add_device() then it's possible that probe could have been
+	 * attempted in a different thread via userspace loading a driver
+	 * matching the device. "ready_to_probe" being unset would have
+	 * blocked those attempts. Now that all of the above initialization has
+	 * happened, unblock probe. If probe happens through another thread
+	 * after this point but before bus_probe_device() runs then it's fine.
+	 * bus_probe_device() -> device_initial_probe() -> __device_attach()
+	 * will notice (under device_lock) that the device is already bound.
+	 */
+	device_lock(dev);
+	dev_set_ready_to_probe(dev);
+	device_unlock(dev);
+
 	bus_probe_device(dev);
 
 	/*

index 2996f4c667c4..2c3a610f52a7 100644
@@ -846,6 +846,26 @@ static int __driver_probe_device(const struct device_driver *drv, struct device
 	if (dev->driver)
 		return -EBUSY;
 
+	/*
+	 * In device_add(), the "struct device" gets linked into the subsystem's
+	 * list of devices and broadcast to userspace (via uevent) before we're
+	 * quite ready to probe. Those open pathways to driver probe before
+	 * we've finished enough of device_add() to reliably support probe.
+	 * Detect this and tell other pathways to try again later. device_add()
+	 * itself will also try to probe immediately after setting
+	 * "ready_to_probe".
+	 */
+	if (!dev_ready_to_probe(dev))
+		return dev_err_probe(dev, -EPROBE_DEFER, "Device not ready to probe\n");
+
+	/*
+	 * Set can_match = true after calling dev_ready_to_probe(), so
+	 * driver_deferred_probe_add() won't actually add the device to the
+	 * deferred probe list when dev_ready_to_probe() returns false.
+	 *
+	 * When dev_ready_to_probe() returns false, it means that device_add()
+	 * will do another probe() attempt for us.
+	 */
 	dev->can_match = true;
 	dev_dbg(dev, "bus: '%s': %s: matched device with driver %s\n",
 		drv->bus->name, __func__, drv->name);

index 8f441eb8b192..9236b5184bce 100644
@@ -7165,7 +7165,7 @@ static ssize_t do_rbd_add(const char *buf, size_t count)
 
 	rc = device_add_disk(&rbd_dev->dev, rbd_dev->disk, NULL);
 	if (rc)
-		goto err_out_cleanup_disk;
+		goto err_out_device;
 
 	spin_lock(&rbd_dev_list_lock);
 	list_add_tail(&rbd_dev->node, &rbd_dev_list);

@@ -7179,8 +7179,8 @@ static ssize_t do_rbd_add(const char *buf, size_t count)
 	module_put(THIS_MODULE);
 	return rc;
 
-err_out_cleanup_disk:
-	rbd_free_disk(rbd_dev);
+err_out_device:
+	device_del(&rbd_dev->dev);
 err_out_image_lock:
 	rbd_dev_image_unlock(rbd_dev);
 	rbd_dev_device_release(rbd_dev);

index a43074657531..dc6a53c9166a 100644
@@ -2308,7 +2308,7 @@ static void zram_bio_discard(struct zram *zram, struct bio *bio)
 	 */
 	if (offset) {
 		if (n <= (PAGE_SIZE - offset))
-			return;
+			goto end_bio;
 
 		n -= (PAGE_SIZE - offset);
 		index++;

@@ -2323,6 +2323,7 @@ static void zram_bio_discard(struct zram *zram, struct bio *bio)
 		n -= PAGE_SIZE;
 	}
 
+end_bio:
 	bio_endio(bio);
 }
 

index 83d623d97f5f..f735e0462c55 100644
@@ -332,7 +332,7 @@ static int of_weim_notify(struct notifier_block *nb, unsigned long action,
 			 * fw_devlink doesn't skip adding consumers to this
 			 * device.
 			 */
-			rd->dn->fwnode.flags &= ~FWNODE_FLAG_NOT_DEVICE;
+			fwnode_clear_flag(&rd->dn->fwnode, FWNODE_FLAG_NOT_DEVICE);
 			if (!of_platform_device_create(rd->dn, NULL, &pdev->dev)) {
 				dev_err(&pdev->dev,
 					"Failed to create child device '%pOF'\n",

index 21f0522d9ff2..b929c7d6c49a 100644
@@ -1380,7 +1380,7 @@ static int mhi_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 		goto err_unregister;
 	}
 
-	err = mhi_sync_power_up(mhi_cntrl);
+	err = mhi_async_power_up(mhi_cntrl);
 	if (err) {
 		dev_err(&pdev->dev, "failed to power up MHI controller\n");
 		goto err_unprepare;

67 lines not on this page · raw message

index dfeb28866a32..192063a20043 100644
@@ -283,7 +283,7 @@ static void tpm_dev_release(struct device *dev)
 	kfree(chip->work_space.context_buf);
 	kfree(chip->work_space.session_buf);
 #ifdef CONFIG_TCG_TPM2_HMAC
-	kfree(chip->auth);
+	kfree_sensitive(chip->auth);
 #endif
 	kfree(chip);
 }

index 58a8477cda85..fcd46b78c78b 100644
@@ -275,10 +275,8 @@ int tpm2_get_random(struct tpm_chip *chip, u8 *dest, size_t max)
 						NULL, 0);
 		tpm_buf_append_u16(&buf, num_bytes);
 		err = tpm_buf_fill_hmac_session(chip, &buf);
-		if (err) {
-			tpm_buf_destroy(&buf);
-			return err;
-		}
+		if (err)
+			goto out;
 
 		err = tpm_transmit_cmd(chip, &buf,
 				       offsetof(struct tpm2_get_random_out,

index 3f389e2f6f58..6e53a25f61d4 100644
@@ -203,8 +203,10 @@ static int tpm2_read_public(struct tpm_chip *chip, u32 handle, void *name)
 	rc = tpm_buf_read_u16(&buf, &offset);
 	name_size_alg = name_size(&buf.data[offset]);
 
-	if (name_size_alg < 0)
+	if (name_size_alg < 0) {
+		tpm_buf_destroy(&buf);
 		return name_size_alg;
+	}
 
 	if (rc != name_size_alg) {
 		tpm_buf_destroy(&buf);

@@ -217,6 +219,7 @@ static int tpm2_read_public(struct tpm_chip *chip, u32 handle, void *name)
 	}
 
 	memcpy(name, &buf.data[offset], rc);
+	tpm_buf_destroy(&buf);
 	return name_size_alg;
 }
 #endif /* CONFIG_TCG_TPM2_HMAC */

index 8954a8660ffc..8ea252beef7a 100644
@@ -472,6 +472,8 @@ static int tpm_tis_send_data(struct tpm_chip *chip, const u8 *buf, size_t len)
 		status = tpm_tis_status(chip);
 		if (!itpm && (status & TPM_STS_DATA_EXPECT) == 0) {
 			rc = -EIO;
+			dev_err(&chip->dev, "TPM_STS_DATA_EXPECT should be set. sts = 0x%08x\n",
+				status);
 			goto out_err;
 		}
 	}

@@ -492,6 +494,8 @@ static int tpm_tis_send_data(struct tpm_chip *chip, const u8 *buf, size_t len)
 	status = tpm_tis_status(chip);
 	if (!itpm && (status & TPM_STS_DATA_EXPECT) != 0) {
 		rc = -EIO;
+		dev_err(&chip->dev, "TPM_STS_DATA_EXPECT should be unset. sts = 0x%08x\n",
+			status);
 		goto out_err;
 	}
 

@@ -553,11 +557,16 @@ static int tpm_tis_send_main(struct tpm_chip *chip, const u8 *buf, size_t len)
 			break;
 		else if (rc != -EAGAIN && rc != -EIO)
 			/* Data transfer failed, not recoverable */
-			return rc;
+			goto out_err;
 
 		usleep_range(priv->timeout_min, priv->timeout_max);
 	}
 
+	if (rc == -EAGAIN || rc == -EIO) {
+		dev_err(&chip->dev, "Exhausted %d tpm_tis_send_data retries\n", TPM_RETRY);
+		goto out_err;
+	}
+
 	/* go and do it */
 	rc = tpm_tis_write8(priv, TPM_STS(priv->locality), TPM_STS_GO);
 	if (rc < 0)

index 3a2684208dda..5a6d64be8185 100644
@@ -2131,7 +2131,7 @@ static int atmel_aes_buff_init(struct atmel_aes_dev *dd)
 
 static void atmel_aes_buff_cleanup(struct atmel_aes_dev *dd)
 {
-	free_page((unsigned long)dd->buf);
+	free_pages((unsigned long)dd->buf, ATMEL_AES_BUFFER_ORDER);
 }
 
 static int atmel_aes_dma_init(struct atmel_aes_dev *dd)

index 0d48e64d28b1..9da5a0388080 100644
@@ -261,6 +261,7 @@ static int atmel_ecdh_init_tfm(struct crypto_kpp *tfm)
 	if (IS_ERR(fallback)) {
 		dev_err(&ctx->client->dev, "Failed to allocate transformation for '%s': %ld\n",
 			alg, PTR_ERR(fallback));
+		atmel_ecc_i2c_client_free(ctx->client);
 		return PTR_ERR(fallback);
 	}
 

index a895e4289efa..a85dfdc6b360 100644
@@ -72,8 +72,8 @@ EXPORT_SYMBOL(atmel_i2c_init_read_config_cmd);
 
 int atmel_i2c_init_read_otp_cmd(struct atmel_i2c_cmd *cmd, u16 addr)
 {
-	if (addr < 0 || addr > OTP_ZONE_SIZE)
-		return -1;
+	if (addr >= OTP_ZONE_SIZE / 4)
+		return -EINVAL;
 
 	cmd->word_addr = COMMAND;
 	cmd->opcode = OPCODE_READ;

index a12653a65869..ae04b27a9ad1 100644
@@ -15,6 +15,7 @@
 #include <linux/module.h>
 #include <linux/scatterlist.h>
 #include <linux/slab.h>
+#include <linux/sysfs.h>
 #include <linux/workqueue.h>
 #include "atmel-i2c.h"
 

@@ -95,19 +96,24 @@ static int atmel_sha204a_rng_read(struct hwrng *rng, void *data, size_t max,
 static int atmel_sha204a_otp_read(struct i2c_client *client, u16 addr, u8 *otp)
 {
 	struct atmel_i2c_cmd cmd;
-	int ret = -1;
+	int ret;
 
-	if (atmel_i2c_init_read_otp_cmd(&cmd, addr) < 0) {
+	ret = atmel_i2c_init_read_otp_cmd(&cmd, addr);
+	if (ret < 0) {
 		dev_err(&client->dev, "failed, invalid otp address %04X\n",
 			addr);
 		return ret;
 	}
 
 	ret = atmel_i2c_send_receive(client, &cmd);
+	if (ret < 0) {
+		dev_err(&client->dev, "failed to read otp at %04X\n", addr);
+		return ret;
+	}
 
 	if (cmd.data[0] == 0xff) {
 		dev_err(&client->dev, "failed, device not ready\n");
-		return -EINVAL;
+		return -EIO;
 	}
 
 	memcpy(otp, cmd.data+1, 4);

@@ -120,21 +126,22 @@ static ssize_t otp_show(struct device *dev,
 {
 	u16 addr;
 	u8 otp[OTP_ZONE_SIZE];
-	char *str = buf;
 	struct i2c_client *client = to_i2c_client(dev);
-	int i;
+	ssize_t len = 0;
+	int i, ret;
 
-	for (addr = 0; addr < OTP_ZONE_SIZE/4; addr++) {
-		if (atmel_sha204a_otp_read(client, addr, otp + addr * 4) < 0) {
+	for (addr = 0; addr < OTP_ZONE_SIZE / 4; addr++) {
+		ret = atmel_sha204a_otp_read(client, addr, otp + addr * 4);
+		if (ret < 0) {
 			dev_err(dev, "failed to read otp zone\n");
-			break;
+			return ret;
 		}
 	}
 
-	for (i = 0; i < addr*2; i++)
-		str += sprintf(str, "%02X", otp[i]);
-	str += sprintf(str, "\n");
-	return str - buf;
+	for (i = 0; i < OTP_ZONE_SIZE; i++)
+		len += sysfs_emit_at(buf, len, "%02X", otp[i]);
+	len += sysfs_emit_at(buf, len, "\n");
+	return len;
 }
 static DEVICE_ATTR_RO(otp);
 

@@ -191,10 +198,8 @@ static void atmel_sha204a_remove(struct i2c_client *client)
 {
 	struct atmel_i2c_client_priv *i2c_priv = i2c_get_clientdata(client);
 
-	if (atomic_read(&i2c_priv->tfm_count)) {
-		dev_emerg(&client->dev, "Device is busy, will remove it anyhow\n");
-		return;
-	}
+	devm_hwrng_unregister(&client->dev, &i2c_priv->hwrng);
+	atmel_i2c_flush_queue();
 
 	sysfs_remove_group(&client->dev.kobj, &atmel_sha204a_groups);
 

index 3b2a92029b16..d3bd8b72c2c9 100644
@@ -294,8 +294,8 @@ static int atmel_tdes_crypt_pdc_stop(struct atmel_tdes_dev *dd)
 		dma_unmap_sg(dd->dev, dd->out_sg, 1, DMA_FROM_DEVICE);
 		dma_unmap_sg(dd->dev, dd->in_sg, 1, DMA_TO_DEVICE);
 	} else {
-		dma_sync_single_for_device(dd->dev, dd->dma_addr_out,
-					   dd->dma_size, DMA_FROM_DEVICE);
+		dma_sync_single_for_cpu(dd->dev, dd->dma_addr_out,
+					dd->dma_size, DMA_FROM_DEVICE);
 
 		/* copy data */
 		count = atmel_tdes_sg_copy(&dd->out_sg, &dd->out_offset,

@@ -619,8 +619,8 @@ static int atmel_tdes_crypt_dma_stop(struct atmel_tdes_dev *dd)
 			dma_unmap_sg(dd->dev, dd->out_sg, 1, DMA_FROM_DEVICE);
 			dma_unmap_sg(dd->dev, dd->in_sg, 1, DMA_TO_DEVICE);
 		} else {
-			dma_sync_single_for_device(dd->dev, dd->dma_addr_out,
-				dd->dma_size, DMA_FROM_DEVICE);
+			dma_sync_single_for_cpu(dd->dev, dd->dma_addr_out,
+						dd->dma_size, DMA_FROM_DEVICE);
 
 			/* copy data */
 			count = atmel_tdes_sg_copy(&dd->out_sg, &dd->out_offset,

index c6d085c8ff79..73179bf725a7 100644
@@ -1448,6 +1448,7 @@ static int cc_mac_digest(struct ahash_request *req)
 	if (cc_map_hash_request_final(ctx->drvdata, state, req->src,
 				      req->nbytes, 1, flags)) {
 		dev_err(dev, "map_ahash_request_final() failed\n");
+		cc_unmap_result(dev, state, digestsize, req->result);
 		cc_unmap_req(dev, state, ctx);
 		return -ENOMEM;
 	}

index 1189effcdad0..512190b31b99 100644
@@ -844,7 +844,7 @@ static int sec_alg_skcipher_crypto(struct skcipher_request *skreq,
 	if (crypto_skcipher_ivsize(atfm))
 		dma_unmap_single(info->dev, sec_req->dma_iv,
 				 crypto_skcipher_ivsize(atfm),
-				 DMA_BIDIRECTIONAL);
+				 DMA_TO_DEVICE);
 err_unmap_out_sg:
 	if (split)
 		sec_unmap_sg_on_err(skreq->dst, steps, splits_out,

index c1dc9c56fdf5..f0d112e4b56c 100644
@@ -182,8 +182,10 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 		return ret;
 
 	ret = adf_dev_up(accel_dev, true);
-	if (ret)
+	if (ret) {
+		adf_dev_down(accel_dev);
 		return ret;
+	}
 
 	ret = devm_add_action_or_reset(dev, adf_device_down, accel_dev);
 	if (ret)

index b950fcce8a9b..8b1dc05df8c8 100644
@@ -115,10 +115,7 @@ void *nx842_crypto_alloc_ctx(struct nx842_driver *driver)
 	ctx->sbounce = (u8 *)__get_free_pages(GFP_KERNEL, BOUNCE_BUFFER_ORDER);
 	ctx->dbounce = (u8 *)__get_free_pages(GFP_KERNEL, BOUNCE_BUFFER_ORDER);
 	if (!ctx->wmem || !ctx->sbounce || !ctx->dbounce) {
-		kfree(ctx->wmem);
-		free_page((unsigned long)ctx->sbounce);
-		free_page((unsigned long)ctx->dbounce);
-		kfree(ctx);
+		nx842_crypto_free_ctx(ctx);
 		return ERR_PTR(-ENOMEM);
 	}
 

@@ -131,8 +128,9 @@ void nx842_crypto_free_ctx(void *p)
 	struct nx842_crypto_ctx *ctx = p;
 
 	kfree(ctx->wmem);
-	free_page((unsigned long)ctx->sbounce);
-	free_page((unsigned long)ctx->dbounce);
+	free_pages((unsigned long)ctx->sbounce, BOUNCE_BUFFER_ORDER);
+	free_pages((unsigned long)ctx->dbounce, BOUNCE_BUFFER_ORDER);
+	kfree(ctx);
 }
 EXPORT_SYMBOL_GPL(nx842_crypto_free_ctx);
 

index f5e2c82ba876..cd3c1a433e8c 100644
@@ -159,7 +159,7 @@ struct nx842_crypto_header_group {
 
 struct nx842_crypto_header {
 	/* New members MUST be added within the struct_group() macro below. */
-	struct_group_tagged(nx842_crypto_header_hdr, hdr,
+	__struct_group(nx842_crypto_header_hdr, hdr, __packed,
 		__be16 magic;		/* NX842_CRYPTO_MAGIC */
 		__be16 ignore;		/* decompressed end bytes to ignore */
 		u8 groups;		/* total groups in this header */

@@ -167,7 +167,7 @@ struct nx842_crypto_header {
 	struct nx842_crypto_header_group group[];
 } __packed;
 static_assert(offsetof(struct nx842_crypto_header, group) == sizeof(struct nx842_crypto_header_hdr),
-	      "struct member likely outside of struct_group_tagged()");
+	      "struct member likely outside of __struct_group()");
 
 #define NX842_CRYPTO_GROUP_MAX	(0x20)
 

421 lines not on this page · raw message

index 1a1092793092..f90723bc93d5 100644
@@ -868,12 +868,12 @@ static void remove_versalnet(struct mc_priv *priv)
 
 static int mc_probe(struct platform_device *pdev)
 {
-	struct device_node *r5_core_node;
 	struct mc_priv *priv;
 	struct rproc *rp;
 	int rc;
 
-	r5_core_node = of_parse_phandle(pdev->dev.of_node, "amd,rproc", 0);
+	struct device_node *r5_core_node __free(device_node) =
+		of_parse_phandle(pdev->dev.of_node, "amd,rproc", 0);
 	if (!r5_core_node) {
 		dev_err(&pdev->dev, "amd,rproc: invalid phandle\n");
 		return -EINVAL;

@@ -917,6 +917,7 @@ static int mc_probe(struct platform_device *pdev)
 
 err_init:
 	cdx_mcdi_finish(priv->mcdi);
+	kfree(priv->mcdi);
 
 err_unreg:
 	unregister_rpmsg_driver(&amd_rpmsg_driver);

@@ -938,6 +939,7 @@ static void mc_remove(struct platform_device *pdev)
 	remove_versalnet(priv);
 	rproc_shutdown(priv->mcdi->r5_rproc);
 	cdx_mcdi_finish(priv->mcdi);
+	kfree(priv->mcdi);
 }
 
 static const struct of_device_id amd_edac_match[] = {

index c68c9f56370f..f44183476ed7 100644
@@ -67,7 +67,7 @@ static int framebuffer_probe(struct coreboot_device *dev)
 		return -ENODEV;
 
 	memset(&res, 0, sizeof(res));
-	res.flags = IORESOURCE_MEM | IORESOURCE_BUSY;
+	res.flags = IORESOURCE_MEM;
 	res.name = "Coreboot Framebuffer";
 	res.start = fb->physical_address;
 	length = PAGE_ALIGN(fb->y_resolution * fb->bytes_per_line);

@@ -81,19 +81,10 @@ static int framebuffer_probe(struct coreboot_device *dev)
 						 sizeof(pdata));
 	if (IS_ERR(pdev))
 		pr_warn("coreboot: could not register framebuffer\n");
-	else
-		dev_set_drvdata(&dev->dev, pdev);
 
 	return PTR_ERR_OR_ZERO(pdev);
 }
 
-static void framebuffer_remove(struct coreboot_device *dev)
-{
-	struct platform_device *pdev = dev_get_drvdata(&dev->dev);
-
-	platform_device_unregister(pdev);
-}
-
 static const struct coreboot_device_id framebuffer_ids[] = {
 	{ .tag = CB_TAG_FRAMEBUFFER },
 	{ /* sentinel */ }

@@ -102,7 +93,6 @@ MODULE_DEVICE_TABLE(coreboot, framebuffer_ids);
 
 static struct coreboot_driver framebuffer_driver = {
 	.probe = framebuffer_probe,
-	.remove = framebuffer_remove,
 	.drv = {
 		.name = "framebuffer",
 	},

index b2033f8352f5..83f3b94ed975 100644
@@ -302,7 +302,6 @@ void amdgpu_gart_unbind(struct amdgpu_device *adev, uint64_t offset,
 			int pages)
 {
 	unsigned t;
-	unsigned p;
 	int i, j;
 	u64 page_base;
 	/* Starting from VEGA10, system bit must be 0 to mean invalid. */

@@ -316,8 +315,7 @@ void amdgpu_gart_unbind(struct amdgpu_device *adev, uint64_t offset,
 		return;
 
 	t = offset / AMDGPU_GPU_PAGE_SIZE;
-	p = t / AMDGPU_GPU_PAGES_IN_CPU_PAGE;
-	for (i = 0; i < pages; i++, p++) {
+	for (i = 0; i < pages; i++) {
 		page_base = adev->dummy_page_addr;
 		if (!adev->gart.ptr)
 			continue;

index 4183e5301cff..d629c5f73bf5 100644
@@ -75,6 +75,9 @@ static int amdgpu_ttm_init_on_chip(struct amdgpu_device *adev,
 				    unsigned int type,
 				    uint64_t size_in_page)
 {
+	if (!size_in_page)
+		return 0;
+
 	return ttm_range_man_init(&adev->mman.bdev, type,
 				  false, size_in_page);
 }

index dc8a17bcc3c8..82624b44e661 100644
@@ -100,7 +100,8 @@
 
 #define SOC15_DPG_MODE_OFFSET(ip, inst_idx, reg) 						\
 	({											\
-		uint32_t internal_reg_offset, addr;						\
+		/* To avoid a -Wunused-but-set-variable warning. */				\
+		uint32_t internal_reg_offset __maybe_unused, addr;				\
 		bool video_range, video1_range, aon_range, aon1_range;				\
 												\
 		addr = (adev->reg_offset[ip##_HWIP][inst_idx][reg##_BASE_IDX] + reg);		\

@@ -161,7 +162,8 @@
 
 #define SOC24_DPG_MODE_OFFSET(ip, inst_idx, reg)						\
 	({											\
-		uint32_t internal_reg_offset, addr;						\
+		/* To avoid a -Wunused-but-set-variable warning. */				\
+		uint32_t internal_reg_offset __maybe_unused, addr;				\
 		bool video_range, video1_range, aon_range, aon1_range;				\
 												\
 		addr = (adev->reg_offset[ip##_HWIP][inst_idx][reg##_BASE_IDX] + reg);		\

76 lines not on this page · raw message

index 53a088ebddef..6518d5639d66 100644
@@ -442,7 +442,6 @@ bool dc_dmub_srv_p_state_delegate(struct dc *dc, bool should_manage_pstate, stru
 	int i = 0, k = 0;
 	int ramp_up_num_steps = 1; // TODO: Ramp is currently disabled. Reenable it.
 	uint8_t visual_confirm_enabled;
-	int pipe_idx = 0;
 	struct dc_stream_status *stream_status = NULL;
 
 	if (dc == NULL)

@@ -457,7 +456,7 @@ bool dc_dmub_srv_p_state_delegate(struct dc *dc, bool should_manage_pstate, stru
 	cmd.fw_assisted_mclk_switch.config_data.visual_confirm_enabled = visual_confirm_enabled;
 
 	if (should_manage_pstate) {
-		for (i = 0, pipe_idx = 0; i < dc->res_pool->pipe_count; i++) {
+		for (i = 0; i < dc->res_pool->pipe_count; i++) {
 			struct pipe_ctx *pipe = &context->res_ctx.pipe_ctx[i];
 
 			if (!pipe->stream)

@@ -472,7 +471,6 @@ bool dc_dmub_srv_p_state_delegate(struct dc *dc, bool should_manage_pstate, stru
 				cmd.fw_assisted_mclk_switch.config_data.vactive_stretch_margin_us = dc->debug.fpo_vactive_margin_us;
 				break;
 			}
-			pipe_idx++;
 		}
 	}
 

@@ -872,7 +870,7 @@ void dc_dmub_setup_subvp_dmub_command(struct dc *dc,
 		bool enable)
 {
 	uint8_t cmd_pipe_index = 0;
-	uint32_t i, pipe_idx;
+	uint32_t i;
 	uint8_t subvp_count = 0;
 	union dmub_rb_cmd cmd;
 	struct pipe_ctx *subvp_pipes[2];

@@ -899,7 +897,7 @@ void dc_dmub_setup_subvp_dmub_command(struct dc *dc,
 
 	if (enable) {
 		// For each pipe that is a "main" SUBVP pipe, fill in pipe data for DMUB SUBVP cmd
-		for (i = 0, pipe_idx = 0; i < dc->res_pool->pipe_count; i++) {
+		for (i = 0; i < dc->res_pool->pipe_count; i++) {
 			struct pipe_ctx *pipe = &context->res_ctx.pipe_ctx[i];
 			pipe_mall_type = dc_state_get_pipe_subvp_type(context, pipe);
 

@@ -922,7 +920,6 @@ void dc_dmub_setup_subvp_dmub_command(struct dc *dc,
 				populate_subvp_cmd_vblank_pipe_info(dc, context, &cmd, pipe, cmd_pipe_index++);
 
 			}
-			pipe_idx++;
 		}
 		if (subvp_count == 2) {
 			update_subvp_prefetch_end_to_mall_start(dc, context, &cmd, subvp_pipes);

index dc469e571c0a..b760586b1727 100644
@@ -874,7 +874,7 @@ static int nouveau_drm_probe(struct pci_dev *pdev,
 	/* Remove conflicting drivers (vesafb, efifb etc). */
 	ret = aperture_remove_conflicting_pci_devices(pdev, driver_pci.name);
 	if (ret)
-		return ret;
+		goto fail_nvkm;
 
 	pci_set_master(pdev);
 

index 690e10fbf0bd..f6cfb6ea4885 100644
@@ -686,7 +686,7 @@ nouveau_gem_pushbuf_reloc_apply(struct nouveau_cli *cli,
 		}
 		nvbo = (void *)(unsigned long)bo[r->reloc_bo_index].user_priv;
 
-		if (unlikely(r->reloc_bo_offset + 4 >
+		if (unlikely((u64)r->reloc_bo_offset + 4 >
 			     nvbo->bo.base.size)) {
 			NV_PRINTK(err, cli, "reloc outside of bo\n");
 			ret = -EINVAL;

index 7cf0f0ea1bfe..c74466ea2535 100644
@@ -250,7 +250,8 @@ DEFINE_DRM_GEM_DMA_FOPS(arcpgu_drm_ops);
 static int arcpgu_load(struct arcpgu_drm_private *arcpgu)
 {
 	struct platform_device *pdev = to_platform_device(arcpgu->drm.dev);
-	struct device_node *encoder_node = NULL, *endpoint_node = NULL;
+	struct device_node *encoder_node __free(device_node) = NULL;
+	struct device_node *endpoint_node = NULL;
 	struct drm_connector *connector = NULL;
 	struct drm_device *drm = &arcpgu->drm;
 	int ret;

132 lines not on this page · raw message

index 9dcb252c5d6c..cb1bd6dca835 100644

Lines of this file are not shown. View the raw message.

index c2e559dde63f..c5a34ceedcdb 100644

Lines of this file are not shown. View the raw message.

index a75b941bd6e2..96438f5f05d4 100644

Lines of this file are not shown. View the raw message.

index 20e3cfa625f1..89d4da8aa4c0 100644

Lines of this file are not shown. View the raw message.

index eb7fb202355f..354a88d0599e 100644

Lines of this file are not shown. View the raw message.

index 872c88d0c86c..45d2cb77d5ec 100644

Lines of this file are not shown. View the raw message.

index cdc624889559..418452aaca81 100644

Lines of this file are not shown. View the raw message.

90 lines not on this page · raw message

index 35ba852a172a..d2a075a781ce 100644

Lines of this file are not shown. View the raw message.

index 48c1f4977f21..960878b53da8 100644

Lines of this file are not shown. View the raw message.

index 5861e4244049..f79214738c2b 100644

Lines of this file are not shown. View the raw message.

index bf498bd4dea9..4efdb467b6c6 100644

Lines of this file are not shown. View the raw message.

index a460782dadca..ce0e61452af2 100644

Lines of this file are not shown. View the raw message.

index 268f734ca9c3..bc8e04f6832a 100644

Lines of this file are not shown. View the raw message.

index bcb6eae1c711..0526e742062a 100644

Lines of this file are not shown. View the raw message.

index d58ae150b450..706037d2a87c 100644

Lines of this file are not shown. View the raw message.

48 lines not on this page · raw message

index 3b711a1198ad..b9f0d01ce01c 100644

Lines of this file are not shown. View the raw message.

index 300935b1ef24..4734c7b4d37b 100644

Lines of this file are not shown. View the raw message.

index 1fb887b9098c..369e7b1e61d4 100644

Lines of this file are not shown. View the raw message.

index 6268d651bdcf..a2518793c685 100644

Lines of this file are not shown. View the raw message.

index e034c93d57cf..e7e31776453c 100644

Lines of this file are not shown. View the raw message.

index 560a26f3965c..dde446a95eaa 100644

Lines of this file are not shown. View the raw message.

index c55223ce4327..256058a6e247 100644

Lines of this file are not shown. View the raw message.

index 081827bc0596..7c677b0344c6 100644

Lines of this file are not shown. View the raw message.

index b26c930e3edb..0aecf366e61b 100644

Lines of this file are not shown. View the raw message.

index 6922dc6c10db..5313230f36ad 100644

Lines of this file are not shown. View the raw message.

index ec816d3b38cb..521531738c9a 100644

Lines of this file are not shown. View the raw message.

index e6a1d3534663..bea7a47d216e 100644

Lines of this file are not shown. View the raw message.

163 lines not on this page · raw message

index 204b92af6c47..843ec2497b52 100644

Lines of this file are not shown. View the raw message.

209 lines not on this page · raw message

index c0ffe0817fd4..6113bb927946 100644

Lines of this file are not shown. View the raw message.

index 1498840a4ea0..c254e6580afd 100644

Lines of this file are not shown. View the raw message.

index 5ae4e11b1e90..5b7ffc359414 100644

Lines of this file are not shown. View the raw message.

index c93769c233d9..a46010ea459a 100644

Lines of this file are not shown. View the raw message.

index 4870b2d5edb2..af377b917a10 100644

Lines of this file are not shown. View the raw message.

index 175211fe6a5e..db02c14ba16f 100644

Lines of this file are not shown. View the raw message.

index 6c90b4a7d955..c3ebb648d8b0 100644

Lines of this file are not shown. View the raw message.

index 31f75b4a67fd..b795a3a60571 100644

Lines of this file are not shown. View the raw message.

69 lines not on this page · raw message

index 78695be2570b..9f1c33f6ddec 100644

Lines of this file are not shown. View the raw message.

index c862b13b447a..28a7ff7644bb 100644

Lines of this file are not shown. View the raw message.

index 729133c1e5e4..abb207339992 100644

Lines of this file are not shown. View the raw message.

index c4c4d70d8466..1377ea90a8c2 100644

Lines of this file are not shown. View the raw message.

index 03f1b9bc604d..9b6f5cd3fdd7 100644

Lines of this file are not shown. View the raw message.

index 5cb59d72bc82..2f8626c3824d 100644

Lines of this file are not shown. View the raw message.

index 7288b25d6b8c..7523f7763d36 100644

Lines of this file are not shown. View the raw message.

index a2391d4b7e5c..fe32730be3a7 100644

Lines of this file are not shown. View the raw message.

index 4820010a86f6..5902e2c821f2 100644

Lines of this file are not shown. View the raw message.

index 458cfd0260b1..b0c6dfa55cc6 100644

Lines of this file are not shown. View the raw message.

51 lines not on this page · raw message

index a17c1084931b..25e5fd48b8e2 100644

Lines of this file are not shown. View the raw message.

index 56b16186d3aa..ec0a45bfb670 100644

Lines of this file are not shown. View the raw message.

index 2ba7244fdaf1..9a0071bd791c 100644

Lines of this file are not shown. View the raw message.

index a64b4b4a18a1..8875855e4535 100644

Lines of this file are not shown. View the raw message.

index 2fd27ea0310c..6620bf07b79b 100644

Lines of this file are not shown. View the raw message.

index 2eaaddcb0ec4..ab10c180c488 100644

Lines of this file are not shown. View the raw message.

index a6dca3a005aa..da023bc0b5fa 100644

Lines of this file are not shown. View the raw message.

index 9c184e93f50c..02b780b6e8e2 100644

Lines of this file are not shown. View the raw message.

56 lines not on this page · raw message

index a42164c87054..3984c16dbec3 100644

Lines of this file are not shown. View the raw message.

index 6643a88c7a0c..2f077d0b7957 100644

Lines of this file are not shown. View the raw message.

56 lines not on this page · raw message

index 0a0d2d9fc846..68f1ba8fec4a 100644

Lines of this file are not shown. View the raw message.

index ac05942e4e6a..ca52c2c82b2c 100644

Lines of this file are not shown. View the raw message.

index 5b399de16d60..80fdb3303400 100644

Lines of this file are not shown. View the raw message.

index 0b7b173d0d26..b30f660a1c55 100644

Lines of this file are not shown. View the raw message.

64 lines not on this page · raw message

index 850ca49186fd..d28ddb34e19e 100644

Lines of this file are not shown. View the raw message.

index 0252d3f6bed1..072d4c4add33 100644

Lines of this file are not shown. View the raw message.

index 79d2f9ab4ef0..ded093566260 100644

Lines of this file are not shown. View the raw message.

index bbf1fd4fe1e9..dc7ffa8cb287 100644

Lines of this file are not shown. View the raw message.

63 lines not on this page · raw message

index f28c15dd0b92..61e6dc81dc92 100644

Lines of this file are not shown. View the raw message.

45 lines not on this page · raw message

index 647e98f4e351..fecc7d7e2f0d 100644

Lines of this file are not shown. View the raw message.

index d84dded5333f..a8dee373a485 100644

Lines of this file are not shown. View the raw message.

index 986fa2a45fa4..a588d6fc478b 100644

Lines of this file are not shown. View the raw message.

index 5dd5f5ad7686..a9639730cfdf 100644

Lines of this file are not shown. View the raw message.

index 172e48caa3a0..94374b5fc989 100644

Lines of this file are not shown. View the raw message.

index c7d7e27af386..7980f93a8631 100644

Lines of this file are not shown. View the raw message.

index 7dd0ac866461..405add0adceb 100644

Lines of this file are not shown. View the raw message.

index f66a92294284..fc15497608c6 100644

Lines of this file are not shown. View the raw message.

index 45e5edecc0cb..66e592c47e57 100644

Lines of this file are not shown. View the raw message.

index 32b4f5aa60c9..2b388775be16 100644

Lines of this file are not shown. View the raw message.

index e10c376843d7..4aac18942ecc 100644

Lines of this file are not shown. View the raw message.

index 4ed8ddf2a60b..f0522a4538d1 100644

Lines of this file are not shown. View the raw message.

index 34244fccf2ed..762f03dcbcd7 100644

Lines of this file are not shown. View the raw message.

index 1467f6790747..c3a18061ce11 100644

Lines of this file are not shown. View the raw message.

index 2e596244799f..61216b30cb93 100644

Lines of this file are not shown. View the raw message.

index 4ff0e9dd1145..495cace1e564 100644

Lines of this file are not shown. View the raw message.

index 3745c59f0af2..711812d83990 100644

Lines of this file are not shown. View the raw message.

index b372fb2c56bd..0d813c52ff9c 100644

Lines of this file are not shown. View the raw message.

index 21decc292282..de9081be462e 100644

Lines of this file are not shown. View the raw message.

74 lines not on this page · raw message

index 54c6cc7fe9c6..df18fb453403 100644

Lines of this file are not shown. View the raw message.

index 47edf3041631..1ca95ef46a73 100644

Lines of this file are not shown. View the raw message.

index 7a5c5ef2db92..dc9562c0cdc6 100644

Lines of this file are not shown. View the raw message.

index 4db02816d0fd..8b2ef98c81ef 100644

Lines of this file are not shown. View the raw message.

index 4ade54445532..d18c43598d4b 100644

Lines of this file are not shown. View the raw message.

index d40ac39bfbe8..02de2ede560f 100644

Lines of this file are not shown. View the raw message.

index 1a8a79d7e4e8..6fe6f7fcf83d 100644

Lines of this file are not shown. View the raw message.

45 lines not on this page · raw message

44 lines not on this page · raw message

index 0660a03d37d9..846185ea626c 100644

Lines of this file are not shown. View the raw message.

index 38a82d65e58e..951d33362268 100644

Lines of this file are not shown. View the raw message.

index 1d982dbdd0d0..5d3916ca747c 100644

Lines of this file are not shown. View the raw message.

index 3e2005e9e2f0..2a540a9065de 100644

Lines of this file are not shown. View the raw message.

index 891368e82558..aff8ea2fa98e 100644

Lines of this file are not shown. View the raw message.

index 2511f1e5b114..375ee6e202db 100644

Lines of this file are not shown. View the raw message.

index 0921485565c0..857f45a3386c 100644

Lines of this file are not shown. View the raw message.

index c3207ce98f07..4c0e4655b6c7 100644

Lines of this file are not shown. View the raw message.

index 578b8038b211..573f2df3a2c9 100644

Lines of this file are not shown. View the raw message.

index 07a3116811c5..048a62538242 100644

Lines of this file are not shown. View the raw message.

index 869c7b2a08b6..a5e78747e63a 100644

Lines of this file are not shown. View the raw message.

index faa44dd32cd5..6c4ef485212d 100644

Lines of this file are not shown. View the raw message.

index cd42316d0f3c..dec1d13ca420 100644

Lines of this file are not shown. View the raw message.

index 924a9e10106b..34e6b94c2212 100644

Lines of this file are not shown. View the raw message.

index c80902eacd79..e6c6dd086887 100644

Lines of this file are not shown. View the raw message.

index 582c3847f483..421efba7db5a 100644

Lines of this file are not shown. View the raw message.

index d4d994fb8999..a892a01c463e 100644

Lines of this file are not shown. View the raw message.

index ed37ab9209e5..f750dea7b787 100644

Lines of this file are not shown. View the raw message.

index 0cd680ccc7e5..73bd6a6a7893 100644

Lines of this file are not shown. View the raw message.

index 5a807d62e76d..43b27f07730c 100644

Lines of this file are not shown. View the raw message.

index 656cd8df2d55..a31fb4b7a52e 100644

Lines of this file are not shown. View the raw message.

109 lines not on this page · raw message

86 lines not on this page · raw message

index 5520dc28255a..29466c1803c9 100644

Lines of this file are not shown. View the raw message.

60 lines not on this page · raw message

index 3a55f6e41dc4..eb728a89924e 100644

Lines of this file are not shown. View the raw message.

index 91dcfe14a67b..e3339cf37a1f 100644

Lines of this file are not shown. View the raw message.

index 13293976e056..ba563307278d 100644

Lines of this file are not shown. View the raw message.

index c80c6f566c2d..f5c0d927924d 100644

Lines of this file are not shown. View the raw message.

index 94327574fbbb..779a8cc17a83 100644

Lines of this file are not shown. View the raw message.

index a936623d0b23..ad7af66a4450 100644

Lines of this file are not shown. View the raw message.

index bb0776f5ef7c..f59c6d8d376f 100644

Lines of this file are not shown. View the raw message.

index 6288c7e4b971..f67696618003 100644

Lines of this file are not shown. View the raw message.

index 5b038d1c8250..a89df6ddcc58 100644

Lines of this file are not shown. View the raw message.

index 3c5a50ae3274..4bf64fd610c9 100644

Lines of this file are not shown. View the raw message.

index 5815ae9e5770..eeb6a187c3d8 100644

Lines of this file are not shown. View the raw message.

index e2f526ad7abb..021fc2526886 100644

Lines of this file are not shown. View the raw message.

index 5bf832f9c05c..bb1f1e124dc0 100644

Lines of this file are not shown. View the raw message.

index 7794f4f98159..c66443f4cf5a 100644

Lines of this file are not shown. View the raw message.

index 6b5595868a39..7ace0f4941bb 100644

Lines of this file are not shown. View the raw message.

index e2c17f620f00..6eb3ab69a514 100644

Lines of this file are not shown. View the raw message.

index 171fa32ada85..d687fd0b4ed3 100644

Lines of this file are not shown. View the raw message.

index 0d75679c6a7e..23d109cb0c6b 100644

Lines of this file are not shown. View the raw message.

index 980aa17f3534..fc0a93f43313 100644

Lines of this file are not shown. View the raw message.

index 7a2f116106e9..ed773cd48876 100644

Lines of this file are not shown. View the raw message.

index 1d509b6d16bb..ec03bcff6b65 100644

Lines of this file are not shown. View the raw message.

index c7942cf65567..4e10adcd70e8 100644

Lines of this file are not shown. View the raw message.

index d6a0f7df9080..ead677bca490 100644

Lines of this file are not shown. View the raw message.

index bee225c821ed..d4fdaac8037a 100644

Lines of this file are not shown. View the raw message.

index d550910aabec..af990c600745 100644

Lines of this file are not shown. View the raw message.

86 lines not on this page · raw message

index 00dbcd4d28e6..34d9333e4229 100644

Lines of this file are not shown. View the raw message.

index 96ecb83c9071..27c2aa2dd023 100644

Lines of this file are not shown. View the raw message.

index fec59d9338b9..fdd683261226 100644

Lines of this file are not shown. View the raw message.

43 lines not on this page · raw message

index 697956931925..dc5184a2fa9d 100644

Lines of this file are not shown. View the raw message.

index 30275cb5ba3e..0ef2a29eb695 100644

Lines of this file are not shown. View the raw message.

index 80164d89e19c..1e257d7ab8ec 100644

Lines of this file are not shown. View the raw message.

112 lines not on this page · raw message

index 3bcd6ee80396..e2169d1a14b5 100644

Lines of this file are not shown. View the raw message.

index 87c87edadde7..9772b466c72a 100644

Lines of this file are not shown. View the raw message.

index e659fea2da70..e3c6abe58f44 100644

Lines of this file are not shown. View the raw message.

index 777ea5c2431c..4ce9e5d7f3dd 100644

Lines of this file are not shown. View the raw message.

index 13c9bfdf65ff..3a4ef7bd3b5d 100644

Lines of this file are not shown. View the raw message.

index 0cb3edde4d18..cc419de75cd6 100644

Lines of this file are not shown. View the raw message.

index f4d43c854bbd..b2afb45aa437 100644

Lines of this file are not shown. View the raw message.

71 lines not on this page · raw message

index 9c3fd5113a61..c714f2e5596b 100644

Lines of this file are not shown. View the raw message.

index 88d9e1f9a6e9..5aca09edf971 100644

Lines of this file are not shown. View the raw message.

index 8a142fd54a19..307ef98c44c7 100644

Lines of this file are not shown. View the raw message.

43 lines not on this page · raw message

index 19b3f306c564..58fef1250f65 100644

Lines of this file are not shown. View the raw message.

index 8e8ba928d3c0..622cd353bf25 100644

Lines of this file are not shown. View the raw message.

index 14779b383d9e..d65c7dd73806 100644

Lines of this file are not shown. View the raw message.

index 7aa20fcf1a33..0c66c8bb2f89 100644

Lines of this file are not shown. View the raw message.

index 9bd8dcbb68e4..7c2274120c76 100644

Lines of this file are not shown. View the raw message.

52 lines not on this page · raw message

index 51177ebfb8c6..b20aae0caf60 100644

Lines of this file are not shown. View the raw message.

index a9130891bb69..5c70fdf61cc1 100644

Lines of this file are not shown. View the raw message.

index 77c4330d5295..15490a87b460 100644

Lines of this file are not shown. View the raw message.

index 53b5dc5453b7..133595d79d92 100644

Lines of this file are not shown. View the raw message.

index 16eaa9fa317d..0765250f3a56 100644

Lines of this file are not shown. View the raw message.

index 4873b5e74801..7126a2cf9e79 100644

Lines of this file are not shown. View the raw message.

41 lines not on this page · raw message

index e8dee05a6264..46e5986ad927 100644

Lines of this file are not shown. View the raw message.

index 1c3abb43c8d7..1a0a1dacebc3 100644

Lines of this file are not shown. View the raw message.

index b1be847446fe..c513db41137f 100644

Lines of this file are not shown. View the raw message.

index 40d918aedce6..ebd900e713c1 100644

Lines of this file are not shown. View the raw message.

107 lines not on this page · raw message

124 lines not on this page · raw message

index 3bbc0508420b..957a06fde592 100644

Lines of this file are not shown. View the raw message.

index 4e356334ecb7..84ccdb8f594a 100644

Lines of this file are not shown. View the raw message.

index 6825082c079c..5a1afc640c77 100644

Lines of this file are not shown. View the raw message.

index b479a359da12..77ba3fa4e2c8 100644

Lines of this file are not shown. View the raw message.

index dc976a285ad2..9f724954a0f6 100644

Lines of this file are not shown. View the raw message.